Skip to content

Commit 3a66b67

Browse files
authored
chore(llc): improve test coverage for activity (#41)
1 parent d418f89 commit 3a66b67

File tree

6 files changed

+578
-4
lines changed

6 files changed

+578
-4
lines changed

packages/stream_feeds/lib/src/client/feeds_client_impl.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ class StreamFeedsClientImpl implements StreamFeedsClient {
6767
NetworkStateProvider? networkStateProvider,
6868
LifecycleStateProvider? lifecycleStateProvider,
6969
List<AutomaticReconnectionPolicy>? reconnectionPolicies,
70+
WebSocketProvider? wsProvider,
71+
api.DefaultApi? feedsRestApi,
7072
}) {
7173
// TODO: Make this configurable
7274
const endpointConfig = EndpointConfig.production;
@@ -107,6 +109,7 @@ class StreamFeedsClientImpl implements StreamFeedsClient {
107109
event_resolvers.pollAnswerCastedFeedEventResolver,
108110
event_resolvers.pollAnswerRemovedFeedEventResolver,
109111
],
112+
wsProvider: wsProvider,
110113
);
111114

112115
_connectionRecoveryHandler = ConnectionRecoveryHandler(
@@ -154,7 +157,7 @@ class StreamFeedsClientImpl implements StreamFeedsClient {
154157
_cdnClient = config.cdnClient ?? FeedsCdnClient(CdnApi(httpClient));
155158
attachmentUploader = StreamAttachmentUploader(cdn: _cdnClient);
156159

157-
final feedsApi = api.DefaultApi(httpClient);
160+
final feedsApi = feedsRestApi ?? api.DefaultApi(httpClient);
158161

159162
_activitiesRepository = ActivitiesRepository(feedsApi, attachmentUploader);
160163
_appRepository = AppRepository(feedsApi);

packages/stream_feeds/pubspec.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,5 @@ dev_dependencies:
4141
json_serializable: ^6.9.5
4242
mocktail: ^1.0.4
4343
retrofit_generator: ^9.6.0
44-
test: ^1.26.3
44+
test: ^1.26.3
45+
web_socket_channel: ^3.0.3

packages/stream_feeds/test/client/feeds_client_impl_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import 'package:stream_feeds/src/client/feeds_client_impl.dart';
22
import 'package:stream_feeds/stream_feeds.dart';
33
import 'package:test/test.dart';
44

5-
const testToken =
6-
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibHVrZV9za3l3YWxrZXIifQ.hZ59SWtp_zLKVV9ShkqkTsCGi_jdPHly7XNCf5T_Ev0';
5+
import '../mocks.dart';
6+
77
void main() {
88
test('Create a feeds client', () {
99
final client = StreamFeedsClient(

packages/stream_feeds/test/mocks.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,21 @@ import 'package:mocktail/mocktail.dart';
22
import 'package:stream_feeds/src/client/feeds_client_impl.dart';
33
import 'package:stream_feeds/src/repository/feeds_repository.dart';
44
import 'package:stream_feeds/stream_feeds.dart';
5+
import 'package:stream_feeds/stream_feeds.dart' as api;
6+
import 'package:web_socket_channel/web_socket_channel.dart';
57

68
class MockFeedsRepository extends Mock implements FeedsRepository {}
79

810
class MockFeedsClient extends Mock implements StreamFeedsClient {}
911

1012
class MockWebSocketClient extends Mock implements StreamWebSocketClient {}
1113

14+
class MockDefaultApi extends Mock implements api.DefaultApi {}
15+
16+
class MockWebSocketChannel extends Mock implements WebSocketChannel {}
17+
18+
class MockWebSocketSink extends Mock implements WebSocketSink {}
19+
1220
class FakeFeedsClient extends Fake implements StreamFeedsClientImpl {
1321
FakeFeedsClient({
1422
User? user,
@@ -25,3 +33,6 @@ const fakeUser = User(
2533
id: 'user_id',
2634
name: 'user_name',
2735
);
36+
37+
const testToken =
38+
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibHVrZV9za3l3YWxrZXIifQ.hZ59SWtp_zLKVV9ShkqkTsCGi_jdPHly7XNCf5T_Ev0';

0 commit comments

Comments
 (0)