fix analyzer issues

Author: renefloor

sample_app/lib/screens/user_feed/feed/user_feed_item.dart

@@ -9,7 +9,6 @@ import '../../../widgets/action_button.dart';
 import '../../../widgets/attachment_gallery/attachment_metadata.dart';
 import '../../../widgets/attachments/attachments.dart';
 import '../../../widgets/user_avatar.dart';
-import '../polls/show_poll/poll_message.dart';
 import '../polls/show_poll/show_poll_widget.dart';
 
 class UserFeedItem extends StatelessWidget {

sample_app/lib/screens/user_feed/polls/create_poll/poll_option_reorderable_list_view.dart

@@ -205,7 +205,9 @@ class _PollOptionReorderableListViewState
   }
 
   void _disposeOptions() {
-    _focusNodes.values.forEach((it) => it.dispose());
+    for (final it in _focusNodes.values) {
+      it.dispose();
+    }
     _focusNodes.clear();
     _options.clear();
   }
@@ -462,15 +464,15 @@ class SeparatedReorderableListView extends ReorderableListView {
 
             // Ideally should never happen as separators are wrapped in the
             // IgnorePointer widget. This is just a safety check.
-            if (oldIndex % 2 == 1) return;
+            if (oldIndex.isOdd) return;
 
             // The item moved behind the top/bottom separator we should not
             // reorder it.
             if ((oldIndex - newIndex).abs() == 1) return;
 
             // Calculate the updated indexes
             final updatedOldIndex = oldIndex ~/ 2;
-            final updatedNewIndex = oldIndex > newIndex && newIndex % 2 == 1
+            final updatedNewIndex = oldIndex > newIndex && newIndex.isOdd
                 ? (newIndex + 1) ~/ 2
                 : newIndex ~/ 2;
 

sample_app/lib/screens/user_feed/polls/create_poll/stream_poll_controller.dart

@@ -208,141 +208,3 @@ sealed class PollValidationError with _$PollValidationError {
     required Range<int> range,
   }) = _PollValidationErrorMaxVotesAllowed;
 }
-
-// coverage:ignore-start
-
-/// @nodoc
-extension PollValidationErrorPatternMatching on PollValidationError {
-  /// @nodoc
-  @optionalTypeArgs
-  TResult when<TResult extends Object?>({
-    required TResult Function(List<PollOptionInputState> options)
-        duplicateOptions,
-    required TResult Function(String name, Range<int> range) nameRange,
-    required TResult Function(
-            List<PollOptionInputState> options, Range<int> range)
-        optionsRange,
-    required TResult Function(int maxVotesAllowed, Range<int> range)
-        maxVotesAllowed,
-  }) {
-    final error = this;
-    return switch (error) {
-      _PollValidationErrorDuplicateOptions() => duplicateOptions(error.options),
-      _PollValidationErrorNameRange() => nameRange(error.name, error.range),
-      _PollValidationErrorOptionsRange() =>
-        optionsRange(error.options, error.range),
-      _PollValidationErrorMaxVotesAllowed() =>
-        maxVotesAllowed(error.maxVotesAllowed, error.range),
-    };
-  }
-
-  /// @nodoc
-  @optionalTypeArgs
-  TResult? whenOrNull<TResult extends Object?>({
-    TResult? Function(List<PollOptionInputState> options)? duplicateOptions,
-    TResult? Function(String name, Range<int> range)? nameRange,
-    TResult? Function(List<PollOptionInputState> options, Range<int> range)?
-        optionsRange,
-    TResult? Function(int maxVotesAllowed, Range<int> range)? maxVotesAllowed,
-  }) {
-    final error = this;
-    return switch (error) {
-      _PollValidationErrorDuplicateOptions() =>
-        duplicateOptions?.call(error.options),
-      _PollValidationErrorNameRange() =>
-        nameRange?.call(error.name, error.range),
-      _PollValidationErrorOptionsRange() =>
-        optionsRange?.call(error.options, error.range),
-      _PollValidationErrorMaxVotesAllowed() =>
-        maxVotesAllowed?.call(error.maxVotesAllowed, error.range),
-    };
-  }
-
-  /// @nodoc
-  @optionalTypeArgs
-  TResult maybeWhen<TResult extends Object?>({
-    TResult Function(List<PollOptionInputState> options)? duplicateOptions,
-    TResult Function(String name, Range<int> range)? nameRange,
-    TResult Function(List<PollOptionInputState> options, Range<int> range)?
-        optionsRange,
-    TResult Function(int maxVotesAllowed, Range<int> range)? maxVotesAllowed,
-    required TResult orElse(),
-  }) {
-    final error = this;
-    final result = switch (error) {
-      _PollValidationErrorDuplicateOptions() =>
-        duplicateOptions?.call(error.options),
-      _PollValidationErrorNameRange() =>
-        nameRange?.call(error.name, error.range),
-      _PollValidationErrorOptionsRange() =>
-        optionsRange?.call(error.options, error.range),
-      _PollValidationErrorMaxVotesAllowed() =>
-        maxVotesAllowed?.call(error.maxVotesAllowed, error.range),
-    };
-
-    return result ?? orElse();
-  }
-
-  /// @nodoc
-  @optionalTypeArgs
-  TResult map<TResult extends Object?>({
-    required TResult Function(_PollValidationErrorDuplicateOptions value)
-        duplicateOptions,
-    required TResult Function(_PollValidationErrorNameRange value) nameRange,
-    required TResult Function(_PollValidationErrorOptionsRange value)
-        optionsRange,
-    required TResult Function(_PollValidationErrorMaxVotesAllowed value)
-        maxVotesAllowed,
-  }) {
-    final error = this;
-    return switch (error) {
-      _PollValidationErrorDuplicateOptions() => duplicateOptions(error),
-      _PollValidationErrorNameRange() => nameRange(error),
-      _PollValidationErrorOptionsRange() => optionsRange(error),
-      _PollValidationErrorMaxVotesAllowed() => maxVotesAllowed(error),
-    };
-  }
-
-  /// @nodoc
-  @optionalTypeArgs
-  TResult? mapOrNull<TResult extends Object?>({
-    TResult? Function(_PollValidationErrorDuplicateOptions value)?
-        duplicateOptions,
-    TResult? Function(_PollValidationErrorNameRange value)? nameRange,
-    TResult? Function(_PollValidationErrorOptionsRange value)? optionsRange,
-    TResult? Function(_PollValidationErrorMaxVotesAllowed value)?
-        maxVotesAllowed,
-  }) {
-    final error = this;
-    return switch (error) {
-      _PollValidationErrorDuplicateOptions() => duplicateOptions?.call(error),
-      _PollValidationErrorNameRange() => nameRange?.call(error),
-      _PollValidationErrorOptionsRange() => optionsRange?.call(error),
-      _PollValidationErrorMaxVotesAllowed() => maxVotesAllowed?.call(error),
-    };
-  }
-
-  /// @nodoc
-  @optionalTypeArgs
-  TResult maybeMap<TResult extends Object?>({
-    TResult Function(_PollValidationErrorDuplicateOptions value)?
-        duplicateOptions,
-    TResult Function(_PollValidationErrorNameRange value)? nameRange,
-    TResult Function(_PollValidationErrorOptionsRange value)? optionsRange,
-    TResult Function(_PollValidationErrorMaxVotesAllowed value)?
-        maxVotesAllowed,
-    required TResult orElse(),
-  }) {
-    final error = this;
-    final result = switch (error) {
-      _PollValidationErrorDuplicateOptions() => duplicateOptions?.call(error),
-      _PollValidationErrorNameRange() => nameRange?.call(error),
-      _PollValidationErrorOptionsRange() => optionsRange?.call(error),
-      _PollValidationErrorMaxVotesAllowed() => maxVotesAllowed?.call(error),
-    };
-
-    return result ?? orElse();
-  }
-}
-
-// coverage:ignore-end

sample_app/lib/screens/user_feed/polls/create_poll/stream_poll_creator_widget.dart

@@ -70,9 +70,10 @@ class StreamPollCreatorWidget extends StatelessWidget {
                 initialOptions: [
                   for (final option in poll.options)
                     PollOptionItem(
-                        key: option.key,
-                        originalId: option.originalId,
-                        text: option.text),
+                      key: option.key,
+                      originalId: option.originalId,
+                      text: option.text,
+                    ),
                 ],
                 onOptionsChanged: (options) => controller.options = [
                   for (final option in options)

sample_app/lib/screens/user_feed/polls/show_poll/poll_footer.dart

@@ -3,14 +3,7 @@ import 'package:stream_feeds/stream_feeds.dart';
 
 import '../../../../theme/extensions/theme_extensions.dart';
 
-/// {@template pollFooter}
-/// A widget used as the footer of a poll.
-///
-/// Used in [StreamPollInteractor] to display various actions the user can take
-/// on the poll.
-/// {@endtemplate}
 class PollFooter extends StatelessWidget {
-  /// {@macro pollFooter}
   const PollFooter({
     super.key,
     required this.poll,

sample_app/lib/screens/user_feed/polls/show_poll/poll_header.dart

@@ -3,13 +3,7 @@ import 'package:stream_feeds/stream_feeds.dart';
 
 import '../../../../theme/extensions/theme_extensions.dart';
 
-/// {@template pollHeader}
-/// A widget used as the header of a poll.
-///
-/// Used in [StreamPollInteractor] to display the poll question and voting mode.
-/// {@endtemplate}
 class PollHeader extends StatelessWidget {
-  /// {@macro pollHeader}
   const PollHeader({
     super.key,
     required this.poll,

sample_app/lib/screens/user_feed/polls/show_poll/poll_message.dart

@@ -75,7 +75,8 @@ class PollMessage extends StatelessWidget {
         visibleOptionCount: _maxVisibleOptionCount,
         onEndVote: onEndVote,
         onCastVote: (option) => activity.castPollVote(
-            CastPollVoteRequest(vote: VoteData(optionId: option.id))),
+          CastPollVoteRequest(vote: VoteData(optionId: option.id)),
+        ),
         onRemoveVote: (vote) => activity.deletePollVote(voteId: vote.id),
         onAddComment: onAddComment,
         onSuggestOption: onSuggestOption,

sample_app/lib/screens/user_feed/polls/show_poll/poll_options_list_view.dart

@@ -6,13 +6,7 @@ import '../../../../theme/extensions/theme_extensions.dart';
 import '../../../../widgets/user_avatar.dart';
 import 'poll_header.dart';
 
-/// {@template pollOptionsListView}
-/// A widget that displays the list of poll options.
-///
-/// Used in [StreamPollInteractor] to display the poll options to interact with.
-/// {@endtemplate}
 class PollOptionsListView extends StatelessWidget {
-  /// {@macro pollOptionsListView}
   const PollOptionsListView({
     super.key,
     required this.poll,
@@ -215,7 +209,7 @@ class PollOptionItem extends StatelessWidget {
                     ),
                 ],
               ),
-            )
+            ),
           ],
         ),
       ),

sample_app/lib/screens/user_feed/polls/show_poll/stream_poll_comments_dialog.dart

@@ -1,4 +1,3 @@
-import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:stream_feeds/stream_feeds.dart';
 
@@ -32,9 +31,11 @@ Future<T?> showStreamPollCommentsDialog<T extends Object?>({
           );
 
           if (commentText == null) return;
-          activity.castPollVote(
-            CastPollVoteRequest(vote: VoteData(answerText: commentText)),
-          );
+          activity
+              .castPollVote(
+                CastPollVoteRequest(vote: VoteData(answerText: commentText)),
+              )
+              .ignore();
         }
 
         return StreamPollCommentsDialog(
@@ -103,10 +104,12 @@ class StreamPollCommentsDialog extends StatelessWidget {
                     foregroundColor: colorTheme.accentPrimary,
                     disabledForegroundColor: colorTheme.disabled,
                   ),
-                  child: Text(switch (poll.ownAnswers.isEmpty) {
-                    true => 'Add a comment',
-                    false => 'Update your comment',
-                  }),
+                  child: Text(
+                    switch (poll.ownAnswers.isEmpty) {
+                      true => 'Add a comment',
+                      false => 'Update your comment',
+                    },
+                  ),
                 ),
               ),
             ),

sample_app/lib/screens/user_feed/polls/show_poll/stream_poll_options_dialog.dart

@@ -22,7 +22,8 @@ Future<T?> showStreamPollOptionsDialog<T extends Object?>({
       builder: (_) {
         void onCastVote(PollOptionData option) {
           activity.castPollVote(
-              CastPollVoteRequest(vote: VoteData(optionId: option.id)));
+            CastPollVoteRequest(vote: VoteData(optionId: option.id)),
+          );
         }
 
         void onRemoveVote(PollVoteData vote) {