fix statenotifier analysis warnings (#15)

renefloor · web-flow · commit 610b36ecb1fb · 2025-09-03T14:03:28.000+02:00
diff --git a/packages/stream_feeds/lib/src/state/activity.dart b/packages/stream_feeds/lib/src/state/activity.dart
@@ -22,6 +22,7 @@ import 'activity_comment_list.dart';
 import 'activity_state.dart';
 import 'event/activity_event_handler.dart';
 import 'query/activity_comments_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a single activity with its data and state.
 ///
@@ -407,7 +408,7 @@ class Activity with Disposable {
   // region Internal helper methods
 
   Future<Result<ActivityData>> _ensureActivityLoaded() async {
-    final activity = _stateNotifier.state.activity;
+    final activity = _stateNotifier.value.activity;
     if (activity != null) return Result.success(activity);
     return get();
   }
diff --git a/packages/stream_feeds/lib/src/state/activity_comment_list.dart b/packages/stream_feeds/lib/src/state/activity_comment_list.dart
@@ -9,6 +9,7 @@ import '../repository/comments_repository.dart';
 import 'activity_comment_list_state.dart';
 import 'event/activity_comment_list_event_handler.dart';
 import 'query/activity_comments_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of activity comments with a query and state.
 ///
@@ -70,7 +71,7 @@ class ActivityCommentList extends Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more comments available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/activity_list.dart b/packages/stream_feeds/lib/src/state/activity_list.dart
@@ -10,6 +10,7 @@ import '../repository/activities_repository.dart';
 import 'activity_list_state.dart';
 import 'event/activity_list_event_handler.dart';
 import 'query/activities_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of activities with a query and state.
 ///
@@ -69,7 +70,7 @@ class ActivityList with Disposable {
   /// activities to return.
   Future<Result<List<ActivityData>>> queryMoreActivities({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more activities available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/activity_reaction_list.dart b/packages/stream_feeds/lib/src/state/activity_reaction_list.dart
@@ -10,6 +10,7 @@ import '../repository/activities_repository.dart';
 import 'activity_reaction_list_state.dart';
 import 'event/activity_reaction_list_event_handler.dart';
 import 'query/activity_reactions_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of activity reactions with a query and state.
 ///
@@ -68,7 +69,7 @@ class ActivityReactionList extends Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more reactions available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/bookmark_folder_list.dart b/packages/stream_feeds/lib/src/state/bookmark_folder_list.dart
@@ -10,6 +10,7 @@ import '../repository/bookmarks_repository.dart';
 import 'bookmark_folder_list_state.dart';
 import 'event/bookmark_folder_list_event_handler.dart';
 import 'query/bookmark_folders_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of bookmark folders with a query and state.
 ///
@@ -65,7 +66,7 @@ class BookmarkFolderList extends Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more folders available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/bookmark_list.dart b/packages/stream_feeds/lib/src/state/bookmark_list.dart
@@ -10,6 +10,7 @@ import '../repository/bookmarks_repository.dart';
 import 'bookmark_list_state.dart';
 import 'event/bookmark_list_event_handler.dart';
 import 'query/bookmarks_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of bookmarks with a query and state.
 ///
@@ -66,7 +67,7 @@ class BookmarkList with Disposable {
   /// bookmarks to return.
   Future<Result<List<BookmarkData>>> queryMoreBookmarks({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more bookmarks available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/comment_list.dart b/packages/stream_feeds/lib/src/state/comment_list.dart
@@ -9,6 +9,7 @@ import '../repository/comments_repository.dart';
 import 'comment_list_state.dart';
 import 'event/comment_list_event_handler.dart';
 import 'query/comments_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// A list of comments with a query and state.
 ///
@@ -57,7 +58,7 @@ class CommentList extends Disposable {
   /// Returns a [Result] containing additional [CommentData] or an error.
   Future<Result<List<CommentData>>> queryMoreComments({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more comments available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/comment_reaction_list.dart b/packages/stream_feeds/lib/src/state/comment_reaction_list.dart
@@ -10,6 +10,7 @@ import '../repository/comments_repository.dart';
 import 'comment_reaction_list_state.dart';
 import 'event/comment_reaction_list_event_handler.dart';
 import 'query/comment_reactions_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of comment reactions with a query and state.
 ///
@@ -69,7 +70,7 @@ class CommentReactionList with Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more reactions available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/comment_reply_list.dart b/packages/stream_feeds/lib/src/state/comment_reply_list.dart
@@ -9,6 +9,7 @@ import '../repository/comments_repository.dart';
 import 'comment_reply_list_state.dart';
 import 'event/comment_reply_list_event_handler.dart';
 import 'query/comment_replies_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of comment replies with a query and state.
 ///
@@ -68,7 +69,7 @@ class CommentReplyList with Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more replies available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/feed.dart b/packages/stream_feeds/lib/src/state/feed.dart
@@ -25,6 +25,7 @@ import 'feed_state.dart';
 import 'member_list.dart';
 import 'query/feed_query.dart';
 import 'query/members_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// A feed represents a collection of activities and provides methods to interact with them.
 ///
@@ -408,7 +409,7 @@ class Feed with Disposable {
   /// if the operation fails.
   Future<Result<List<ActivityData>>> queryMoreActivities({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.activitiesPagination?.next;
+    final next = _stateNotifier.value.activitiesPagination?.next;
 
     // Early return if no more activities available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/feed_list.dart b/packages/stream_feeds/lib/src/state/feed_list.dart
@@ -10,6 +10,7 @@ import '../repository/feeds_repository.dart';
 import 'event/feed_list_event_handler.dart';
 import 'feed_list_state.dart';
 import 'query/feeds_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of feeds with a query and state.
 ///
@@ -66,7 +67,7 @@ class FeedList with Disposable {
   /// feeds to return.
   Future<Result<List<FeedData>>> queryMoreFeeds({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more feeds available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/follow_list.dart b/packages/stream_feeds/lib/src/state/follow_list.dart
@@ -10,6 +10,7 @@ import '../repository/feeds_repository.dart';
 import 'event/follow_list_event_handler.dart';
 import 'follow_list_state.dart';
 import 'query/follows_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of follows with a query and state.
 ///
@@ -66,7 +67,7 @@ class FollowList with Disposable {
   /// follows to return.
   Future<Result<List<FollowData>>> queryMoreFollows({int? limit}) async {
     // Build the next query using the current pagination state
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more follows available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/member_list.dart b/packages/stream_feeds/lib/src/state/member_list.dart
@@ -10,6 +10,7 @@ import '../repository/feeds_repository.dart';
 import 'event/member_list_event_handler.dart';
 import 'member_list_state.dart';
 import 'query/members_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of feed members with a query and state.
 ///
@@ -66,7 +67,7 @@ class MemberList extends Disposable {
   /// members to return.
   Future<Result<List<FeedMemberData>>> queryMoreMembers({int? limit}) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more members available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/moderation_config_list.dart b/packages/stream_feeds/lib/src/state/moderation_config_list.dart
@@ -9,6 +9,7 @@ import '../models/query_configuration.dart';
 import '../repository/moderation_repository.dart';
 import 'moderation_config_list_state.dart';
 import 'query/moderation_configs_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of moderation configurations with a query and state.
 ///
@@ -57,7 +58,7 @@ class ModerationConfigList extends Disposable {
     int? limit,
   }) async {
     // Build the query with the current pagination state (with next page token)
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more configs available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/poll_list.dart b/packages/stream_feeds/lib/src/state/poll_list.dart
@@ -10,6 +10,7 @@ import '../repository/polls_repository.dart';
 import 'event/poll_list_event_handler.dart';
 import 'poll_list_state.dart';
 import 'query/polls_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of polls with a query and state.
 ///
@@ -66,7 +67,7 @@ class PollList with Disposable {
   /// polls to return.
   Future<Result<List<PollData>>> queryMorePolls({int? limit}) async {
     // Build the next query using the current pagination state
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more polls available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/poll_vote_list.dart b/packages/stream_feeds/lib/src/state/poll_vote_list.dart
@@ -10,6 +10,7 @@ import '../repository/polls_repository.dart';
 import 'event/poll_vote_list_event_handler.dart';
 import 'poll_vote_list_state.dart';
 import 'query/poll_votes_query.dart';
+import 'state_notifier_extentions.dart';
 
 /// Represents a list of poll votes with a query and state.
 ///
@@ -69,7 +70,7 @@ class PollVoteList with Disposable {
   /// votes to return.
   Future<Result<List<PollVoteData>>> queryMorePollVotes({int? limit}) async {
     // Build the next query using the current pagination state
-    final next = _stateNotifier.state.pagination?.next;
+    final next = _stateNotifier.value.pagination?.next;
 
     // Early return if no more votes available
     if (next == null) return const Result.success([]);
diff --git a/packages/stream_feeds/lib/src/state/state_notifier_extentions.dart b/packages/stream_feeds/lib/src/state/state_notifier_extentions.dart
@@ -0,0 +1,9 @@
+// ignore_for_file: invalid_use_of_visible_for_testing_member, invalid_use_of_protected_member
+
+import 'package:meta/meta.dart';
+import 'package:state_notifier/state_notifier.dart';
+
+extension StateNotifierExtensions<T> on StateNotifier<T> {
+  @internal
+  T get value => state;
+}
diff --git a/sample_app/lib/screens/home/widgets/activity_content.dart b/sample_app/lib/screens/home/widgets/activity_content.dart
@@ -68,7 +68,6 @@ class ActivityContent extends StatelessWidget {
 
 class _UserContent extends StatelessWidget {
   const _UserContent({
-    super.key,
     required this.user,
     required this.data,
     required this.text,
@@ -118,7 +117,6 @@ class _UserContent extends StatelessWidget {
 
 class _ActivityBody extends StatelessWidget {
   const _ActivityBody({
-    super.key,
     required this.user,
     required this.text,
     required this.attachments,
@@ -164,7 +162,6 @@ class _ActivityBody extends StatelessWidget {
 
 class _UserActions extends StatelessWidget {
   const _UserActions({
-    super.key,
     required this.user,
     required this.data,
     required this.currentUserId,
diff --git a/sample_app/lib/theme/schemes/app_color_scheme.dart b/sample_app/lib/theme/schemes/app_color_scheme.dart
@@ -1,3 +1,5 @@
+// ignore_for_file: prefer_constructors_over_static_methods
+
 import 'package:flutter/material.dart';
 
 import '../tokens/color_tokens.dart';
diff --git a/sample_app/lib/theme/schemes/app_effects.dart b/sample_app/lib/theme/schemes/app_effects.dart
@@ -1,4 +1,4 @@
-// ignore_for_file: avoid_redundant_argument_values
+// ignore_for_file: avoid_redundant_argument_values, prefer_constructors_over_static_methods
 
 import 'package:flutter/material.dart';
 
diff --git a/sample_app/lib/theme/schemes/app_text_theme.dart b/sample_app/lib/theme/schemes/app_text_theme.dart
@@ -1,3 +1,5 @@
+// ignore_for_file: prefer_constructors_over_static_methods
+
 import 'package:flutter/material.dart';
 
 import '../tokens/color_tokens.dart';
