Skip to content

Commit 9a1493e

Browse files
Privatize watch handlers
1 parent 9f296b8 commit 9a1493e

File tree

6 files changed

+19
-22
lines changed

6 files changed

+19
-22
lines changed

packages/feeds-client/src/feed/event-handlers/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ export * from './feed-member';
44
export * from './bookmark';
55
export * from './activity';
66
export * from './feed';
7-
export * from './notification-feed';
7+
export * from './notification-feed';
8+
export * from './watch';
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { Feed } from '../../feed';
2+
3+
export function handleWatchStarted(this: Feed) {
4+
this.state.partialNext({ watch: true });
5+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { Feed } from '../../feed';
2+
3+
export function handleWatchStopped(this: Feed) {
4+
this.state.partialNext({ watch: false });
5+
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export * from './handle-watch-started';
2+
export * from './handle-watch-stopped';

packages/feeds-client/src/feed/feed.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -316,24 +316,6 @@ export class Feed extends FeedApi {
316316
}
317317
}
318318

319-
/**
320-
* @internal
321-
*/
322-
handleWatchStopped() {
323-
this.state.partialNext({
324-
watch: false,
325-
});
326-
}
327-
328-
/**
329-
* @internal
330-
*/
331-
handleWatchStarted() {
332-
this.state.partialNext({
333-
watch: true,
334-
});
335-
}
336-
337319
/**
338320
* Returns index of the provided comment object.
339321
*/

packages/feeds-client/src/feeds-client.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ import {
4040
handleFollowCreated,
4141
handleFollowDeleted,
4242
handleFollowUpdated,
43+
handleWatchStarted,
44+
handleWatchStopped,
4345
} from './feed';
4446

4547
export type FeedsClientState = {
@@ -107,7 +109,7 @@ export class FeedsClient extends FeedsApi {
107109
}
108110
} else {
109111
for (const activeFeed of Object.values(this.activeFeeds)) {
110-
activeFeed.handleWatchStopped();
112+
handleWatchStopped.bind(activeFeed)();
111113
}
112114
}
113115
break;
@@ -436,7 +438,7 @@ export class FeedsClient extends FeedsApi {
436438
const feed =
437439
this.activeFeeds[`${request.feed_group_id}:${request.feed_id}`];
438440
if (feed) {
439-
feed.handleWatchStopped();
441+
handleWatchStopped.bind(feed)();
440442
}
441443

442444
return response;
@@ -452,7 +454,7 @@ export class FeedsClient extends FeedsApi {
452454
if (this.activeFeeds[fid]) {
453455
const feed = this.activeFeeds[fid];
454456
if (watch && !feed.currentState.watch) {
455-
feed.handleWatchStarted();
457+
handleWatchStarted.bind(feed)();
456458
}
457459
return feed;
458460
} else {

0 commit comments

Comments
 (0)