Skip to content

Commit 207f2b9

Browse files
authored
Merge pull request #153 from GetStream/moderation1
[MOD-0]fix tests, fix token moderation
2 parents 1013992 + 4ae4d24 commit 207f2b9

File tree

4 files changed

+44
-34
lines changed

4 files changed

+44
-34
lines changed

src/main/java/io/getstream/client/ModerationClient.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.getstream.client;
22

3+
import static io.getstream.core.utils.Auth.buildModerationToken;
34
import static io.getstream.core.utils.Auth.buildReactionsToken;
45
import static io.getstream.core.utils.Routes.*;
56
import static io.getstream.core.utils.Serialization.*;
@@ -22,30 +23,30 @@ public class ModerationClient {
2223
}
2324

2425
public CompletableFuture<Response> flagUser(
25-
String flaggedUserId, String reason, Map<String, Object> options) throws StreamException {
26-
return flag("stream:user", flaggedUserId, "", reason, options);
26+
String flaggedUserId,String reportingUser, String reason, Map<String, Object> options) throws StreamException {
27+
return flag("stream:user", flaggedUserId, reportingUser, reason, options);
2728
}
2829

2930
public CompletableFuture<Response> flagActivity(
30-
String entityId, String entityCreatorId, String reason, Map<String, Object> options)
31+
String entityId, String reportingUser, String reason, Map<String, Object> options)
3132
throws StreamException {
32-
return flag("stream:feeds:v2:activity", entityId, entityCreatorId, reason, options);
33+
return flag("stream:feeds:v2:activity", entityId, reportingUser, reason, options);
3334
}
3435

3536
public CompletableFuture<Response> flagReaction(
36-
String entityId, String entityCreatorId, String reason, Map<String, Object> options)
37+
String entityId, String reportingUser, String reason, Map<String, Object> options)
3738
throws StreamException {
38-
return flag("stream:feeds:v2:reaction", entityId, entityCreatorId, reason, options);
39+
return flag("stream:feeds:v2:reaction", entityId, reportingUser, reason, options);
3940
}
4041

4142
private CompletableFuture<Response> flag(
4243
String entityType,
4344
String entityId,
44-
String entityCreatorId,
45+
String reportingUser,
4546
String reason,
4647
Map<String, Object> options)
4748
throws StreamException {
48-
final Token token = buildReactionsToken(secret, Auth.TokenAction.WRITE);
49-
return mod.flag(token, entityType, entityId, entityCreatorId, reason, options);
49+
final Token token = buildModerationToken(secret, Auth.TokenAction.WRITE);
50+
return mod.flag(token, entityType, entityId, reportingUser, reason, options);
5051
}
5152
}

src/main/java/io/getstream/core/Moderation.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,18 @@ public CompletableFuture<Response> flag(
3131
Token token,
3232
String entityType,
3333
String entityId,
34-
String entityCreatorId,
35-
String reason,
34+
String reportingUser,
35+
String Reason,
3636
Map<String, Object> options)
3737
throws StreamException {
3838
try {
3939
final byte[] payload =
4040
toJSON(
4141
new Object() {
42-
public final String UserId = entityCreatorId;
43-
public final String EntityType = entityType;
44-
public final String EntityId = entityId;
45-
public final String Reason = reason;
42+
public final String user_id = reportingUser;
43+
public final String entity_type = entityType;
44+
public final String entity_id = entityId;
45+
public final String reason = Reason;
4646
});
4747

4848
final URL url = buildModerationFlagURL(baseURL);

src/main/java/io/getstream/core/utils/Auth.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public enum TokenResource {
4141
OPEN_GRAPH("url"),
4242
PERSONALIZATION("personalization"),
4343
REACTIONS("reactions"),
44-
USERS("users");
44+
USERS("users"),
45+
MODERATION("moderation");
4546

4647
private final String resource;
4748

@@ -98,6 +99,10 @@ public static Token buildReactionsToken(String secret, TokenAction action) {
9899
return buildBackendToken(secret, TokenResource.REACTIONS, action, "*");
99100
}
100101

102+
public static Token buildModerationToken(String secret, TokenAction action) {
103+
return buildBackendToken(secret, TokenResource.MODERATION, action, "*");
104+
}
105+
101106
public static Token buildAnalyticsToken(String secret, TokenAction action) {
102107
return buildBackendToken(secret, TokenResource.ANALYTICS, action, "*");
103108
}

src/test/java/io/getstream/client/ModerationClientTest.java

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import io.getstream.core.http.Response;
66
import io.getstream.core.models.*;
77
import io.getstream.core.models.Activity;
8+
9+
import java.sql.Time;
810
import java.util.Date;
911
import java.util.UUID;
1012
import org.junit.*;
@@ -28,49 +30,51 @@ public void setUp() throws Exception {
2830
}
2931

3032
@Test
31-
public void testFlagUser() throws Exception {
32-
33+
public void testFlagActivity() throws Exception {
3334
ModerationClient moderationClient = client.moderation();
3435

35-
String userId = UUID.randomUUID().toString();
36-
User user = client.user(userId);
37-
user.getOrCreate().join();
38-
Data result = user.get().join();
36+
Activity activity = Activity.builder().actor("bad-user").verb("test").object("test").moderationTemplate("moderation_template_activity").time(new Date()).foreignID("fid").build();
37+
Activity activityResponse = client.flatFeed("user", "1").addActivity(activity).join();
3938

40-
Response flagResponse = moderationClient.flagUser(userId, "blood", null).join();
39+
String reportingUser="reporting-user";
40+
Activity activity1 = Activity.builder().actor(reportingUser).verb("verb").object("test").moderationTemplate("moderation_template_activity").time(new Date()).foreignID("fid").build();
41+
Activity activityResponse1 = client.flatFeed("user", "1").addActivity(activity1).join();
42+
assertNotNull(activityResponse);
43+
44+
Response flagResponse =
45+
moderationClient.flagActivity(activityResponse.getID(), reportingUser, "blood", null).join();
4146
assertNotNull(flagResponse);
47+
assertEquals(201, flagResponse.getCode());
4248
}
4349

4450
@Test
45-
public void testFlagActivity() throws Exception {
46-
ModerationClient moderationClient = client.moderation();
47-
48-
Activity activity = Activity.builder().actor("test").verb("test").object("test").build();
51+
public void testFlagUser() throws Exception {
4952

50-
Activity activityResponse = client.flatFeed("flat", "1").addActivity(activity).join();
51-
assertNotNull(activityResponse);
53+
ModerationClient moderationClient = client.moderation();
5254

53-
Response flagResponse =
54-
moderationClient.flagActivity(activityResponse.getID(), "vishal", "blood", null).join();
55+
Response flagResponse = moderationClient.flagUser("bad-user", "reporting-user", "blood", null).join();
5556
assertNotNull(flagResponse);
57+
assertEquals(201, flagResponse.getCode());
5658
}
5759

5860
@Test
5961
public void testFlagReaction() throws Exception {
6062
ModerationClient moderationClient = client.moderation();
6163

62-
Activity activity = Activity.builder().actor("test").verb("test").object("test").build();
64+
Activity activity = Activity.builder().actor("bad-user").verb("test").object("test").moderationTemplate("moderation_template_reaction").time(new Date()).foreignID("fid").build();
6365

6466
Activity activityResponse = client.flatFeed("flat", "1").addActivity(activity).join();
6567
assertNotNull(activityResponse);
6668

6769
Reaction reactionResponse =
68-
client.reactions().add("user123", "like", activityResponse.getID()).join();
70+
client.reactions().add("bad-user", "like", activityResponse.getID()).join();
6971
assertNotNull(reactionResponse);
7072

7173
Response flagResponse =
72-
moderationClient.flagReaction(reactionResponse.getId(), "bobby", "blood", null).join();
74+
moderationClient.flagReaction(reactionResponse.getId(), "reporting-user", "blood", null).join();
7375
assertNotNull(flagResponse);
76+
assertEquals(201, flagResponse.getCode());
77+
7478
}
7579

7680
@Test

0 commit comments

Comments
 (0)