Skip to content

Commit 3d38bd5

Browse files
author
Max Klyga
committed
Version 3.1.2
* Add Limit option to reactions client filter method
1 parent b3ce268 commit 3d38bd5

File tree

5 files changed

+42
-15
lines changed

5 files changed

+42
-15
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ Add the following dependency to your pom.xml:
1212
<dependency>
1313
<groupId>io.getstream.client</groupId>
1414
<artifactId>stream-java</artifactId>
15-
<version>3.1.1</version>
15+
<version>3.1.2</version>
1616
</dependency>
1717
```
1818

1919
or in your build.gradle:
2020

2121
```gradle
22-
compile 'io.getstream.client:stream-java:3.1.1'
22+
compile 'io.getstream.client:stream-java:3.1.2'
2323
```
2424

2525
In case you want to download the artifact and put it manually into your project,

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ plugins {
99
}
1010

1111
group 'io.getstream.client'
12-
version = '3.1.1'
12+
version = '3.1.2'
1313

1414
dependencies {
1515
testCompile 'org.junit.jupiter:junit-jupiter-api:5.3.1'

src/main/java/io/getstream/client/ReactionsClient.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.getstream.core.models.FeedID;
99
import io.getstream.core.models.Reaction;
1010
import io.getstream.core.options.Filter;
11+
import io.getstream.core.options.Limit;
1112
import io.getstream.core.utils.Auth.TokenAction;
1213
import io.getstream.core.utils.DefaultOptions;
1314

@@ -33,20 +34,32 @@ public CompletableFuture<Reaction> get(String id) throws StreamException {
3334
}
3435

3536
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id) throws StreamException {
36-
return filter(lookup, id, "");
37+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, "");
38+
}
39+
40+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Limit limit) throws StreamException {
41+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, "");
3742
}
3843

3944
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter) throws StreamException {
40-
return filter(lookup, id, filter, "");
45+
return filter(lookup, id, filter, DefaultOptions.DEFAULT_LIMIT, "");
4146
}
4247

4348
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, String kind) throws StreamException {
44-
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, kind);
49+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, kind);
50+
}
51+
52+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, Limit limit) throws StreamException {
53+
return filter(lookup, id, filter, limit, "");
54+
}
55+
56+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Limit limit, String kind) throws StreamException {
57+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, kind);
4558
}
4659

47-
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, String kind) throws StreamException {
60+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, Limit limit, String kind) throws StreamException {
4861
final Token token = buildReactionsToken(secret, TokenAction.READ);
49-
return reactions.filter(token, lookup, id, filter, kind);
62+
return reactions.filter(token, lookup, id, filter, limit, kind);
5063
}
5164

5265
public CompletableFuture<Reaction> add(String userID, String kind, String activityID, Iterable<FeedID> targetFeeds) throws StreamException {

src/main/java/io/getstream/cloud/CloudReactionsClient.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.getstream.core.models.FeedID;
99
import io.getstream.core.models.Reaction;
1010
import io.getstream.core.options.Filter;
11+
import io.getstream.core.options.Limit;
1112
import io.getstream.core.utils.DefaultOptions;
1213

1314
import java.util.List;
@@ -32,19 +33,31 @@ public CompletableFuture<Reaction> get(String id) throws StreamException {
3233
}
3334

3435
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id) throws StreamException {
35-
return filter(lookup, id, "");
36+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, "");
37+
}
38+
39+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Limit limit) throws StreamException {
40+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, "");
3641
}
3742

3843
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter) throws StreamException {
39-
return filter(lookup, id, filter, "");
44+
return filter(lookup, id, filter, DefaultOptions.DEFAULT_LIMIT, "");
4045
}
4146

4247
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, String kind) throws StreamException {
43-
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, kind);
48+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, DefaultOptions.DEFAULT_LIMIT, kind);
49+
}
50+
51+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, Limit limit) throws StreamException {
52+
return filter(lookup, id, filter, limit, "");
53+
}
54+
55+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Limit limit, String kind) throws StreamException {
56+
return filter(lookup, id, DefaultOptions.DEFAULT_FILTER, limit, kind);
4457
}
4558

46-
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, String kind) throws StreamException {
47-
return reactions.filter(token, lookup, id, filter, kind);
59+
public CompletableFuture<List<Reaction>> filter(LookupKind lookup, String id, Filter filter, Limit limit, String kind) throws StreamException {
60+
return reactions.filter(token, lookup, id, filter, limit, kind);
4861
}
4962

5063
public CompletableFuture<Reaction> add(String kind, String activityID, Iterable<FeedID> targetFeeds) throws StreamException {

src/main/java/io/getstream/core/StreamReactions.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import io.getstream.core.models.Reaction;
1010
import io.getstream.core.options.CustomQueryParameter;
1111
import io.getstream.core.options.Filter;
12+
import io.getstream.core.options.Limit;
1213
import io.getstream.core.options.RequestOption;
1314

1415
import java.io.IOException;
@@ -58,7 +59,7 @@ public CompletableFuture<Reaction> get(Token token, String id) throws StreamExce
5859
}
5960
}
6061

61-
public CompletableFuture<List<Reaction>> filter(Token token, LookupKind lookup, String id, Filter filter, String kind) throws StreamException {
62+
public CompletableFuture<List<Reaction>> filter(Token token, LookupKind lookup, String id, Filter filter, Limit limit, String kind) throws StreamException {
6263
checkNotNull(lookup, "Lookup kind can't be null");
6364
checkNotNull(id, "Reaction ID can't be null");
6465
checkArgument(!id.isEmpty(), "Reaction ID can't be empty");
@@ -69,7 +70,7 @@ public CompletableFuture<List<Reaction>> filter(Token token, LookupKind lookup,
6970
final URL url = buildReactionsURL(baseURL, lookup.getKind() + '/' + id + '/');
7071
RequestOption reactionType = new CustomQueryParameter("kind", kind);
7172
RequestOption withActivityData = new CustomQueryParameter("with_activity_data", Boolean.toString(lookup == LookupKind.ACTIVITY_WITH_DATA));
72-
return httpClient.execute(buildGet(url, key, token, filter, reactionType, withActivityData))
73+
return httpClient.execute(buildGet(url, key, token, filter, limit, reactionType, withActivityData))
7374
.thenApply(response -> {
7475
try {
7576
return deserializeContainer(response, Reaction.class);

0 commit comments

Comments
 (0)