Fix feed ranking option constructor throwing on non-empty strings. Fix activity to targets update operation

Author: Max Klyga

README.md

@@ -19,7 +19,7 @@ Add the following dependency to your pom.xml:
 or in your build.gradle:
 
 ```gradle
-compile 'io.getstream.client:stream-java:3.1.8'
+compile 'io.getstream.client:stream-java:3.1.9'
 ```
 
 In case you want to download the artifact and put it manually into your project,

build.gradle

@@ -10,7 +10,7 @@ plugins {
 }
 
 group 'io.getstream.client'
-version = '3.1.8'
+version = '3.1.9'
 
 dependencies {
     sourceCompatibility = 1.8

src/main/java/io/getstream/core/options/Ranking.java

@@ -10,7 +10,7 @@ public final class Ranking implements RequestOption {
 
     public Ranking(String ranking) {
         checkNotNull(ranking, "Ranking can't be empty");
-        checkArgument(ranking.isEmpty(), "Ranking can't be empty");
+        checkArgument(!ranking.isEmpty(), "Ranking can't be empty");
         this.ranking = ranking;
     }
 

src/main/java/io/getstream/core/utils/Routes.java

@@ -38,7 +38,7 @@ public static URL buildEnrichedFeedURL(URL baseURL, FeedID feed, String path) th
     }
 
     public static URL buildToTargetUpdateURL(URL baseURL, FeedID feed) throws MalformedURLException {
-        return new URL(baseURL, basePath + feedPath(feed) + toTargetUpdatePath);
+        return new URL(baseURL, basePath + feedTargetsPath(feed) + toTargetUpdatePath);
     }
 
     public static URL buildActivitiesURL(URL baseURL) throws MalformedURLException {
@@ -131,6 +131,10 @@ private static String feedPath(FeedID feed) {
         return String.format("feed/%s/%s", feed.getSlug(), feed.getUserID());
     }
 
+    private static String feedTargetsPath(FeedID feed) {
+        return String.format("feed_targets/%s/%s", feed.getSlug(), feed.getUserID());
+    }
+
     private static String enrichedFeedPath(FeedID feed) {
         return String.format("enrich/feed/%s/%s", feed.getSlug(), feed.getUserID());
     }

src/test/java/io/getstream/client/BatchClientTest.java

@@ -31,11 +31,15 @@ public void addToMany() throws Exception {
     @Test
     public void followMany() throws Exception {
         BatchClient client = Client.builder(apiKey, secret).build().batch();
-
+/*
         client.followMany(0, new FollowRelation[]{
                 new FollowRelation("flat:1", "flat:2"),
                 new FollowRelation("aggregated:1", "flat:1")
         }).join();
+*/
+        List<FollowRelation> follows = new ArrayList<>();
+        follows.add(new FollowRelation("flat:1", "flat:2"));
+        client.followMany(follows.toArray(new FollowRelation[0])).join();
     }
 
     @Test

src/test/java/io/getstream/client/FeedTest.java

@@ -140,16 +140,18 @@ public void updateActivityToTargets() throws Exception {
                 .httpClient(new OKHTTPClientAdapter(new OkHttpClient()))
                 .build();
 
-        FlatFeed feed = client.flatFeed("flat", "1");
+        FlatFeed feed = client.flatFeed("flat", "bob");
         Activity activity = Activity.builder()
-                .actor("test")
+                .actor("shmest")
                 .verb("test")
                 .object("test")
-                .foreignID("foreignID")
+                .foreignID("foreignID-1-2-3-4")
                 .time(new Date())
-                .to(Lists.newArrayList(new FeedID("feed:2")))
+                .to(Lists.newArrayList(new FeedID("flat:alice")))
                 .build();
-        feed.updateActivityToTargets(activity, new FeedID[]{new FeedID("feed:3")}, new FeedID[]{new FeedID("feed:2")});
+        Activity result = feed.addActivity(activity).join();
+        feed.updateActivityToTargets(result, new FeedID[]{new FeedID("flat", "claire")}, new FeedID[]{});
+        List<Activity> after = feed.getActivities().join();
     }
 
     @Test