Skip to content

Commit 8fed5ae

Browse files
committed
chore: remove unnecessary client
1 parent 25a178d commit 8fed5ae

File tree

8 files changed

+70
-175
lines changed

8 files changed

+70
-175
lines changed

src/main/java/io/getstream/client/BatchDeleteActivitiesClient.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/main/java/io/getstream/client/Client.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import static io.getstream.core.utils.Auth.*;
66

77
import com.google.common.collect.Iterables;
8-
import io.getstream.core.ExportIDs;
98
import io.getstream.core.Region;
109
import io.getstream.core.Stream;
1110
import io.getstream.core.exceptions.StreamException;
@@ -20,6 +19,8 @@
2019
import java.util.Date;
2120
import java.util.List;
2221
import java.util.Map;
22+
23+
import io.getstream.core.utils.Auth;
2324
import java8.util.concurrent.CompletableFuture;
2425

2526
public final class Client {
@@ -255,14 +256,6 @@ public ModerationClient moderation() {
255256
return new ModerationClient(secret, stream.moderation());
256257
}
257258

258-
public ExportIDsClient exportIDs() {
259-
return new ExportIDsClient(secret, stream.exportIDs());
260-
}
261-
262-
public BatchDeleteActivitiesClient batchDeleteActivities() {
263-
return new BatchDeleteActivitiesClient(secret, stream.batchDeleteActivities());
264-
}
265-
266259
public FileStorageClient files() {
267260
return new FileStorageClient(secret, stream.files());
268261
}
@@ -372,4 +365,14 @@ CompletableFuture<Response> userProfile(String id) throws StreamException {
372365
final Token token = buildUsersToken(secret, TokenAction.READ);
373366
return stream.getUser(token, id, true);
374367
}
368+
369+
public CompletableFuture<Object> deleteActivities(BatchDeleteActivitiesRequest request) throws StreamException {
370+
final Token token = buildDataPrivacyToken(secret, Auth.TokenAction.WRITE);
371+
return stream.deleteActivities(token, request);
372+
}
373+
374+
public CompletableFuture<ExportIDsResponse> exportUserActivities(String userId) throws StreamException {
375+
final Token token = buildDataPrivacyToken(secret, Auth.TokenAction.READ);
376+
return stream.exportUserActivities(token, userId);
377+
}
375378
}

src/main/java/io/getstream/client/ExportIDsClient.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/main/java/io/getstream/core/BatchDeleteActivities.java

Lines changed: 0 additions & 41 deletions
This file was deleted.

src/main/java/io/getstream/core/ExportIDs.java

Lines changed: 0 additions & 53 deletions
This file was deleted.

src/main/java/io/getstream/core/Stream.java

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,6 @@ public Moderation moderation() {
6363
return new Moderation(key, baseURL, httpClient);
6464
}
6565

66-
public ExportIDs exportIDs() {
67-
return new ExportIDs(key, baseURL, httpClient);
68-
}
69-
70-
public BatchDeleteActivities batchDeleteActivities() {
71-
return new BatchDeleteActivities(key, baseURL, httpClient);
72-
}
73-
7466
public StreamFiles files() {
7567
return new StreamFiles(key, baseURL, httpClient);
7668
}
@@ -533,4 +525,41 @@ public CompletableFuture<Response> updateUser(Token token, String userID, Data u
533525
throw new StreamException(e);
534526
}
535527
}
528+
529+
public CompletableFuture<Object> deleteActivities(Token token, BatchDeleteActivitiesRequest request) throws StreamException {
530+
try {
531+
// final URL url = deleteActivitiesURL(baseURL);
532+
final URL url = deleteActivitiesURL(new URL("https://oregon-api.stream-io-api.com"));//$$ need to deploy proxy
533+
534+
final byte[] payload = toJSON(request);
535+
io.getstream.core.http.Request httpRequest = buildPost(url, key, token, payload);
536+
return httpClient.execute(httpRequest).thenApply(response -> null);
537+
} catch (Exception e) {
538+
throw new StreamException(e);
539+
}
540+
}
541+
542+
public CompletableFuture<ExportIDsResponse> exportUserActivities(Token token, String userId) throws StreamException {
543+
if (userId == null || userId.isEmpty()) {
544+
throw new IllegalArgumentException("User ID can't be null or empty");
545+
}
546+
547+
try {
548+
// final URL url = buildExportIDsURL(baseURL, userId);
549+
final URL url = buildExportIDsURL(new URL("https://oregon-api.stream-io-api.com"), userId);//$$ need to deploy proxy
550+
io.getstream.core.http.Request request = buildGet(url, key, token);
551+
return httpClient
552+
.execute(request)
553+
.thenApply(
554+
response -> {
555+
try {
556+
return deserialize(response, ExportIDsResponse.class);
557+
} catch (StreamException | IOException e) {
558+
throw new CompletionException(e);
559+
}
560+
});
561+
} catch (MalformedURLException | URISyntaxException e) {
562+
throw new StreamException(e);
563+
}
564+
}
536565
}

src/test/java/io/getstream/client/BatchDeleteActivitiesTest.java

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,14 @@
33
import static org.junit.Assert.*;
44

55
import com.google.common.collect.Lists;
6-
import io.getstream.core.BatchDeleteActivities;
7-
import io.getstream.core.http.HTTPClient;
86
import io.getstream.core.models.BatchDeleteActivitiesRequest;
97
import io.getstream.core.models.BatchDeleteActivitiesRequest.ActivityToDelete;
108
import io.getstream.core.models.Activity;
11-
import io.getstream.core.models.FeedID;
129
import io.getstream.core.options.Filter;
1310
import io.getstream.core.options.Limit;
1411
import java8.util.concurrent.CompletableFuture;
1512
import org.junit.*;
1613

17-
import java.net.URL;
1814
import java.util.Arrays;
1915
import java.util.List;
2016
import java.util.UUID;
@@ -39,7 +35,6 @@ public void setUp() throws Exception {
3935

4036
@Test
4137
public void testDeleteActivities() throws Exception {
42-
BatchDeleteActivitiesClient batchDeleteClient = client.batchDeleteActivities();
4338
String uuid1 = UUID.randomUUID().toString().replace("-", "");
4439
FlatFeed feed = client.flatFeed("flat", uuid1);
4540

@@ -75,7 +70,7 @@ public void testDeleteActivities() throws Exception {
7570
BatchDeleteActivitiesRequest request = new BatchDeleteActivitiesRequest(activities);
7671

7772
// Delete activities
78-
CompletableFuture<Object> future = batchDeleteClient.deleteActivities(request);
73+
CompletableFuture<Object> future = client.deleteActivities(request);
7974
future.join();
8075

8176
assertTrue(future.isDone());
@@ -90,7 +85,6 @@ public void testDeleteActivities() throws Exception {
9085

9186
@Test
9287
public void testDeleteActivitis() throws Exception {
93-
BatchDeleteActivitiesClient batchDeleteClient = client.batchDeleteActivities();
9488

9589
// Insert some activities
9690
String uuid1 = UUID.randomUUID().toString().replace("-", "");
@@ -124,8 +118,18 @@ public void testDeleteActivitis() throws Exception {
124118
new ActivityToDelete(activity1Res.getID(), Arrays.asList(feed.getID().toString())),
125119
new ActivityToDelete(activity2Res.getID(), Arrays.asList(feedAlice.getID().toString()))
126120
);
121+
122+
activities =feedAlice.getActivities(
123+
new Limit(10), new Filter()).join();
124+
assertEquals(2, activities.size());//0
125+
126+
activities =feedAlice.getActivities(
127+
new Limit(10), new Filter().discardDeletedActivities()).join();
128+
assertEquals(2, activities.size());//1
129+
130+
127131
BatchDeleteActivitiesRequest request = new BatchDeleteActivitiesRequest(activitiesToDelete);
128-
CompletableFuture<Object> future = batchDeleteClient.deleteActivities(request);
132+
CompletableFuture<Object> future = client.deleteActivities(request);
129133
future.join();
130134

131135

@@ -145,8 +149,14 @@ public void testDeleteActivitis() throws Exception {
145149
new Limit(10), new Filter().discardDeletedActivities()).join();
146150
assertEquals(0, activities.size());
147151

152+
activities =feedAlice.getActivities(
153+
new Limit(10), new Filter()).join();
154+
assertEquals(2, activities.size());//0
155+
148156
activities =feedAlice.getActivities(
149157
new Limit(10), new Filter().discardDeletedActivities()).join();
150-
assertEquals(1, activities.size());
158+
assertEquals(0, activities.size());//1
159+
160+
151161
}
152162
}

src/test/java/io/getstream/client/ExportIDsTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public void setUp() throws Exception {
2929

3030
@Test
3131
public void testExportUserActivities() throws Exception {
32-
ExportIDsClient exportIDsClient = client.exportIDs();
3332

3433
String userId = "test-user";
3534

@@ -48,10 +47,10 @@ public void testExportUserActivities() throws Exception {
4847
.object("object2")
4948
.time(new Date())
5049
.build();
51-
Activity activity2Res =client.flatFeed("user", userId).addActivity(activity2).join();
50+
Activity activity2Res = client.flatFeed("user", userId).addActivity(activity2).join();
5251

5352
// Export user activities
54-
ExportIDsResponse exportResult = exportIDsClient.exportUserActivities(userId).join();
53+
ExportIDsResponse exportResult = client.exportUserActivities(userId).join();
5554
ExportIDsResult exports = exportResult.getExport();
5655

5756
// Test the output

0 commit comments

Comments
 (0)