Skip to content

Commit b3ac279

Browse files
authored
Merge pull request #34 from GetStream/feature/session
Added session in FeedFilter
2 parents d095bf7 + f598b4a commit b3ac279

File tree

4 files changed

+25
-2
lines changed

4 files changed

+25
-2
lines changed

stream-core/src/main/java/io/getstream/client/model/filters/FeedFilter.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public class FeedFilter {
1515
public final static String PARAM_ID_LOWER_THAN_EQUALS = "id_lte";
1616
public final static String PARAM_FEED_IDS = "filter";
1717
public final static String PARAM_RANKING = "ranking";
18+
public final static String PARAM_SESSION = "session";
1819

1920
private static final int DEFAULT_LIMIT = 25;
2021

@@ -25,6 +26,7 @@ public class FeedFilter {
2526
private String idLowerThanEquals = null;
2627
private String idLowerThan = null;
2728
private String ranking = null;
29+
private String session = null;
2830
private List<String> feedIds = null;
2931

3032
protected FeedFilter() {
@@ -62,6 +64,10 @@ public String getRanking() {
6264
return ranking;
6365
}
6466

67+
public String getSession() {
68+
return session;
69+
}
70+
6571
/**
6672
* Builder to build up a {@link FeedFilter}.
6773
*/
@@ -116,6 +122,11 @@ public Builder withRanking(String ranking) {
116122
return this;
117123
}
118124

125+
public Builder withSession(String session) {
126+
feedFilter.session = session;
127+
return this;
128+
}
129+
119130
public Builder withFeedIds(List<String> feeds) {
120131
feedFilter.feedIds = feeds;
121132
return this;

stream-core/src/test/java/io/getstream/client/model/FeedFilterTest.java renamed to stream-core/src/test/java/io/getstream/client/model/filters/FeedFilterTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package io.getstream.client.model.filters;
22

3+
import org.junit.Test;
4+
35
import java.util.Arrays;
46
import java.util.List;
57

6-
import org.junit.Test;
7-
88
import static org.hamcrest.CoreMatchers.is;
99
import static org.hamcrest.CoreMatchers.nullValue;
1010
import static org.hamcrest.MatcherAssert.assertThat;
@@ -20,6 +20,7 @@ public void shouldBuildFeedFilter() {
2020
String id_lt = "ghi";
2121
String id_lte = "jkl";
2222
String ranking = "ranking-method";
23+
String session = "session";
2324
List<String> feedIds = Arrays.asList("user:123", "user:456");
2425

2526
FeedFilter filter = new FeedFilter.Builder()
@@ -31,6 +32,7 @@ public void shouldBuildFeedFilter() {
3132
.withIdLowerThanEquals(id_lte)
3233
.withRanking(ranking)
3334
.withFeedIds(feedIds)
35+
.withSession(session)
3436
.build();
3537

3638
assertThat(filter.getLimit(), is(limit));
@@ -41,6 +43,7 @@ public void shouldBuildFeedFilter() {
4143
assertThat(filter.getIdLowerThanEquals(), is(id_lte));
4244
assertThat(filter.getRanking(), is(ranking));
4345
assertThat(filter.getFeedIds(), is(feedIds));
46+
assertThat(filter.getSession(), is(session));
4447
}
4548

4649
@Test

stream-repo-apache/src/main/java/io/getstream/client/apache/repo/utils/FeedFilterUtils.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ public static UriBuilder apply(final UriBuilder uriBuilder, final FeedFilter fil
4444
if (null != filter.getRanking()) {
4545
uriBuilder.queryParam(FeedFilter.PARAM_RANKING, filter.getRanking());
4646
}
47+
if (null != filter.getSession()) {
48+
uriBuilder.queryParam(FeedFilter.PARAM_SESSION, filter.getSession());
49+
}
4750
return uriBuilder;
4851
}
4952
}

stream-repo-okhttp/src/main/java/io/getstream/client/okhttp/repo/utils/FeedFilterUtils.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ public static UriBuilder apply(final UriBuilder uriBuilder, final FeedFilter fil
4141
if (null != filter.getFeedIds()) {
4242
uriBuilder.queryParam(FeedFilter.PARAM_FEED_IDS, Joiner.on(",").join(filter.getFeedIds()));
4343
}
44+
if (null != filter.getRanking()) {
45+
uriBuilder.queryParam(FeedFilter.PARAM_RANKING, filter.getRanking());
46+
}
47+
if (null != filter.getSession()) {
48+
uriBuilder.queryParam(FeedFilter.PARAM_SESSION, filter.getSession());
49+
}
4450
return uriBuilder;
4551
}
4652
}

0 commit comments

Comments
 (0)