Cleanup (#115)

* chore: fix compiler warnings

* chore: remove support for .net 5 (end of life)

* Add support for .net 7.0

* chore: removed support for .net 7 (CI issues to fix)

Author: xernobyl

src/Utils/StreamJsonConverter.cs

@@ -13,12 +13,16 @@ public static class StreamJsonConverter
                 NamingStrategy = new SnakeCaseNamingStrategy(), // this handles ForeignId => foreign_id etc. conversion for us
             },
             NullValueHandling = NullValueHandling.Ignore,
-            DateTimeZoneHandling = DateTimeZoneHandling.Utc // always convert time to UTC
+            DateTimeZoneHandling = DateTimeZoneHandling.Utc, // always convert time to UTC
         };
 
         public static JsonSerializer Serializer { get; } = JsonSerializer.Create(Settings);
-        public static string SerializeObject(object obj) => JsonConvert.SerializeObject(obj, Settings);
-        public static T DeserializeObject<T>(string json) => JsonConvert.DeserializeObject<T>(json, Settings);
+
+        public static string SerializeObject(object obj) =>
+            JsonConvert.SerializeObject(obj, Settings);
+
+        public static T DeserializeObject<T>(string json) =>
+            JsonConvert.DeserializeObject<T>(json, Settings);
     }
 
     public static class StreamJsonConverterUTC
@@ -31,11 +35,15 @@ public static class StreamJsonConverterUTC
                 NamingStrategy = new SnakeCaseNamingStrategy(), // this handles ForeignId => foreign_id etc. conversion for us
             },
             NullValueHandling = NullValueHandling.Ignore,
-            DateTimeZoneHandling = DateTimeZoneHandling.Utc  // always convert time to UTC
+            DateTimeZoneHandling = DateTimeZoneHandling.Utc, // always convert time to UTC
         };
 
         public static JsonSerializer Serializer { get; } = JsonSerializer.Create(Settings);
-        public static string SerializeObject(object obj) => JsonConvert.SerializeObject(obj, Settings);
-        public static T DeserializeObject<T>(string json) => JsonConvert.DeserializeObject<T>(json, Settings);
+
+        public static string SerializeObject(object obj) =>
+            JsonConvert.SerializeObject(obj, Settings);
+
+        public static T DeserializeObject<T>(string json) =>
+            JsonConvert.DeserializeObject<T>(json, Settings);
     }
 }

src/stream-net.csproj

@@ -3,7 +3,7 @@
     <DefineConstants>TRACE;DEBUG;NETCORE</DefineConstants>
   </PropertyGroup>
   <PropertyGroup>
-    <TargetFrameworks>net45;net46;net47;net48;netstandard1.6;netstandard2.0;netstandard2.1;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard1.6;netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>
   </PropertyGroup>
   <PropertyGroup>
     <PackageId>stream-net</PackageId>

tests/ReactionTests.cs

@@ -112,8 +112,7 @@ public async Task TestReactionPagination()
                 Guid.NewGuid().ToString(),
                 "upvote",
                 "mary",
-                data
-            );
+                data);
 
             // activity id
             var filter = ReactionFiltering.Default;
@@ -140,15 +139,13 @@ public async Task TestReactionPagination()
             // with limit
             reactionsByActivity = await Client.Reactions.FilterAsync(
                 filter.WithLimit(1),
-                pagination
-            );
+                pagination);
             Assert.AreEqual(1, reactionsByActivity.Count());
 
             // with data
             var reactionsByActivityWithData = await Client.Reactions.FilterWithActivityAsync(
                 filter.WithLimit(1),
-                pagination
-            );
+                pagination);
             Assert.AreEqual(1, reactionsByActivity.Count());
             Assert.AreEqual(data, reactionsByActivity.FirstOrDefault().Data);
 

tests/UtilsTests.cs

@@ -53,7 +53,7 @@ public async Task TestActivityIdSameAsBackend()
         }
 
         [Test]
-        public async Task TestStreamJsonConverterUTC()
+        public void TestStreamJsonConverterUTC()
         {
             var date0 = new DateTime(2023, 5, 10, 12, 30, 15, DateTimeKind.Utc);
             var date0AsJsonNewtonsoft = Newtonsoft.Json.JsonConvert.SerializeObject(date0);