Skip to content

Commit ebb0839

Browse files
authored
Drop session from token (#41)
1 parent a5048c1 commit ebb0839

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

src/stream-net-tests/ClientTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ public void TestActivityPartialUpdateArgumentValidation()
109109
}
110110

111111
[Test]
112-
public void TestSessionToken()
112+
public void TestToken()
113113
{
114-
var tokenString = _client.CreateUserSessionToken("user");
114+
var tokenString = _client.CreateUserToken("user");
115115
var tok = new JWTSecurityToken(tokenString);
116116
object actualUserID;
117117
Assert.True(tok.Payload.TryGetValue("user_id", out actualUserID));
@@ -122,7 +122,7 @@ public void TestSessionToken()
122122
{"client","dotnet"},
123123
{"testing", true}
124124
};
125-
tokenString = _client.CreateUserSessionToken("user2", extra);
125+
tokenString = _client.CreateUserToken("user2", extra);
126126
tok = new JWTSecurityToken(tokenString);
127127

128128
object data;

src/stream-net/IStreamClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ public interface IStreamClient
1414
Task ActivityPartialUpdate(string id = null, ForeignIDTime foreignIDTime = null, GenericData set = null, IEnumerable<string> unset = null);
1515
IStreamFeed Feed(string feedSlug, string userId);
1616

17-
string CreateUserSessionToken(string userId, IDictionary<string, object> extraData = null);
17+
string CreateUserToken(string userId, IDictionary<string, object> extraData = null);
1818
}
1919
}

src/stream-net/StreamClient.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class StreamClient : IStreamClient
2929

3030
readonly RestClient _client;
3131
readonly StreamClientOptions _options;
32-
readonly IStreamClientToken _streamClientToken;
32+
readonly IToken _streamClientToken;
3333
readonly string _apiKey;
3434

3535
public StreamClient(string apiKey, string apiSecretOrToken, StreamClientOptions options = null)
@@ -40,12 +40,12 @@ public StreamClient(string apiKey, string apiSecretOrToken, StreamClientOptions
4040
throw new ArgumentNullException("apiSecret", "Must have an apiSecret or user session token");
4141

4242
_apiKey = apiKey;
43-
_streamClientToken = StreamClientToken.For(apiSecretOrToken);
43+
_streamClientToken = TokenFactory.For(apiSecretOrToken);
4444
_options = options ?? StreamClientOptions.Default;
4545
_client = new RestClient(GetBaseUrl(_options.Location), TimeSpan.FromMilliseconds(_options.Timeout));
4646
}
4747

48-
private StreamClient(string apiKey, IStreamClientToken streamClientToken, RestClient client, StreamClientOptions options = null)
48+
private StreamClient(string apiKey, IToken streamClientToken, RestClient client, StreamClientOptions options = null)
4949
{
5050
if (string.IsNullOrWhiteSpace(apiKey))
5151
throw new ArgumentNullException("apiKey", "Must have an apiKey");
@@ -93,9 +93,9 @@ public async Task ActivityPartialUpdate(string id = null, ForeignIDTime foreignI
9393
await this.Batch.ActivitiesPartialUpdate(new ActivityPartialUpdateRequestObject[] { update });
9494
}
9595

96-
public string CreateUserSessionToken(string userId, IDictionary<string, object> extraData = null)
96+
public string CreateUserToken(string userId, IDictionary<string, object> extraData = null)
9797
{
98-
return _streamClientToken.CreateUserSessionToken(userId, extraData);
98+
return _streamClientToken.CreateUserToken(userId, extraData);
9999
}
100100

101101
/// <summary>
@@ -174,7 +174,7 @@ private RestRequest BuildRestRequest(string fullPath, HttpMethod method, string
174174
var request = new RestRequest(fullPath, method);
175175
request.AddHeader("Authorization", JWToken("*", userID));
176176
request.AddHeader("Stream-Auth-Type", "jwt");
177-
request.AddHeader("X-Stream-Client", "stream-net-"+Version);
177+
request.AddHeader("X-Stream-Client", "stream-net-" + Version);
178178
request.AddQueryParameter("api_key", _apiKey);
179179
return request;
180180
}

src/stream-net/StreamClientToken.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,35 @@
66

77
namespace Stream
88
{
9-
public interface IStreamClientToken
9+
public interface IToken
1010
{
11-
string CreateUserSessionToken(string userId, IDictionary<string, object> extraData = null);
11+
string CreateUserToken(string userId, IDictionary<string, object> extraData = null);
1212

1313
string For(object payload);
1414
}
1515

16-
public static class StreamClientToken
16+
public static class TokenFactory
1717
{
18-
public static IStreamClientToken For(string apiSecretOrToken)
18+
public static IToken For(string apiSecretOrToken)
1919
{
2020
return apiSecretOrToken.Contains(".")
21-
? (IStreamClientToken) new StreamApiSessionToken(apiSecretOrToken)
22-
: (IStreamClientToken) new StreamApiSecret(apiSecretOrToken);
21+
? (IToken)new Token(apiSecretOrToken)
22+
: (IToken)new Secret(apiSecretOrToken);
2323
}
2424
}
2525

26-
public class StreamApiSessionToken : IStreamClientToken
26+
public class Token : IToken
2727
{
2828
private readonly string _sessionToken;
2929

30-
public StreamApiSessionToken(string sessionToken)
30+
public Token(string sessionToken)
3131
{
3232
_sessionToken = sessionToken;
3333
}
3434

35-
public string CreateUserSessionToken(string userId, IDictionary<string, object> extraData = null)
35+
public string CreateUserToken(string userId, IDictionary<string, object> extraData = null)
3636
{
37-
throw new InvalidOperationException("Clients connecting using a user session token cannot create additional user session tokens");
37+
throw new InvalidOperationException("Clients connecting using a user token cannot create additional user tokens");
3838
}
3939

4040
public string For(object payload)
@@ -43,11 +43,11 @@ public string For(object payload)
4343
}
4444
}
4545

46-
public class StreamApiSecret : IStreamClientToken
46+
public class Secret : IToken
4747
{
4848
private readonly string _apiSecret;
4949

50-
public StreamApiSecret(string apiSecret)
50+
public Secret(string apiSecret)
5151
{
5252
_apiSecret = apiSecret;
5353
}
@@ -60,7 +60,7 @@ private static string Base64UrlEncode(byte[] input)
6060
.Trim('=');
6161
}
6262

63-
public string CreateUserSessionToken(string userId, IDictionary<string, object> extraData = null)
63+
public string CreateUserToken(string userId, IDictionary<string, object> extraData = null)
6464
{
6565
var payload = new Dictionary<string, object>
6666
{

0 commit comments

Comments
 (0)