Improve test coverage

Author: matthisk

package.json

@@ -38,9 +38,11 @@
     "bson": "~0.5.4",
     "coveralls": "~2.11.14",
     "eslint": "~3.7.1",
+    "expect.js": "~0.3.1",
     "glob": "~7.1.1",
     "jscs": "~3.0.7",
     "mocha": "~3.1.0",
+    "rewire": "~2.5.2",
     "should": "~4.0.0"
   },
   "peerDependencies": {

src/index.js

@@ -1,20 +1,22 @@
 var FeedManager = require('./FeedManager.js');
 var config = require('./config.js');
 var settings = config();
+var extend = require('util')._extend;
 var waterline = require('./backends/waterline');
 var mongoose = require('./backends/mongoose.js');
 
 module.exports.FeedManager = new FeedManager(settings);
 module.exports.feedManagerFactory = function (options) {
+    var withSettings = extend({}, settings);
     options = options || {};
 
-    for (var key in settings) {
-        if (settings.hasOwnProperty(key) && options.hasOwnProperty(key)) {
-            settings[key] = options[key];
+    for (var key in withSettings) {
+        if (withSettings.hasOwnProperty(key) && options.hasOwnProperty(key)) {
+            withSettings[key] = options[key];
         }
     }
 
-    return new FeedManager(settings);
+    return new FeedManager(withSettings);
 };
 
 module.exports.mongoose = mongoose;

test/index_test.js

@@ -1,5 +1,11 @@
-var should = require('should');
-var BaseBackend = require('../src/backends/base.js');
+var should = require('should')
+  , expect = require('expect.js')
+  , fs = require('fs')
+  , path = require('path')
+  , Config = require('../src/config')
+  , BaseBackend = require('../src/backends/base.js')
+  , FeedManager = require('../src/FeedManager')
+  , main = require('../src/index');
 
 describe('StreamBackend', function () {
 
@@ -22,3 +28,70 @@ describe('StreamBackend', function () {
     });
 
 });
+
+describe('feedManagerFactory', function() {
+
+    it('should return a FeedManager instance', function() {
+        var fm = main.feedManagerFactory({});
+
+        expect(fm).to.be.a(FeedManager);
+    });
+
+    it('should ignore unkown settings', function() {
+        var fm = main.feedManagerFactory({
+            unknown: 'abcdefg'
+        });
+
+        expect(fm).to.be.a(FeedManager);
+        expect(fm.settings.unknown).to.be.undefined;
+    });
+
+    it('should override known settings', function() {
+        var fm = main.feedManagerFactory({
+            apiKey: 'abcdefg'
+        });
+
+        expect(fm).to.be.a(FeedManager);
+        expect(fm.settings.apiKey).to.be('abcdefg');
+    });
+
+});
+
+describe('Feed manager', function() {
+
+    it('default config', function() {
+        var settings = main.FeedManager.settings;
+
+        var expected = require('../getstream.js').config;
+        expect(settings).to.eql(expected);
+    });
+
+    describe('haha', function() {
+        var configDir = path.join(__dirname, './tmp');
+        var configFile = path.join(configDir, 'getstream.js');
+
+        before(function() {
+            process.env.STREAM_NODE_CONFIG_DIR = configDir;
+
+            fs.mkdirSync(configDir);
+            fs.writeFileSync(configFile, 'exports.config = { apiKey: 12345 };');
+        });
+
+        after(function() { 
+            fs.unlink(configFile);
+            fs.rmdirSync(configDir);
+            delete process.env.STREAM_NODE_CONFIG_DIR;            
+        });
+
+        it('env var config dir', function() {
+            var settings = Config();
+
+            expect(settings.apiKey).to.be(12345);
+        });
+    });
+
+
+    it('override config', function() {
+
+    });
+});