refactor: rename video_buffered to drain_video_frames, default False

Author: aliev

getstream/video/rtc/connection_manager.py

@@ -58,7 +58,7 @@ def __init__(
         create: bool = True,
         subscription_config: Optional[SubscriptionConfig] = None,
         max_join_retries: int = 3,
-        video_buffered: bool = True,
+        drain_video_frames: bool = False,
         **kwargs: Any,
     ):
         super().__init__()
@@ -92,7 +92,7 @@ def __init__(
             self, subscription_config
         )
         self._peer_manager: PeerConnectionManager = PeerConnectionManager(
-            self, video_buffered=video_buffered
+            self, drain_video_frames=drain_video_frames
         )
 
         self.recording_manager = self._recording_manager

getstream/video/rtc/pc.py

@@ -131,14 +131,14 @@ def __init__(
         self,
         connection,
         configuration: aiortc.RTCConfiguration,
-        video_buffered: bool = True,
+        drain_video_frames: bool = False,
     ) -> None:
         logger.info(
             f"creating subscriber peer connection with configuration: {configuration}"
         )
         super().__init__(configuration)
         self.connection = connection
-        self._video_buffered = video_buffered
+        self._drain_video_frames = drain_video_frames
 
         self.track_map = {}  # track_id -> (MediaRelay, original_track)
         self.video_frame_trackers = {}  # track_id -> VideoFrameTracker
@@ -184,7 +184,7 @@ def _emit_pcm(pcm: PcmData):
 
             # Drain unconsumed video frames to prevent unbounded queue growth
             # in RTCRtpReceiver (aiortc issue #554)
-            if track.kind == "video" and not self._video_buffered:
+            if track.kind == "video" and self._drain_video_frames:
                 blackhole = MediaBlackhole()
                 blackhole.addTrack(proxy)
                 asyncio.create_task(blackhole.start())

getstream/video/rtc/peer_connection.py

@@ -28,9 +28,9 @@
 class PeerConnectionManager:
     """Manages WebRTC peer connections for publishing and subscribing."""
 
-    def __init__(self, connection_manager, video_buffered: bool = True):
+    def __init__(self, connection_manager, drain_video_frames: bool = False):
         self.connection_manager = connection_manager
-        self._video_buffered = video_buffered
+        self._drain_video_frames = drain_video_frames
         self.publisher_pc: Optional[PublisherPeerConnection] = None
         self.subscriber_pc: Optional[SubscriberPeerConnection] = None
         self.publisher_negotiation_lock = asyncio.Lock()
@@ -48,7 +48,7 @@ async def setup_subscriber(self):
             self.subscriber_pc = SubscriberPeerConnection(
                 connection=self.connection_manager,
                 configuration=self._build_rtc_configuration(),
-                video_buffered=self._video_buffered,
+                drain_video_frames=self._drain_video_frames,
             )
 
             # Trace create event