Skip to content

Commit 7648c04

Browse files
authored
Merge pull request #170 from GetStream/audio-util
Audio utils
2 parents f722133 + 48363c8 commit 7648c04

File tree

6 files changed

+1957
-89
lines changed

6 files changed

+1957
-89
lines changed

getstream/video/rtc/connection_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ async def _on_subscriber_offer(self, event: events_pb2.SubscriberOffer):
176176
# Set the local description. aiortc will manage the SDP content.
177177
with telemetry.start_as_current_span(
178178
"rtc.on_subscriber_offer.set_local_description"
179-
):
179+
) as span:
180180
await self.subscriber_pc.setLocalDescription(answer)
181181

182182
logger.debug(

getstream/video/rtc/pc.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import aiortc
66
from aiortc.contrib.media import MediaRelay
77

8+
from getstream.common import telemetry
89
from getstream.video.rtc.track_util import AudioTrackHandler
910
from pyee.asyncio import AsyncIOEventEmitter
1011
from aiortc.rtcrtpsender import RTCRtpSender
@@ -84,10 +85,12 @@ async def handle_answer(self, response):
8485
type="answer", sdp=response.sdp
8586
)
8687

87-
await self.setRemoteDescription(remote_description)
88-
logger.debug(
89-
f"Publisher remote description set successfully. {self.localDescription}"
90-
)
88+
with telemetry.start_as_current_span("publisher.pc.handle_answer") as span:
89+
span.set_attribute("remoteDescription", remote_description.sdp)
90+
await self.setRemoteDescription(remote_description)
91+
logger.debug(
92+
f"Publisher remote description set successfully. {self.localDescription}"
93+
)
9194

9295
async def wait_for_connected(self, timeout: float = 15.0):
9396
# If already connected, return immediately

getstream/video/rtc/peer_connection.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,16 @@ async def add_tracks(
103103
self.publisher_pc.addTrack(relayed_video)
104104
logger.info(f"Added relayed video track {relayed_video.id}")
105105

106-
with telemetry.start_as_current_span("rtc.publisher_pc.create_offer"):
106+
with telemetry.start_as_current_span(
107+
"rtc.publisher_pc.create_offer"
108+
) as span:
107109
offer = await self.publisher_pc.createOffer()
110+
span.set_attribute("sdp", offer.sdp)
108111

109112
with telemetry.start_as_current_span(
110113
"rtc.publisher_pc.set_local_description"
111-
):
114+
) as span:
115+
span.set_attribute("sdp", offer.sdp)
112116
await self.publisher_pc.setLocalDescription(offer)
113117

114118
try:

0 commit comments

Comments
 (0)