yeild on None tracer

Author: vagruchi

getstream/common/telemetry.py

@@ -173,7 +173,8 @@ def span_request(
         yield _NullSpan()
         return
     tracer = _get_tracer()
-    if tracer is None:  # pragma: no cover
+    if tracer is None:
+        yield _NullSpan()  # pragma: no cover
         return
     with tracer.start_as_current_span(name, kind=SpanKind.CLIENT) as span:  # type: ignore[arg-type]
         base_attrs: Dict[str, Any] = dict(attributes or {})

tests/test_client.py

@@ -39,10 +39,22 @@ def test_incorrect_client_throws_exception(monkeypatch):
     with pytest.raises(ValueError):
         Stream(api_key="xxx", api_secret="xxx", base_url="ftp://example.com")
 
+
 def test_client_does_not_raise_exception_without_tracer(client: Stream, monkeypatch):
     # Monkey patch _get_tracer to always return None
     from getstream.common import telemetry
-    monkeypatch.setattr(telemetry, '_get_tracer', lambda: None)
+
+    monkeypatch.setattr(telemetry, "_get_tracer", lambda: None)
+
+    response = client.get_app()
+    assert response.data is not None
+
+
+def test_client_works_with_no_otel(client: Stream, monkeypatch):
+    # Monkey patch _get_tracer to always return None
+    from getstream.common import telemetry
+
+    monkeypatch.setattr(telemetry, "_HAS_OTEL", False)
 
     response = client.get_app()
     assert response.data is not None