feat: validate max_join_retries and extract patched_dependencies helper

Raise ValueError if max_join_retries < 0 instead of silently clamping.
Extract shared patch context manager to reduce duplication in tests.

Author: aliev

getstream/video/rtc/connection_manager.py

@@ -71,6 +71,8 @@ def __init__(
         self.session_id: str = str(uuid.uuid4())
         self.join_response: Optional[JoinCallResponse] = None
         self.local_sfu: bool = False  # Local SFU flag for development
+        if max_join_retries < 0:
+            raise ValueError("max_join_retries must be >= 0")
         self._max_join_retries: int = max_join_retries
 
         # Private attributes

tests/test_connection_manager.py

@@ -1,3 +1,5 @@
+import contextlib
+
 import pytest
 from unittest.mock import AsyncMock, patch, MagicMock
 
@@ -6,13 +8,9 @@
 from getstream.video.rtc.pb.stream.video.sfu.models import models_pb2
 
 
-@pytest.fixture
-def connection_manager(request):
-    """Create a ConnectionManager with mocked heavy dependencies.
-
-    Accepts max_join_retries via indirect parametrize, defaults to 3.
-    """
-    max_join_retries = getattr(request, "param", 3)
+@contextlib.contextmanager
+def patched_dependencies():
+    """Patch heavy ConnectionManager dependencies for unit testing."""
     with (
         patch("getstream.video.rtc.connection_manager.PeerConnectionManager"),
         patch("getstream.video.rtc.connection_manager.NetworkMonitor"),
@@ -26,6 +24,17 @@ def connection_manager(request):
             new_callable=AsyncMock,
         ),
     ):
+        yield
+
+
+@pytest.fixture
+def connection_manager(request):
+    """Create a ConnectionManager with mocked heavy dependencies.
+
+    Accepts max_join_retries via indirect parametrize, defaults to 3.
+    """
+    max_join_retries = getattr(request, "param", 3)
+    with patched_dependencies():
         mock_call = MagicMock()
         mock_call.call_type = "default"
         mock_call.id = "test_call"
@@ -153,3 +162,11 @@ async def mock_connect_internal(migrating_from_list=None, **kwargs):
         assert call_count == 2
         first_ws_client.close.assert_called_once()
         assert cm._ws_client is None
+
+    def test_rejects_negative_max_join_retries(self):
+        """max_join_retries must be >= 0."""
+        with (
+            patched_dependencies(),
+            pytest.raises(ValueError, match="max_join_retries must be >= 0"),
+        ):
+            ConnectionManager(call=MagicMock(), user_id="user1", max_join_retries=-1)