Skip to content

Commit c0452a3

Browse files
committed
fix: make file parameter required in upload methods
Address code review feedback: change `file` from `Optional[str]` to `str` in all upload method overrides to prevent runtime errors when None is passed to the multipart upload helper. Made-with: Cursor
1 parent 3b33759 commit c0452a3

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

getstream/chat/async_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ async def upload_channel_file(
3232
self,
3333
type: str,
3434
id: str,
35-
file: Optional[str] = None,
35+
file: str,
3636
user: Optional[OnlyUserID] = None,
3737
) -> StreamResponse[UploadChannelFileResponse]:
3838
form_fields = []
@@ -51,7 +51,7 @@ async def upload_channel_image(
5151
self,
5252
type: str,
5353
id: str,
54-
file: Optional[str] = None,
54+
file: str,
5555
upload_sizes: Optional[List[ImageSize]] = None,
5656
user: Optional[OnlyUserID] = None,
5757
) -> StreamResponse[UploadChannelResponse]:

getstream/chat/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def upload_channel_file(
3232
self,
3333
type: str,
3434
id: str,
35-
file: Optional[str] = None,
35+
file: str,
3636
user: Optional[OnlyUserID] = None,
3737
) -> StreamResponse[UploadChannelFileResponse]:
3838
form_fields = []
@@ -51,7 +51,7 @@ def upload_channel_image(
5151
self,
5252
type: str,
5353
id: str,
54-
file: Optional[str] = None,
54+
file: str,
5555
upload_sizes: Optional[List[ImageSize]] = None,
5656
user: Optional[OnlyUserID] = None,
5757
) -> StreamResponse[UploadChannelResponse]:

getstream/common/async_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def __init__(self, api_key: str, base_url, token, timeout, user_agent=None):
2424

2525
@telemetry.operation_name("getstream.api.common.upload_file")
2626
async def upload_file(
27-
self, file: Optional[str] = None, user: Optional[OnlyUserID] = None
27+
self, file: str, user: Optional[OnlyUserID] = None
2828
) -> StreamResponse[FileUploadResponse]:
2929
form_fields = []
3030
if user is not None:
@@ -39,7 +39,7 @@ async def upload_file(
3939
@telemetry.operation_name("getstream.api.common.upload_image")
4040
async def upload_image(
4141
self,
42-
file: Optional[str] = None,
42+
file: str,
4343
upload_sizes: Optional[List[ImageSize]] = None,
4444
user: Optional[OnlyUserID] = None,
4545
) -> StreamResponse[ImageUploadResponse]:

getstream/common/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def __init__(self, api_key: str, base_url, token, timeout, user_agent=None):
2424

2525
@telemetry.operation_name("getstream.api.common.upload_file")
2626
def upload_file(
27-
self, file: Optional[str] = None, user: Optional[OnlyUserID] = None
27+
self, file: str, user: Optional[OnlyUserID] = None
2828
) -> StreamResponse[FileUploadResponse]:
2929
form_fields = []
3030
if user is not None:
@@ -39,7 +39,7 @@ def upload_file(
3939
@telemetry.operation_name("getstream.api.common.upload_image")
4040
def upload_image(
4141
self,
42-
file: Optional[str] = None,
42+
file: str,
4343
upload_sizes: Optional[List[ImageSize]] = None,
4444
user: Optional[OnlyUserID] = None,
4545
) -> StreamResponse[ImageUploadResponse]:

0 commit comments

Comments
 (0)