Use github action (#119)

* github action
* drop py 3.4 (end of life more than 1 year, we will bump major anyway)
* use black instead of pep8 / pycodestyle
* ensure flake8 and fix issues
* some readme tweaks

Author: ferhatelmas

.github/workflows/ci.yml

@@ -0,0 +1,44 @@
+name: build
+on:
+  push:
+    branches:
+      - 'master'
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python: [3.5, 3.6, 3.7, 3.8]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python }}
+
+      - name: Add pip bin to PATH
+        run: |
+          echo "::add-path::/home/runner/.local/bin"
+
+      - name: Upgrade setuptools
+        if: ${{ matrix.python == '3.5' }}
+        run: pip install --upgrade setuptools
+
+      - name: Install deps with ${{ matrix.python }}
+        run: pip install ".[test, ci]"
+
+      - name: Lint with ${{ matrix.python }}
+        if: ${{ matrix.python == '3.8' }}
+        run: |
+          black --check stream
+          flake8 --ignore=E501,E225,W293,W503 stream
+
+      - name: Install, test and code coverage with ${{ matrix.python }}
+        env:
+          STREAM_KEY: ${{ secrets.STREAM_KEY }}
+          STREAM_SECRET: ${{ secrets.STREAM_SECRET }}
+        run: |
+          python setup.py test
+          python setup.py install
+          codecov

.travis.yml

@@ -1,7 +1,7 @@
 stream-python
 =============
 
-[![Build Status](https://travis-ci.org/GetStream/stream-python.svg?branch=master)](https://travis-ci.org/GetStream/stream-python) [![codecov](https://codecov.io/gh/GetStream/stream-python/branch/master/graph/badge.svg)](https://codecov.io/gh/GetStream/stream-python) [![PyPI version](https://badge.fury.io/py/stream-python.svg)](http://badge.fury.io/py/stream-python)
+[![build](https://github.com/GetStream/stream-python/workflows/build/badge.svg)](https://github.com/GetStream/stream-python/actions) [![codecov](https://codecov.io/gh/GetStream/stream-python/branch/master/graph/badge.svg)](https://codecov.io/gh/GetStream/stream-python) [![PyPI version](https://badge.fury.io/py/stream-python.svg)](http://badge.fury.io/py/stream-python)
 
 [stream-python](https://github.com/GetStream/stream-python) is the official Python client for [Stream](https://getstream.io/), a web service for building scalable newsfeeds and activity streams.
 
@@ -13,7 +13,7 @@ You can sign up for a Stream account at https://getstream.io/get_started.
 
 stream-python supports:
 
-- Python (3.4, 3.5, 3.6, 3.7, 3.8)
+- Python (3.5, 3.6, 3.7, 3.8)
 
 #### Install from Pypi
 
@@ -30,15 +30,15 @@ Documentation for this Python client are available at the [Stream website](https
 ```python
 import datetime
 
-# Instantiate a new client
+# Create a new client
 import stream
 client = stream.connect('YOUR_API_KEY', 'API_KEY_SECRET')
 
-# INstantiate a new client specifying datacenter location
+# Create a new client specifying data center location
 client = stream.connect('YOUR_API_KEY', 'API_KEY_SECRET', location='us-east')
 # Find your API keys here https://getstream.io/dashboard/
 
-# Instantiate a feed object
+# Create a feed object
 user_feed_1 = client.feed('user', '1')
 
 # Get activities from 5 to 10 (slow pagination)
@@ -168,11 +168,10 @@ LOCAL=true py.test
 Install black and flake8
 
 ```
-pip install black
-pip install flake8
+pip install .[lint]
 ```
 
-Install git hooks to avoid pushing invalid code (git commit will run black and flak8)
+Install git hooks to avoid pushing invalid code (git commit will run `black` and `flake8`)
 
 ### Releasing a new version
 

README.md

@@ -9,5 +9,4 @@ if ! black . --check -q; then
     exit 1
 fi
 
-flake8
-
+flake8 --ignore=E501,E225,W293,W503 .

dev_requirements.txt

@@ -1,6 +1,6 @@
 [tool.black]
 line-length = 88
-py36 = true
+target-version = ['py38']
 include = '\.pyi?$'
 exclude = '''
 /(

dotgit/hooks/pre-commit-format.sh

@@ -7,6 +7,9 @@
 import sys
 
 tests_require = ["pytest==3.2.5", "unittest2", "pytest-cov", "python-dateutil"]
+ci_require = ["flake8", "codecov"]
+if sys.version_info >= (3, 6, 0):
+    ci_require.append("black")
 
 long_description = open("README.md", "r").read()
 
@@ -28,7 +31,7 @@ def run_tests(self):
         # import here, cause outside the eggs aren't loaded
         import pytest
 
-        errno = pytest.main("-v --cov=./")
+        errno = pytest.main(["-v", "--cov=./"])
         sys.exit(errno)
 
 
@@ -45,7 +48,7 @@ def run_tests(self):
     packages=find_packages(),
     zip_safe=False,
     install_requires=install_requires,
-    extras_require={"test": tests_require},
+    extras_require={"test": tests_require, "ci": ci_require},
     cmdclass={"test": PyTest},
     tests_require=tests_require,
     include_package_data=True,
@@ -58,7 +61,6 @@ def run_tests(self):
         "License :: OSI Approved :: BSD License",
         "Natural Language :: English",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.4",
         "Programming Language :: Python :: 3.5",
         "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",

pyproject.toml

@@ -937,9 +937,8 @@ def test_missing_actor(self):
             "object": 1,
             "debug_example_undefined": "test",
         }
-        doit = lambda: self.user1.add_activity(activity_data)
         try:
-            doit()
+            self.user1.add_activity(activity_data)
             raise ValueError("should have raised InputException")
         except InputException:
             pass
@@ -1113,10 +1112,11 @@ def test_email_redirect_invalid_target(self):
         # no protocol specified, this should raise an error
         target_url = "google.com"
         user_id = "tommaso"
-        create_redirect = lambda: self.c.create_redirect_url(
-            target_url, user_id, events
-        )
-        self.assertRaises(MissingSchema, create_redirect)
+
+        def redirect():
+            self.c.create_redirect_url(target_url, user_id, events)
+
+        self.assertRaises(MissingSchema, redirect)
 
     def test_follow_redirect_url(self):
         target_url = "http://google.com/?a=b&c=d"