chore: lint fix

Author: JimmyPettersson85

.github/CODEOWNERS

@@ -1 +1 @@
-* @JimmyPettersson85 @xernobyl @itsmeadi
+* @JimmyPettersson85 @itsmeadi

.rubocop.yml

@@ -31,6 +31,8 @@ Metrics/PerceivedComplexity:
 
 Naming/AccessorMethodName:
   Enabled: false
+Naming/PredicateMethod:
+  Enabled: false
 
 Style/AccessorGrouping:
   Enabled: false

lib/stream/activities.rb

@@ -52,7 +52,7 @@ def get_activities(params = {})
         end
       end
       %i[enrich reactions].each { |k| params.delete(k) }
-      
+
       # Handle multiple IDs by joining with commas
       params[:ids] = params[:ids].join(',') if params[:ids]&.is_a?(Array)
 

lib/stream/client.rb

@@ -214,7 +214,7 @@ def call(env)
     end
 
     def initialize(app)
-      super app
+      super
       @parser = nil
     end
 

spec/client_spec.rb

@@ -144,17 +144,17 @@
     before do
       @client = Stream::Client.new('key', 'secret', 'app_id')
       @captured_requests = []
-      
+
       # Mock the HTTP client to capture requests
-      allow_any_instance_of(Stream::StreamHTTPClient).to receive(:make_http_request) do |instance, method, relative_url, params, data, headers|
+      allow_any_instance_of(Stream::StreamHTTPClient).to receive(:make_http_request) do |_instance, method, relative_url, params, data, headers|
         @captured_requests << {
           method: method,
           url: relative_url,
           params: params,
           data: data,
           headers: headers
         }
-        
+
         # Return mock response
         {
           'results' => [],
@@ -164,13 +164,13 @@
     end
 
     it 'should encode multiple activity IDs as comma-separated values' do
-      ids = ['id1', 'id2', 'id3']
-      
+      ids = %w[id1 id2 id3]
+
       @client.get_activities(ids: ids)
-      
+
       expect(@captured_requests.length).to eq(1)
       request = @captured_requests.first
-      
+
       # Verify the IDs are joined with commas, not passed as an array
       expect(request[:params][:ids]).to eq('id1,id2,id3')
       expect(request[:params][:ids]).not_to be_a(Array)
@@ -179,21 +179,21 @@
 
     it 'should handle single ID without comma separation' do
       @client.get_activities(ids: ['single-id'])
-      
+
       expect(@captured_requests.length).to eq(1)
       request = @captured_requests.first
-      
+
       # Single ID should still be encoded correctly
       expect(request[:params][:ids]).to eq('single-id')
       expect(request[:params][:ids]).not_to be_a(Array)
     end
 
     it 'should preserve other parameters when encoding IDs' do
-      @client.get_activities(ids: ['id1', 'id2'], limit: 10, offset: 20)
-      
+      @client.get_activities(ids: %w[id1 id2], limit: 10, offset: 20)
+
       expect(@captured_requests.length).to eq(1)
       request = @captured_requests.first
-      
+
       expect(request[:params][:ids]).to eq('id1,id2')
       expect(request[:params][:limit]).to eq(10)
       expect(request[:params][:offset]).to eq(20)

spec/integration_spec.rb

@@ -179,7 +179,7 @@
       expect(results[0]['id']).to eq response['id']
       feed.remove_activity(response['id'])
       results = feed.get(limit: 1)['results']
-      expect(results[0]['id']).not_to eq response['id'] if results.count > 0
+      expect(results[0]['id']).not_to eq response['id'] if results.any?
     end
 
     example 'removing an activity by foreign_id' do
@@ -677,19 +677,19 @@
       end
       example 'get multiple activities by IDs' do
         # Create two different activities
-        activity1 = @feed42.add_activity({
+        activity1 = @feed42.add_activity(
           actor: 'alice',
           verb: 'tweet',
           object: 'message1',
           foreign_id: "tweet-#{Time.now.to_i}-1"
-        })
-        
-        activity2 = @feed42.add_activity({
+        )
+
+        activity2 = @feed42.add_activity(
           actor: 'bob',
           verb: 'like',
           object: 'post1',
           foreign_id: "like-#{Time.now.to_i}-2"
-        })
+        )
 
         # Remove duration from comparison since it varies
         activity1.delete('duration')
@@ -714,13 +714,13 @@
         # Verify the returned activities match the original activities
         response['results'].each do |returned_activity|
           returned_activity.delete('duration')
-          
+
           if returned_activity['id'] == activity1['id']
             expect(returned_activity).to eq(activity1)
           elsif returned_activity['id'] == activity2['id']
             expect(returned_activity).to eq(activity2)
           else
-            fail "Unexpected activity ID: #{returned_activity['id']}"
+            raise "Unexpected activity ID: #{returned_activity['id']}"
           end
         end
       end