feat: connection pooling and idle timeout (#136)

Author: peterdeme

.github/workflows/ci.yml

@@ -2,24 +2,28 @@ name: build
 
 on: [pull_request]
 
+concurrency: 
+  group: ${{ github.workflow }}-${{ github.head_ref }}
+  cancel-in-progress: true
+
 jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
+      max-parallel: 1
       matrix:
-        ruby: ['2.5', '2.6', '2.7', '3.0']
+        ruby: ['2.5', '2.6', '2.7', '3.0', '3.1']
     name: Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
 
       - env:
           STREAM_API_KEY: ${{ secrets.STREAM_API_KEY }}
           STREAM_API_SECRET: ${{ secrets.STREAM_API_SECRET }}
         run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
           bundle exec rake rubocop
           bundle exec rake test

.rubocop.yml

@@ -32,9 +32,6 @@ Metrics/PerceivedComplexity:
 Naming/AccessorMethodName:
   Enabled: false
 
-Security/Open:
-  Enabled: false
-
 Style/AccessorGrouping:
   Enabled: false
 Style/Documentation:
@@ -43,3 +40,6 @@ Style/DoubleCopDisableDirective:
   Enabled: false
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Gemspec/RequireMFA:
+  Enabled: false

lib/stream/client.rb

@@ -1,4 +1,5 @@
 require 'faraday'
+require 'faraday/net_http_persistent'
 require 'stream/errors'
 require 'stream/feed'
 require 'stream/signer'
@@ -170,7 +171,10 @@ def initialize(url_generator)
         faraday.use RaiseHttpException
         faraday.options[:open_timeout] = @options[:default_timeout]
         faraday.options[:timeout] = @options[:default_timeout]
-        faraday.adapter Faraday.default_adapter
+        faraday.adapter :net_http_persistent, pool_size: 5 do |http|
+          # AWS load balancer idle timeout is 60 secs, so let's make it 59
+          http.idle_timeout = 59
+        end
       end
       @base_path = url_generator.base_path
       @conn.path_prefix = base_path

spec/integration_spec.rb

@@ -7,7 +7,7 @@
 end
 
 describe 'Integration tests' do
-  before do
+  before(:all) do
     @client = Stream::Client.new(ENV['STREAM_API_KEY'], ENV['STREAM_API_SECRET'], nil, location: ENV['STREAM_REGION'], default_timeout: 10)
     @feed42 = @client.feed('flat', generate_uniq_feed_name)
     @feed43 = @client.feed('flat', generate_uniq_feed_name)
@@ -530,6 +530,7 @@
             'data' => {
               'hobbies' => %w[playing sleeping eating]
             },
+            'id' => 'aabbcc',
             'name' => 'juniper'
           }
         },
@@ -541,6 +542,7 @@
             'data' => {
               'interests' => ['sunbeams', 'surprise attacks']
             },
+            'id' => 'ddeeff',
             'name' => 'ruby'
           }
         }
@@ -568,6 +570,7 @@
             'data' => {
               'interests' => ['sunbeams', 'surprise attacks']
             },
+            'id' => 'ddeeff',
             'name' => 'ruby'
           }
         }

stream.gemspec

@@ -14,8 +14,18 @@ Gem::Specification.new do |gem|
   gem.files = Dir['lib/**/*']
   gem.license = 'BSD-3-Clause'
   gem.required_ruby_version = '>=2.5.0'
+  gem.metadata = {
+    'homepage_uri' => 'https://getstream.io/activity-feeds/',
+    'bug_tracker_uri' => 'https://github.com/GetStream/stream-ruby/issues',
+    'documentation_uri' => 'https://getstream.io/activity-feeds/docs/ruby/?language=ruby',
+    'changelog_uri' => 'https://github.com/GetStream/stream-ruby/blob/main/CHANGELOG.md',
+    'source_code_uri' => 'https://github.com/GetStream/stream-ruby'
+  }
+
   gem.add_dependency 'faraday'
+  gem.add_dependency 'faraday-net_http_persistent'
   gem.add_dependency 'jwt'
+  gem.add_dependency 'net-http-persistent'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'simplecov'