Merge branch 'develop'

Author: skydoves

.github/workflows/android.yml

@@ -97,14 +97,58 @@ jobs:
           ./gradlew --scan --stacktrace \
               assembleDebug
 
-      - name: Unit Tests
+  unitTest:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: set up JDK
+        uses: actions/setup-java@v1
+        with:
+          java-version: 11
+
+      - name: Cache Gradle and wrapper
+        uses: actions/cache@v3
+        with:
+          path: |
+            ~/.gradle/caches
+            ~/.gradle/wrapper
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
+          restore-keys: |
+            ${{ runner.os }}-gradle-
+
+      - name: Run unit tests
         run: |
-          ./gradlew --scan --stacktrace \
-              :stream-video-android-compose:testDebugUnitTest \
-#              :stream-video-android-core:testDebugUnitTest
-
-#      Enable this after merging android manged devices.
-#      - name: Android Tests
-#        run: |
-#          ./gradlew --scan --stacktrace \
-#              :stream-video-android-core:connectedAndroidTest
+          ./gradlew :stream-video-android-compose:testDebugUnitTest --scan --stacktrace
+          ./gradlew :stream-video-android-core:testDebugUnitTest --scan --stacktrace
+
+  androidTest-GMD:
+    name: Android Test with GMD
+    if: ${{ false }}  # disable for now
+    runs-on: macOS-latest
+    timeout-minutes: 55
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'zulu'
+          java-version: 17
+
+      # Sets gradle up
+      - name: Setup Gradle
+        uses: gradle/gradle-build-action@v2
+
+      # Cleans managed device if previously settle and space currently is not available
+      - name: Clean Managed Devices
+        run: ./gradlew cleanManagedDevices --unused-only
+
+      - name: Run instrumented tests with GMD
+        run: ./gradlew pixel2api31DebugAndroidTest -Dorg.gradle.workers.max=1 -Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect" -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true -Pandroid.experimental.testOptions.managedDevices.setupTimeoutMinutes=60
+

README.md

@@ -4,13 +4,18 @@
 
 <p align="center">
   <a href="https://github.com/GetStream/stream-video-android/actions"><img src="https://github.com/GetStream/stream-video-android/workflows/App%20Distribute%20CI/badge.svg" /></a>
-  <a href="https://android-arsenal.com/api?level=21"><img alt="API" src="https://img.shields.io/badge/API-21%2B-brightgreen.svg?style=flat"/></a>
+  <a href="https://android-arsenal.com/api?level=24"><img alt="API" src="https://img.shields.io/badge/API-24%2B-brightgreen.svg?style=flat"/></a>
   <a href="https://search.maven.org/search?q=stream-video-android"><img src="https://img.shields.io/maven-central/v/io.getstream/stream-video-android-core.svg?label=Maven%20Central" /></a>
 </p>
 
-This is the official Android SDK for Stream Video.
+This is the official Android SDK for Stream Video, a service for building video call, audio room, and live streaming applications. This library includes both a low-level video SDK and a set of reusable UI components. 
+Most users start with the Compose UI components, and fall back to the lower level API when they want to customize things.
 
-## What is Stream?
+<a href="https://getstream.io?utm_source=Github&utm_medium=Github_Repo_Content_Ad&utm_content=Developer&utm_campaign=Github_Android_Video_SDK&utm_term=DevRelOss">
+<img src="https://user-images.githubusercontent.com/24237865/138428440-b92e5fb7-89f8-41aa-96b1-71a5486c5849.png" align="right" width="12%"/>
+</a>
+
+## 🛥 What is Stream?
 
 Stream allows developers to rapidly deploy scalable feeds, chat messaging and video with an industry leading 99.999% uptime SLA guarantee.
 
@@ -55,37 +60,73 @@ Here are some of the features we support:
 * Call recording
 * Broadcasting to HLS
 
-## Roadmap
+## 🗺️ Roadmap
 
 Video roadmap and changelog is available [here](https://github.com/GetStream/protocol/discussions/127). 
 
-### 0.2 milestone
+### 0.2.0 milestone
 
-- [ ] bug: screensharing is broken. android doesn’t receive/render (not sure) the screenshare. video shows up as the gray avatar (Thierry)
-- [ ] bug: screenshare is not removed after it stops when a participant leaves the call (Thierry) (probably just dont update the state when the participant leaves)
-- [ ] Livestream tutorial
+- [ ] Local Video disconnects sometimes (ICE restarts issue for the publisher. we're waiting for the backend support)
 - [ ] Deeplink support for video call demo & dogfooding app (skip auth for the video demo, keep it for dogfooding)
 - [ ] Chat Integration
 - [ ] XML version of VideoRenderer
 - [ ] Call Analytics stateflow
 - [ ] Automatically handle pagination and sorting on > 6 participants 
+- [ ] Make it easy to test ringing support
+- [ ] publish app on play store
+- [ ] report version number of SDK on all API calls
+- [ ] Bug: java.net.UnknownHostException: Unable to resolve host "hint.stream-io-video.com" isn't throw but instead logged as INFO
+- [ ] Bug: screensharing is broken. android doesn’t receive/render (not sure) the screenshare. video shows up as the gray avatar
 - [X] Reactions
+- [X] bug: screenshare is not removed after it stops when a participant leaves the call (Thierry) (probably just dont update the state when the participant leaves)
 
-### 0.3 milestone
+### 0.3.0 milestone
 
+- [ ] Setting to default to speakerphone or earpiece
+- [ ] Button to switch speakerphone/earpiece
+- [ ] Livestream tutorial (depends on RTMP support)
+- [ ] H264 workaround on Samsung 23 (see https://github.com/livekit/client-sdk-android/blob/main/livekit-android-sdk/src/main/java/io/livekit/android/webrtc/SimulcastVideoEncoderFactoryWrapper.kt#L34 and
+- https://github.com/react-native-webrtc/react-native-webrtc/issues/983#issuecomment-975624906)
+- [ ] Bluetooth reliability
 - [ ] Dynascale 2.0 (codecs, f resolution switches, resolution webrtc handling)
 - [ ] Test coverage
 - [ ] Testing on more devices
 - [ ] Speaking while muted stateflow
-- [ ] Cleanup the retry behaviour in the RtcSession (see the TODO)
-- [ ] Android SDK development.md cleanup
+- [X] Cleanup the retry behaviour in the RtcSession
+- [ ] Android SDK development.md cleanup (Daniel)
 - [X] SDK development guide for all teams
 
-### 0.4 milestone
+### 0.4.0 milestone
 
+- [ ] Pagination on query members & query channels
 - [ ] Analytics integration
 - [ ] Screensharing from mobile
 - [ ] Tap to focus
 - [ ] Camera controls
 - [ ] Audio & Video filters
-- [ ] Picture of the video stream at highest resolution
+- [ ] Picture of the video stream at highest resolution
+- [ ] Review foreground service vs backend for some things like screensharing etc
+
+## 💼 We are hiring!
+
+We've recently closed a [\$38 million Series B funding round](https://techcrunch.com/2021/03/04/stream-raises-38m-as-its-chat-and-activity-feed-apis-power-communications-for-1b-users/) and we keep actively growing.
+Our APIs are used by more than a billion end-users, and you'll have a chance to make a huge impact on the product within a team of the strongest engineers all over the world.
+Check out our current openings and apply via [Stream's website](https://getstream.io/team/#jobs).
+
+## License
+
+```
+Copyright (c) 2014-2023 Stream.io Inc. All rights reserved.
+
+Licensed under the Stream License;
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+   https://github.com/GetStream/stream-video-android/blob/main/LICENSE
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+```

buildSrc/src/main/kotlin/io/getstream/video/android/Configuration.kt

@@ -6,7 +6,7 @@ object Configuration {
     const val minSdk = 24
     const val majorVersion = 0
     const val minorVersion = 0
-    const val patchVersion = 17
+    const val patchVersion = 18
     const val versionName = "$majorVersion.$minorVersion.$patchVersion"
     const val versionCode = 1
     const val snapshotVersionName = "$majorVersion.$minorVersion.${patchVersion}-SNAPSHOT"

demo/src/main/kotlin/io/getstream/video/android/demo/ui/call/CallActivity.kt

@@ -18,25 +18,19 @@ package io.getstream.video.android.demo.ui.call
 
 import android.os.Bundle
 import androidx.activity.compose.setContent
-import androidx.activity.viewModels
 import androidx.compose.foundation.background
 import androidx.compose.ui.Modifier
 import androidx.lifecycle.lifecycleScope
 import io.getstream.video.android.common.AbstractCallActivity
-import io.getstream.video.android.common.viewmodel.CallViewModel
-import io.getstream.video.android.common.viewmodel.CallViewModelFactory
 import io.getstream.video.android.compose.theme.VideoTheme
-import io.getstream.video.android.compose.ui.components.call.CallContainer
+import io.getstream.video.android.compose.ui.components.call.activecall.CallContent
 import io.getstream.video.android.core.Call
 import io.getstream.video.android.core.StreamVideo
 import io.getstream.video.android.model.StreamCallId
 import kotlinx.coroutines.launch
 
 class CallActivity : AbstractCallActivity() {
 
-    private val factory by lazy { CallViewModelFactory() }
-    private val vm by viewModels<CallViewModel> { factory }
-
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
@@ -46,10 +40,9 @@ class CallActivity : AbstractCallActivity() {
 
         setContent {
             VideoTheme {
-                CallContainer(
+                CallContent(
                     modifier = Modifier.background(color = VideoTheme.colors.appBackground),
                     call = call,
-                    callViewModel = vm,
                     onBackPressed = { finish() },
                 )
             }

development.md

@@ -123,7 +123,7 @@ Typically for development you want to fail fast and loud. For production you wan
 ### RTC offer/answer cycle
 
 * sessionId is created locally as a random UUID
-* create the peer connections
+* create two peer connections (publisher and subscriber)
 * capture audio and video (if we're not doing so already, in many apps it should already be on for the preview screen)
 * execute the join request
 * add the audio/video tracks which triggers onNegotiationNeeded
@@ -207,18 +207,6 @@ With the second approach everything is easy to understand and customize.
 * Clicking accept or reject fires triggers the accept/reject API endpoints
 * Call members have an accepted_at, rejected_at field
 
-Ringing state on a call has the following options
-
-```kotlin
-sealed class RingingState() {
-    object Incoming : RingingState()
-    object Outgoing : RingingState()
-    object Active : RingingState()
-    object RejectedByAll : RingingState()
-    object TimeoutNoAnswer : RingingState()
-}
-```
-
 ### Media Manager
 
 The media manager should support capturing local video with or without joining a call

docusaurus/docs/Android/01-basics/01-introduction.mdx

@@ -4,8 +4,6 @@ description: Introduction about Stream's video SDK
 slug: /
 ---
 
-## Introduction
-
 Welcome to the Stream Video SDK - a comprehensive toolkit designed to help you swiftly implement features such as video calling, audio calling, audio rooms, and livestreaming within your app.
 Our goal is to ensure an optimal developer experience that enables your application to go live within days.
 

docusaurus/docs/Android/01-basics/02-installation.mdx

@@ -7,7 +7,7 @@ description: Install the SDK for video calling
 
 All Stream Android libraries are available from MavenCentral, so you may not need to do an additional setup.
 
-Before you add Stream dependencies, update your repositories in the settings.gradle file to include these two repositories:
+Before you add Stream dependencies, update your repositories in the `settings.gradle` file to include these two repositories:
 
 ```gradle
 dependencyResolutionManagement {
@@ -19,7 +19,7 @@ dependencyResolutionManagement {
 }
 ```
 
-Or if you're using an older project setup, add these repositories in your project level build.gradle file:
+Or if you're using an older project setup, add these repositories in your project level `build.gradle` file:
 
 ```groovy
 allprojects {
@@ -37,7 +37,7 @@ Check the [Releases page](https://github.com/GetStream/stream-video-android/rele
 ## Available Artifacts
 
 ### Core Client
-To add the low-level Video client library to your app, open your module's build.gradle script and add the following:
+To add the low-level Video client library to your app, open your module's `build.gradle` script and add the following:
 
 ```groovy
 dependencies {
@@ -58,7 +58,7 @@ Adding the Compose Video Components library as a dependency will automatically i
 
 ### Push Notifications
 
-We ship multiple artifacts to easily integrate Stream Chat with third party push notification providers. See the Push Notification page for more details.
+We ship multiple artifacts to easily integrate Stream Chat with third party push notification providers. See the [Push Notification](../06-advanced/02-push-notifications/01-overview.mdx) page for more details.
 
 ## Snapshot Builds
 

docusaurus/docs/Android/01-basics/03-quickstart.mdx

@@ -15,8 +15,8 @@ val client = StreamVideoBuilder(
      context = context,
      apiKey = apiKey,
      geo = GEO.GlobalEdgeNetwork,
-     user,
-     token,
+     user = user,
+     token = token,
 ).build()
 
 val call = client.call("default", "123")