Merge pull request #610 from GetStream/refactor/dogfooding-fix

Refactor to use SharedFlow for the events

Author: skydoves

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/join/CallJoinScreen.kt

@@ -70,7 +70,7 @@ fun CallJoinScreen(
     navigateToCallLobby: (callId: String) -> Unit,
     navigateUpToLogin: () -> Unit
 ) {
-    val uiState by callJoinViewModel.uiState.collectAsState()
+    val uiState by callJoinViewModel.uiState.collectAsState(CallJoinUiState.Nothing)
 
     HandleCallJoinUiState(
         callJoinUiState = uiState,

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/join/CallJoinViewModel.kt

@@ -26,12 +26,13 @@ import io.getstream.video.android.datastore.delegate.StreamUserDataStore
 import io.getstream.video.android.model.User
 import io.getstream.video.android.model.mapper.isValidCallId
 import io.getstream.video.android.model.mapper.toTypeAndId
-import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.MutableSharedFlow
+import kotlinx.coroutines.flow.SharedFlow
 import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flowOf
-import kotlinx.coroutines.flow.stateIn
+import kotlinx.coroutines.flow.shareIn
 import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
@@ -42,13 +43,14 @@ class CallJoinViewModel @Inject constructor(
 ) : ViewModel() {
     val user: StateFlow<User?> = dataStore.user
 
-    private val event: MutableStateFlow<CallJoinEvent> = MutableStateFlow(CallJoinEvent.Nothing)
-    internal val uiState: StateFlow<CallJoinUiState> = event
+    private val event: MutableSharedFlow<CallJoinEvent> = MutableSharedFlow()
+    internal val uiState: SharedFlow<CallJoinUiState> = event
         .flatMapLatest { event ->
             when (event) {
                 is CallJoinEvent.GoBackToLogin -> {
                     flowOf(CallJoinUiState.GoBackToLogin)
                 }
+
                 is CallJoinEvent.JoinCall -> {
                     val call = joinCall(event.callId)
                     flowOf(CallJoinUiState.JoinCompleted(callId = call.cid))
@@ -58,21 +60,21 @@ class CallJoinViewModel @Inject constructor(
                 else -> flowOf(CallJoinUiState.Nothing)
             }
         }
-        .stateIn(viewModelScope, SharingStarted.Lazily, CallJoinUiState.Nothing)
+        .shareIn(viewModelScope, SharingStarted.Lazily, 0)
 
     init {
         viewModelScope.launch {
             // We need to check whether the StreamVideo instance is initialised and go back to Login
             // if not. In the current implementation we only initialise after Login and if the
             // Android process is restored then the Login is skipped Stream Video is not initialised.
             if (!StreamVideo.isInstalled) {
-                event.value = CallJoinEvent.GoBackToLogin
+                event.emit(CallJoinEvent.GoBackToLogin)
             }
         }
     }
 
     fun handleUiEvent(event: CallJoinEvent) {
-        this.event.value = event
+        viewModelScope.launch { this@CallJoinViewModel.event.emit(event) }
     }
 
     private fun joinCall(callId: String? = null): Call {

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/lobby/CallLobbyScreen.kt

@@ -111,7 +111,7 @@ private fun CallLobbyHeader(
     callLobbyViewModel: CallLobbyViewModel = hiltViewModel(),
     navigateUpToLogin: () -> Unit
 ) {
-    val uiState by callLobbyViewModel.uiState.collectAsState()
+    val uiState by callLobbyViewModel.uiState.collectAsState(initial = CallLobbyUiState.Nothing)
 
     HandleCallLobbyUiState(
         callLobbyUiState = uiState,

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/lobby/CallLobbyViewModel.kt

@@ -26,13 +26,16 @@ import io.getstream.video.android.core.StreamVideo
 import io.getstream.video.android.datastore.delegate.StreamUserDataStore
 import io.getstream.video.android.model.StreamCallId
 import io.getstream.video.android.model.User
+import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.SharedFlow
 import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.onCompletion
-import kotlinx.coroutines.flow.stateIn
+import kotlinx.coroutines.flow.shareIn
+import kotlinx.coroutines.launch
 import javax.inject.Inject
 
 @HiltViewModel
@@ -54,8 +57,8 @@ class CallLobbyViewModel @Inject constructor(
     private val _isLoading: MutableStateFlow<Boolean> = MutableStateFlow(false)
     internal val isLoading: StateFlow<Boolean> = _isLoading
 
-    private val event: MutableStateFlow<CallLobbyEvent> = MutableStateFlow(CallLobbyEvent.Nothing)
-    internal val uiState: StateFlow<CallLobbyUiState> = event
+    private val event: MutableSharedFlow<CallLobbyEvent> = MutableSharedFlow()
+    internal val uiState: SharedFlow<CallLobbyUiState> = event
         .flatMapLatest { event ->
             when (event) {
                 is CallLobbyEvent.JoinCall -> flowOf(CallLobbyUiState.JoinCompleted)
@@ -64,10 +67,10 @@ class CallLobbyViewModel @Inject constructor(
             }
         }
         .onCompletion { _isLoading.value = false }
-        .stateIn(viewModelScope, SharingStarted.Lazily, CallLobbyUiState.Nothing)
+        .shareIn(viewModelScope, SharingStarted.Lazily, 0)
 
     fun handleUiEvent(event: CallLobbyEvent) {
-        this.event.value = event
+        viewModelScope.launch { this@CallLobbyViewModel.event.emit(event) }
     }
 
     fun enableCamera(enabled: Boolean) {

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/login/LoginScreen.kt

@@ -73,7 +73,7 @@ fun LoginScreen(
     loginViewModel: LoginViewModel = hiltViewModel(),
     navigateToCallJoin: () -> Unit
 ) {
-    val uiState by loginViewModel.uiState.collectAsState()
+    val uiState by loginViewModel.uiState.collectAsState(initial = LoginUiState.Nothing)
     val isLoading by remember(uiState) { mutableStateOf(uiState !is LoginUiState.Nothing) }
     var isShowingEmailLoginDialog by remember { mutableStateOf(false) }
 

dogfooding/src/main/kotlin/io/getstream/video/android/dogfooding/ui/login/LoginViewModel.kt

@@ -32,15 +32,15 @@ import io.getstream.video.android.dogfooding.token.TokenResponse
 import io.getstream.video.android.model.User
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.delay
-import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.MutableSharedFlow
+import kotlinx.coroutines.flow.SharedFlow
 import kotlinx.coroutines.flow.SharingStarted
-import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.flowOn
-import kotlinx.coroutines.flow.stateIn
+import kotlinx.coroutines.flow.shareIn
 import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
@@ -50,19 +50,19 @@ class LoginViewModel @Inject constructor(
     private val dataStore: StreamUserDataStore
 ) : ViewModel() {
 
-    private val event: MutableStateFlow<LoginEvent> = MutableStateFlow(LoginEvent.Nothing)
-    internal val uiState: StateFlow<LoginUiState> = event
+    private val event: MutableSharedFlow<LoginEvent> = MutableSharedFlow()
+    internal val uiState: SharedFlow<LoginUiState> = event
         .flatMapLatest { event ->
             when (event) {
                 is LoginEvent.Loading -> flowOf(LoginUiState.Loading)
                 is LoginEvent.GoogleSignIn -> flowOf(LoginUiState.GoogleSignIn)
                 is LoginEvent.SignInInSuccess -> signInInSuccess(event.email)
                 else -> flowOf(LoginUiState.Nothing)
             }
-        }.stateIn(viewModelScope, SharingStarted.Lazily, LoginUiState.Nothing)
+        }.shareIn(viewModelScope, SharingStarted.Lazily, 0)
 
     fun handleUiEvent(event: LoginEvent) {
-        this.event.value = event
+        viewModelScope.launch { this@LoginViewModel.event.emit(event) }
     }
 
     private fun signInInSuccess(email: String) = flow<LoginUiState> {