Fix a rare crash when creating the publisher peer connection (#1507)

* Introduce PR quality checks

* Remove `localParticipant`from publisher and thus the dependency towards `call.state.me`

* Spotless

* Update tests

Author: aleksandar-apostolov

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt

@@ -935,7 +935,6 @@ public class RtcSession internal constructor(
     internal fun createPublisher(publishOptions: List<PublishOption>): Publisher {
         return call.peerConnectionFactory.makePublisher(
             sessionId = sessionId,
-            me = call.state.me.value!!,
             sfuClient = sfuConnectionModule.api,
             mediaManager = call.mediaManager,
             configuration = connectionConfiguration,

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/Publisher.kt

@@ -19,7 +19,6 @@ package io.getstream.video.android.core.call.connection
 import androidx.annotation.VisibleForTesting
 import io.getstream.result.onErrorSuspend
 import io.getstream.video.android.core.MediaManagerImpl
-import io.getstream.video.android.core.ParticipantState
 import io.getstream.video.android.core.api.SignalServerService
 import io.getstream.video.android.core.call.connection.job.RestartIceJobDelegate
 import io.getstream.video.android.core.call.connection.stats.ComputedStats
@@ -65,7 +64,6 @@ import stream.video.sfu.signal.SetPublisherRequest
 import java.util.UUID
 
 internal class Publisher(
-    private val localParticipant: ParticipantState,
     private val mediaManager: MediaManagerImpl,
     private val peerConnectionFactory: StreamPeerConnectionFactory,
     private val publishOptions: List<PublishOption>,

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/StreamPeerConnectionFactory.kt

@@ -21,7 +21,6 @@ import android.media.AudioAttributes
 import android.os.Build
 import io.getstream.log.taggedLogger
 import io.getstream.video.android.core.MediaManagerImpl
-import io.getstream.video.android.core.ParticipantState
 import io.getstream.video.android.core.api.SignalServerService
 import io.getstream.video.android.core.call.connection.coding.SelectiveVideoDecoderFactory
 import io.getstream.video.android.core.call.video.FilterVideoProcessor
@@ -349,7 +348,6 @@ public class StreamPeerConnectionFactory(
     }
 
     internal fun makePublisher(
-        me: ParticipantState,
         mediaManager: MediaManagerImpl,
         publishOptions: List<PublishOption>,
         coroutineScope: CoroutineScope,
@@ -368,7 +366,6 @@ public class StreamPeerConnectionFactory(
             sessionId = sessionId,
             sfuClient = sfuClient,
             peerConnectionFactory = this,
-            localParticipant = me,
             mediaManager = mediaManager,
             publishOptions = publishOptions,
             coroutineScope = coroutineScope,

stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/call/connection/PublisherTest.kt

@@ -152,7 +152,6 @@ class PublisherTest {
         // Construct a "real" Publisher but spy it, so we can mock or verify inherited calls.
         publisher = spyk(
             Publisher(
-                localParticipant = mockParticipantState,
                 mediaManager = mockMediaManager,
                 peerConnectionFactory = mockPeerConnectionFactory,
                 publishOptions = listOf(videoPublishOption, audioPublishOption),

stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/call/connection/StreamPeerConnectionFactoryTest.kt

@@ -105,7 +105,6 @@ class StreamPeerConnectionFactoryTest {
 
         // We're testing makePublisher, so we pass in all required arguments
         val publisher = factory.makePublisher(
-            me = mockParticipantState,
             mediaManager = mockMediaManager,
             publishOptions = fakePublishOptions,
             coroutineScope = testScope,