-
Notifications
You must be signed in to change notification settings - Fork 56
Use workflows from build conventions repository #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
WalkthroughThis pull request migrates two GitHub Actions workflows from the android-ci-actions repository to the stream-build-conventions-android repository, updating references and pinning to a specific version (v0.6.0). One workflow also introduces concurrency configuration to manage job cancellation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/pr-clean-old-drafts.yaml.github/workflows/pr-quality.yml
🔇 Additional comments (4)
.github/workflows/pr-clean-old-drafts.yaml (2)
6-6: LGTM: Cron schedule is correctly configured.The cron expression
"0 7 * * 1"correctly schedules the workflow to run every Monday at 07:00 UTC. The comment accurately reflects the timing.
15-16: The workflow reference is correct and properly configured.The migration to the centralized conventions repository is valid. The
pr-clean-stale.yamlworkflow exists atv0.6.0in the GetStream/stream-build-conventions-android repository, and the job name change frompr-checklisttopr-clean-stalealigns with the new workflow name..github/workflows/pr-quality.yml (2)
5-5: LGTM: Formatting change improves readability.The addition of spaces in the array is a minor formatting improvement that enhances readability.
12-14: Excellent addition: Concurrency configuration prevents redundant workflow runs.The concurrency configuration will automatically cancel in-progress workflow runs when new commits are pushed to the same PR, which saves CI resources and reduces wait times.
|



Goal
AND-961: Move shared workflows to conventions repo
We're centralizing the workflows with the plugins in the build conventions repo, so we're changing the references to point to them
Implementation
Change the workflow references
🎨 UI Changes
None
Testing
The workflows should run
☑️Contributor Checklist
General
developbranchCode & documentation
stream-video-examples)☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.