fix: fixing ios call id issues when using firebase provider (#599)

* fixing ios call id issues

* typo fix

Author: Brazol

docusaurus/docs/Flutter/05-advanced/02-ringing.mdx

@@ -20,6 +20,10 @@ To receive push notifications from Stream Video, you'll need to:
 1. Configure your push notification provider on the Stream Dashboard.
 2. Add the client-side integration. For Flutter this guide demonstrates using Firebase Cloud Messaging (FCM) for Android and Apple Push Notification Service (APNs) for iOS devices.
 
+:::warning
+  To get the best experience we strongly suggest using APNs for iOS. While our goal is to ensure compatibility with both providers on iOS, Firebase is not yet fully supported.
+:::
+
 ### Integrating Firebase for Android
 
 #### Step 1 - Get the Firebase Credentials

packages/stream_video/lib/src/stream_video.dart

@@ -584,6 +584,7 @@ class StreamVideo {
     final callCid = payload['call_cid'] as String?;
     if (callCid == null) return false;
 
+    final callUUID = const Uuid().v4();
     var callId = const Uuid().v4();
     var callType = StreamCallType();
 
@@ -606,7 +607,7 @@ class StreamVideo {
       case CallRingingState.ringing:
         unawaited(
           manager.showIncomingCall(
-            uuid: callId,
+            uuid: callUUID,
             handle: createdById,
             nameCaller: createdByName,
             callCid: callCid,
@@ -620,7 +621,7 @@ class StreamVideo {
       case CallRingingState.ended:
         unawaited(
           manager.showMissedCall(
-            uuid: callId,
+            uuid: callUUID,
             handle: createdById,
             nameCaller: createdByName,
             callCid: callCid,

packages/stream_video_push_notification/ios/Classes/StreamVideoPKDelegateManager.swift

@@ -80,26 +80,19 @@ public class StreamVideoPKDelegateManager: NSObject, PKPushRegistryDelegate {
         let defaultCallText = "Unknown Caller"
 
         let callCid = streamDict?["call_cid"] as? String ?? ""
-        var createdByName = streamDict?["created_by_display_name"] as? String
-        var createdById = streamDict?["created_by_id"] as? String
+        let createdByName = streamDict?["created_by_display_name"] as? String
+        let createdById = streamDict?["created_by_id"] as? String
 
-        let splitCid = callCid.split(separator: ":", maxSplits: 1, omittingEmptySubsequences: true)
-        var callId = UUID().uuidString;
-        var callType = "";
+        var callUUID = UUID().uuidString;
 
-        if splitCid.count == 2 {
-            let callType = String(splitCid[0])
-            let callId = String(splitCid[1])
-        } 
-        
         let data: StreamVideoPushParams
         if let jsonData = self.defaultData {
             data = StreamVideoPushParams(args: jsonData)
         } else {
             data = StreamVideoPushParams(args: [String: Any]())
         }
 
-        data.callKitData.uuid = callId
+        data.callKitData.uuid = callUUID
         data.callKitData.nameCaller = createdByName ?? defaultCallText
         data.callKitData.handle = createdById ?? defaultCallText
         data.callKitData.type = 1 //video

packages/stream_video_push_notification/lib/src/stream_video_push_notification.dart

@@ -1,6 +1,7 @@
 import 'dart:async';
 import 'dart:io';
 
+import 'package:collection/collection.dart';
 import 'package:firebase_messaging/firebase_messaging.dart';
 import 'package:flutter_callkit_incoming/entities/entities.dart';
 import 'package:flutter_callkit_incoming/flutter_callkit_incoming.dart';
@@ -66,7 +67,7 @@ class StreamVideoPushNotificationManager implements PushNotificationManager {
         _idCallEnded,
         client.events.on<CoordinatorCallEndedEvent>(
           (event) {
-            FlutterCallkitIncoming.endCall(event.callCid.id);
+            endCallByCid(event.callCid.toString());
           },
         ),
       );
@@ -82,7 +83,7 @@ class StreamVideoPushNotificationManager implements PushNotificationManager {
               case CallRingingState.accepted:
               case CallRingingState.rejected:
               case CallRingingState.ended:
-                FlutterCallkitIncoming.endCall(event.callCid.id);
+                endCallByCid(event.callCid.toString());
               case CallRingingState.ringing:
                 break;
             }
@@ -102,7 +103,7 @@ class StreamVideoPushNotificationManager implements PushNotificationManager {
               case CallRingingState.rejected:
               case CallRingingState.ended:
                 await FlutterCallkitIncoming.silenceEvents();
-                await FlutterCallkitIncoming.endCall(event.callCid.id);
+                await endCallByCid(event.callCid.toString());
                 await Future<void>.delayed(const Duration(milliseconds: 300));
                 await FlutterCallkitIncoming.unsilenceEvents();
               case CallRingingState.ringing:
@@ -307,6 +308,16 @@ class StreamVideoPushNotificationManager implements PushNotificationManager {
   @override
   Future<void> endCall(String uuid) => FlutterCallkitIncoming.endCall(uuid);
 
+  Future<void> endCallByCid(String cid) async {
+    final activeCalls = await this.activeCalls();
+    final calls =
+        activeCalls.where((call) => call.callCid == cid && call.uuid != null);
+
+    for (final call in calls) {
+      await endCall(call.uuid!);
+    }
+  }
+
   @override
   Future<String?> getDevicePushTokenVoIP() async {
     if (Platform.isIOS) {