Skip to content

Commit 62811bf

Browse files
renefloorBrazol
andauthored
fix(llc, samples): to run video on windows (#1023)
* Fixes to run video on windows * update changelog * Update packages/stream_video/CHANGELOG.md Co-authored-by: Maciej Brażewicz <[email protected]> * bump webrtc version --------- Co-authored-by: Maciej Brażewicz <[email protected]> Co-authored-by: Brazol <[email protected]>
1 parent b3a7f14 commit 62811bf

File tree

12 files changed

+16
-15
lines changed

12 files changed

+16
-15
lines changed

dogfooding/linux/flutter/generated_plugin_registrant.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include <record_linux/record_linux_plugin.h>
1414
#include <stream_webrtc_flutter/flutter_web_r_t_c_plugin.h>
1515
#include <url_launcher_linux/url_launcher_plugin.h>
16-
#include <volume_controller/volume_controller_plugin.h>
1716

1817
void fl_register_plugins(FlPluginRegistry* registry) {
1918
g_autoptr(FlPluginRegistrar) desktop_drop_registrar =
@@ -37,7 +36,4 @@ void fl_register_plugins(FlPluginRegistry* registry) {
3736
g_autoptr(FlPluginRegistrar) url_launcher_linux_registrar =
3837
fl_plugin_registry_get_registrar_for_plugin(registry, "UrlLauncherPlugin");
3938
url_launcher_plugin_register_with_registrar(url_launcher_linux_registrar);
40-
g_autoptr(FlPluginRegistrar) volume_controller_registrar =
41-
fl_plugin_registry_get_registrar_for_plugin(registry, "VolumeControllerPlugin");
42-
volume_controller_plugin_register_with_registrar(volume_controller_registrar);
4339
}

dogfooding/linux/flutter/generated_plugins.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ list(APPEND FLUTTER_PLUGIN_LIST
1010
record_linux
1111
stream_webrtc_flutter
1212
url_launcher_linux
13-
volume_controller
1413
)
1514

1615
list(APPEND FLUTTER_FFI_PLUGIN_LIST

dogfooding/windows/flutter/CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ include(${EPHEMERAL_DIR}/generated_config.cmake)
1010
# https://github.com/flutter/flutter/issues/57146.
1111
set(WRAPPER_ROOT "${EPHEMERAL_DIR}/cpp_client_wrapper")
1212

13+
# Set fallback configurations for older versions of the flutter tool.
14+
if (NOT DEFINED FLUTTER_TARGET_PLATFORM)
15+
set(FLUTTER_TARGET_PLATFORM "windows-x64")
16+
endif()
17+
1318
# === Flutter Library ===
1419
set(FLUTTER_LIBRARY "${EPHEMERAL_DIR}/flutter_windows.dll")
1520

@@ -92,7 +97,7 @@ add_custom_command(
9297
COMMAND ${CMAKE_COMMAND} -E env
9398
${FLUTTER_TOOL_ENVIRONMENT}
9499
"${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.bat"
95-
windows-x64 $<CONFIG>
100+
${FLUTTER_TARGET_PLATFORM} $<CONFIG>
96101
VERBATIM
97102
)
98103
add_custom_target(flutter_assemble DEPENDS

dogfooding/windows/flutter/generated_plugins.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ list(APPEND FLUTTER_PLUGIN_LIST
1414
media_kit_video
1515
permission_handler_windows
1616
record_windows
17+
screen_brightness_windows
1718
share_plus
1819
stream_webrtc_flutter
1920
thumblr_windows
2021
url_launcher_windows
21-
volume_controller
2222
)
2323

2424
list(APPEND FLUTTER_FFI_PLUGIN_LIST

melos.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ command:
2222
device_info_plus: ">=10.1.2 <12.0.0"
2323
share_plus: ^11.0.0
2424
stream_chat_flutter: ^9.8.0
25-
stream_webrtc_flutter: ^1.0.9
25+
stream_webrtc_flutter: ^1.0.10
2626
stream_video: ^0.10.1
2727
stream_video_flutter: ^0.10.1
2828
stream_video_noise_cancellation: ^0.10.1

packages/stream_video/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
* Deprecated `callRejoinTimeout` in `RetryConfig`, instead added `networkAvailabilityTimeout` to `CallPreferences` to control how long the SDK waits for network connectivity to be restored during reconnection attempts before timing out.
1010

1111
🐞 Fixed
12-
* Sorting of participants after screen sharing stopped.s
12+
* Sorting of participants after screen sharing stopped.
13+
* Fixed `DtlsSrtpKeyAgreement` audio constraint parameter mapping
1314

1415
🔄 Dependency updates
1516
* Updated `flutter_callkit_incoming` dependency to the latests (2.5.5) version. That version contains Android 14 compatibility fixes for ringing notifications and lock screen handling.

packages/stream_video/lib/src/webrtc/media/audio_constraints.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class AudioConstraints extends MediaConstraints {
5353
{'googAutoGainControl': autoGainControl},
5454
{'googHighpassFilter': highPassFilter},
5555
{'googTypingNoiseDetection': typingNoiseDetection},
56-
{'DtlsSrtpKeyAgreement': 'true'},
56+
{'DtlsSrtpKeyAgreement': true},
5757
];
5858
}
5959

packages/stream_video/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ dependencies:
3131
rxdart: ^0.28.0
3232
sdp_transform: ^0.3.2
3333
state_notifier: ^1.0.0
34-
stream_webrtc_flutter: ^1.0.9
34+
stream_webrtc_flutter: ^1.0.10
3535
synchronized: ^3.1.0
3636
system_info2: ^4.0.0
3737
tart: ^0.5.1

packages/stream_video_flutter/example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ dependencies:
3030
stream_video: ^0.10.1
3131
stream_video_flutter: ^0.10.1
3232
stream_video_push_notification: ^0.10.1
33-
stream_webrtc_flutter: ^1.0.9
33+
stream_webrtc_flutter: ^1.0.10
3434

3535
dependency_overrides:
3636
stream_video:

packages/stream_video_flutter/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ dependencies:
2323
plugin_platform_interface: ^2.1.8
2424
rate_limiter: ^1.0.0
2525
stream_video: ^0.10.1
26-
stream_webrtc_flutter: ^1.0.9
26+
stream_webrtc_flutter: ^1.0.10
2727
visibility_detector: ^0.4.0+2
2828

2929
dev_dependencies:

0 commit comments

Comments
 (0)