Skip to content

Commit 8287a60

Browse files
authored
Merge pull request #195 from GetStream/feature/uni-143-disable-the-breaking-enabledtx-audio-option
Temp disable EnableDtx option - it currently breaks the audio
2 parents b94819f + edf89ea commit 8287a60

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

Packages/StreamVideo/Runtime/Core/LowLevelClient/RtcSession.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,14 +1598,16 @@ private async void OnPublisherNegotiationNeeded()
15981598
//This is most likely issue with the webRTC lib
15991599
if (_config.Audio.EnableDtx)
16001600
{
1601-
offer = new RTCSessionDescription()
1602-
{
1603-
type = offer.type,
1604-
sdp = _sdpMungeUtils.ModifySdp(offer.sdp, enableRed: false, _config.Audio.EnableDtx)
1605-
};
1606-
1607-
_logs.Info(
1608-
$"Modified SDP, enable red: {_config.Audio.EnableRed}, enable DTX: {_config.Audio.EnableDtx} ");
1601+
_logs.Error($"The {nameof(IStreamAudioConfig)} option {nameof(IStreamAudioConfig.EnableDtx)} is temporarily disabled and was ignored. " +
1602+
$"This error only notifies that this particular setting does not have any effect currently. Send a support ticket if you need this feature.");
1603+
// offer = new RTCSessionDescription()
1604+
// {
1605+
// type = offer.type,
1606+
// sdp = _sdpMungeUtils.ModifySdp(offer.sdp, enableRed: false, _config.Audio.EnableDtx)
1607+
// };
1608+
//
1609+
// _logs.Info(
1610+
// $"Modified SDP, enable red: {_config.Audio.EnableRed}, enable DTX: {_config.Audio.EnableDtx} ");
16091611
}
16101612

16111613
try

0 commit comments

Comments
 (0)