Skip to content

Commit b1cff4d

Browse files
authored
Merge pull request #193 from shahzadansari/fix/message-top-bar-preview
Remove TopBar dependency on ViewModel
2 parents 2f2d43d + 19330c5 commit b1cff4d

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessageTopBar.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import androidx.compose.ui.Modifier
3232
import androidx.compose.ui.draw.clip
3333
import androidx.compose.ui.tooling.preview.Preview
3434
import androidx.compose.ui.unit.dp
35-
import androidx.hilt.navigation.compose.hiltViewModel
3635
import com.skydoves.landscapist.animation.crossfade.CrossfadePlugin
3736
import com.skydoves.landscapist.components.rememberImageComponent
3837
import com.skydoves.landscapist.glide.GlideImage
@@ -43,9 +42,8 @@ import io.getstream.whatsappclone.uistate.WhatsAppMessageUiState
4342

4443
@Composable
4544
fun WhatsAppMessageTopBar(
46-
channelId: String,
47-
whatsAppMessagesViewModel: WhatsAppMessagesViewModel = hiltViewModel(),
4845
messageUiState: WhatsAppMessageUiState,
46+
navigateToVideoCall: (Boolean) -> Unit,
4947
onBackClick: () -> Unit
5048
) {
5149
TopAppBar(
@@ -70,7 +68,7 @@ fun WhatsAppMessageTopBar(
7068
modifier = Modifier
7169
.size(26.dp)
7270
.clickable {
73-
whatsAppMessagesViewModel.navigateToVideoCall(channelId = channelId, videoCall = true)
71+
navigateToVideoCall(true)
7472
},
7573
imageVector = WhatsAppIcons.Video,
7674
tint = MaterialTheme.colorScheme.tertiary,
@@ -83,7 +81,7 @@ fun WhatsAppMessageTopBar(
8381
modifier = Modifier
8482
.size(26.dp)
8583
.clickable {
86-
whatsAppMessagesViewModel.navigateToVideoCall(channelId = channelId, videoCall = false)
84+
navigateToVideoCall(false)
8785
},
8886
imageVector = WhatsAppIcons.Call,
8987
tint = MaterialTheme.colorScheme.tertiary,
@@ -142,8 +140,8 @@ private fun WhatsAppMessageUserInfo(
142140
private fun WhatsAppTopBarPreview() {
143141
WhatsAppCloneComposeTheme {
144142
WhatsAppMessageTopBar(
145-
channelId = "",
146143
messageUiState = WhatsAppMessageUiState.Loading,
144+
navigateToVideoCall = {},
147145
onBackClick = {}
148146
)
149147
}
@@ -154,8 +152,8 @@ private fun WhatsAppTopBarPreview() {
154152
private fun WhatsAppTopBarDarkPreview() {
155153
WhatsAppCloneComposeTheme(darkTheme = true) {
156154
WhatsAppMessageTopBar(
157-
channelId = "",
158155
messageUiState = WhatsAppMessageUiState.Loading,
156+
navigateToVideoCall = {},
159157
onBackClick = {}
160158
)
161159
}

features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessages.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@ fun WhatsAppMessages(
3838
WhatsAppChatTheme {
3939
Column(Modifier.fillMaxSize()) {
4040
WhatsAppMessageTopBar(
41-
channelId = channelId,
4241
messageUiState = messageUiState,
42+
navigateToVideoCall = {
43+
whatsAppMessagesViewModel.navigateToVideoCall(channelId, videoCall = it)
44+
},
4345
onBackClick = { whatsAppMessagesViewModel.handleEvents(WhatsAppMessageEvent.NavigateUp) }
4446
)
4547

0 commit comments

Comments
 (0)