removed hardcoded compose navigator from composable.

AndroidPoet · AndroidPoet · commit b4fdc4b5b2a5 · 2023-10-18T20:56:45.000+05:30
diff --git a/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppNavHost.kt b/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppNavHost.kt
@@ -22,15 +22,12 @@ import androidx.navigation.compose.NavHost
 
 @Composable
 fun WhatsAppNavHost(
-  navHostController: NavHostController,
-  composeNavigator: AppComposeNavigator
+  navHostController: NavHostController
 ) {
   NavHost(
     navController = navHostController,
     startDestination = WhatsAppScreens.Home.route
   ) {
-    whatsAppHomeNavigation(
-      composeNavigator = composeNavigator
-    )
+    whatsAppHomeNavigation()
   }
 }
diff --git a/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppNavigation.kt b/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppNavigation.kt
@@ -29,13 +29,11 @@ import io.getstream.whatsappclone.ui.WhatsAppTabPager
 import io.getstream.whatsappclone.ui.WhatsAppTopBar
 
 fun NavGraphBuilder.whatsAppHomeNavigation(
-  composeNavigator: AppComposeNavigator
 ) {
   composable(route = WhatsAppScreens.Home.name) {
     Scaffold(topBar = { WhatsAppTopBar() }) { padding ->
       WhatsAppTabPager(
-        modifier = Modifier.padding(padding),
-        composeNavigator = composeNavigator
+        modifier = Modifier.padding(padding)
       )
     }
   }
@@ -47,9 +45,8 @@ fun NavGraphBuilder.whatsAppHomeNavigation(
     val channelId = it.arguments?.getString("channelId") ?: return@composable
     WhatsAppMessages(
       channelId = channelId,
-      composeNavigator = composeNavigator,
-      whatsAppMessagesViewModel = hiltViewModel()
-    )
+
+      )
   }
 
   composable(
@@ -61,7 +58,6 @@ fun NavGraphBuilder.whatsAppHomeNavigation(
 
     WhatsAppCallHistoryInfo(
       whatsAppUser = whatsAppUser,
-      composeNavigator = composeNavigator
-    )
+      )
   }
 }
diff --git a/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppPagerContent.kt b/app/src/main/kotlin/io/getstream/whatsappclone/navigation/WhatsAppPagerContent.kt
@@ -20,16 +20,14 @@ import android.app.Activity
 import androidx.activity.compose.BackHandler
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.platform.LocalContext
-import androidx.hilt.navigation.compose.hiltViewModel
 import io.getstream.whatsappclone.calls.WhatsAppCalls
 import io.getstream.whatsappclone.camera.WhatsAppCamera
-import io.getstream.whatsappclone.chats.WhatsAppChannels
+import io.getstream.whatsappclone.chats.channels.WhatsAppChannels
 import io.getstream.whatsappclone.status.WhatsAppStatus
 
 @Composable
 fun WhatsAppPagerContent(
-  page: Int,
-  composeNavigator: AppComposeNavigator
+  page: Int
 ) {
   val activity = (LocalContext.current as? Activity)
   BackHandler {
@@ -38,11 +36,8 @@ fun WhatsAppPagerContent(
 
   when (page) {
     WhatsAppPage.Camera.index -> WhatsAppCamera()
-    WhatsAppPage.Chats.index -> WhatsAppChannels(composeNavigator = composeNavigator)
+    WhatsAppPage.Chats.index -> WhatsAppChannels()
     WhatsAppPage.Status.index -> WhatsAppStatus()
-    WhatsAppPage.Calls.index -> WhatsAppCalls(
-      composeNavigator = composeNavigator,
-      whatsAppCallsViewModel = hiltViewModel()
-    )
+    WhatsAppPage.Calls.index -> WhatsAppCalls()
   }
 }
diff --git a/app/src/main/kotlin/io/getstream/whatsappclone/ui/WhatsAppCloneMain.kt b/app/src/main/kotlin/io/getstream/whatsappclone/ui/WhatsAppCloneMain.kt
@@ -37,8 +37,7 @@ fun WhatsAppCloneMain(
 
     WhatsAppCloneBackground {
       WhatsAppNavHost(
-        navHostController = navHostController,
-        composeNavigator = composeNavigator
+        navHostController = navHostController
       )
     }
   }
diff --git a/app/src/main/kotlin/io/getstream/whatsappclone/ui/WhatsAppTabPager.kt b/app/src/main/kotlin/io/getstream/whatsappclone/ui/WhatsAppTabPager.kt
@@ -46,8 +46,7 @@ import kotlinx.coroutines.launch
 
 @Composable
 fun WhatsAppTabPager(
-  modifier: Modifier = Modifier,
-  composeNavigator: AppComposeNavigator
+  modifier: Modifier = Modifier
 ) {
   val coroutineScope = rememberCoroutineScope()
   val pagerState = rememberPagerState()
@@ -110,8 +109,7 @@ fun WhatsAppTabPager(
       ) { page ->
 
         WhatsAppPagerContent(
-          page = page,
-          composeNavigator = composeNavigator
+          page = page
         )
       }
     }
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/WhatsAppCalls.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/WhatsAppCalls.kt
@@ -20,30 +20,29 @@ import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.items
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
+import androidx.hilt.navigation.compose.hiltViewModel
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import io.getstream.whatsappclone.designsystem.component.WhatsAppError
 import io.getstream.whatsappclone.designsystem.component.WhatsAppLoadingColumn
-import io.getstream.whatsappclone.navigation.AppComposeNavigator
-import io.getstream.whatsappclone.navigation.WhatsAppScreens
+import io.getstream.whatsappclone.model.WhatsAppUser
 import io.getstream.whatsappclone.uistate.WhatsAppUserUiState
 
 @Composable
 fun WhatsAppCalls(
-  composeNavigator: AppComposeNavigator,
-  whatsAppCallsViewModel: WhatsAppCallsViewModel
+  whatsAppCallsViewModel: WhatsAppCallsViewModel = hiltViewModel()
 ) {
   val whatsAppUsersUiState by whatsAppCallsViewModel.whatsAppUserState.collectAsStateWithLifecycle()
 
   WhatsAppCallsScreen(
-    composeNavigator = composeNavigator,
-    whatsAppUsersUiState = whatsAppUsersUiState
+    whatsAppUsersUiState = whatsAppUsersUiState,
+    onHistoryItemClick = whatsAppCallsViewModel::navigateToCallInfo
   )
 }
 
 @Composable
 private fun WhatsAppCallsScreen(
-  composeNavigator: AppComposeNavigator,
-  whatsAppUsersUiState: WhatsAppUserUiState
+  whatsAppUsersUiState: WhatsAppUserUiState,
+  onHistoryItemClick: (WhatsAppUser) -> Unit,
 ) {
   when (whatsAppUsersUiState) {
     WhatsAppUserUiState.Loading -> WhatsAppLoadingColumn()
@@ -55,7 +54,7 @@ private fun WhatsAppCallsScreen(
           key = { it.name }
         ) {
           WhatsAppCallHistory(whatsAppUser = it) {
-            composeNavigator.navigate(WhatsAppScreens.CallInfo.createRoute(whatsAppUser = it))
+            onHistoryItemClick(it)
           }
         }
       }
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/WhatsAppCallsViewModel.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/WhatsAppCallsViewModel.kt
@@ -21,17 +21,21 @@ import androidx.lifecycle.viewModelScope
 import dagger.hilt.android.lifecycle.HiltViewModel
 import io.getstream.whatsappclone.data.coroutines.WhileSubscribedOrRetained
 import io.getstream.whatsappclone.data.repository.CallHistoryRepository
+import io.getstream.whatsappclone.model.WhatsAppUser
+import io.getstream.whatsappclone.navigation.AppComposeNavigator
+import io.getstream.whatsappclone.navigation.WhatsAppScreens
 import io.getstream.whatsappclone.uistate.WhatsAppUserExtensive
 import io.getstream.whatsappclone.uistate.WhatsAppUserUiState
-import javax.inject.Inject
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.stateIn
+import javax.inject.Inject
 
 @HiltViewModel
 class WhatsAppCallsViewModel @Inject constructor(
-  callHistoryRepository: CallHistoryRepository
+  callHistoryRepository: CallHistoryRepository,
+  private val composeNavigator: AppComposeNavigator
 ) : ViewModel() {
 
   val whatsAppUserState: StateFlow<WhatsAppUserUiState> =
@@ -52,4 +56,8 @@ class WhatsAppCallsViewModel @Inject constructor(
         started = WhileSubscribedOrRetained,
         initialValue = WhatsAppUserUiState.Loading
       )
+
+  fun navigateToCallInfo(whatsAppUser: WhatsAppUser) {
+    composeNavigator.navigate(WhatsAppScreens.CallInfo.createRoute(whatsAppUser = whatsAppUser))
+  }
 }
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryInfo.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryInfo.kt
@@ -21,17 +21,18 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.Scaffold
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.hilt.navigation.compose.hiltViewModel
 import io.getstream.whatsappclone.model.WhatsAppUser
 import io.getstream.whatsappclone.navigation.AppComposeNavigator
 
 @Composable
 fun WhatsAppCallHistoryInfo(
   whatsAppUser: WhatsAppUser,
-  composeNavigator: AppComposeNavigator
+  whatsAppCallHistoryViewModel: WhatsAppCallHistoryViewModel = hiltViewModel()
 ) {
   Scaffold(
     modifier = Modifier.fillMaxSize(),
-    topBar = { WhatsAppCallHistoryTopBar(composeNavigator = composeNavigator) }
+    topBar = { WhatsAppCallHistoryTopBar(onBackClick = whatsAppCallHistoryViewModel::navigateUp) }
   ) {
     WhatsAppCallHistoryInfoBody(
       modifier = Modifier.padding(it),
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryInfoBody.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryInfoBody.kt
@@ -28,6 +28,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.unit.dp
 import androidx.constraintlayout.compose.ConstraintLayout
+import androidx.hilt.navigation.compose.hiltViewModel
 import com.skydoves.landscapist.glide.GlideImage
 import io.getstream.whatsappclone.designsystem.R
 import io.getstream.whatsappclone.designsystem.icon.WhatsAppIcons
@@ -40,7 +41,8 @@ import java.util.Date
 @Composable
 fun WhatsAppCallHistoryInfoBody(
   modifier: Modifier,
-  whatsAppUser: WhatsAppUser
+  whatsAppUser: WhatsAppUser,
+
 ) {
   ConstraintLayout(modifier = modifier.padding(12.dp)) {
     val (image, name, call, divider, location, date) = createRefs()
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryTopBar.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryTopBar.kt
@@ -37,17 +37,17 @@ import io.getstream.whatsappclone.navigation.WhatsAppCloneComposeNavigator
 
 @Composable
 fun WhatsAppCallHistoryTopBar(
-  composeNavigator: AppComposeNavigator
+  onBackClick: () -> Unit
 ) {
   TopAppBar(
     modifier = Modifier.fillMaxWidth(),
     navigationIcon = {
       Icon(
         modifier = Modifier
-          .size(26.dp)
-          .clickable {
-            composeNavigator.navigateUp()
-          },
+            .size(26.dp)
+            .clickable {
+                onBackClick()
+            },
         imageVector = WhatsAppIcons.ArrowBack,
         tint = MaterialTheme.colorScheme.tertiary,
         contentDescription = null
@@ -85,18 +85,15 @@ fun WhatsAppCallHistoryTopBar(
 @Composable
 private fun WhatsAppCallHistoryTopBarPreview() {
   WhatsAppCloneComposeTheme {
-    WhatsAppCallHistoryTopBar(
-      composeNavigator = WhatsAppCloneComposeNavigator()
-    )
+    WhatsAppCallHistoryTopBar(onBackClick = {})
   }
 }
 
 @Preview
 @Composable
 private fun WhatsAppCallHistoryTopBarDarkPreview() {
   WhatsAppCloneComposeTheme(darkTheme = true) {
-    WhatsAppCallHistoryTopBar(
-      composeNavigator = WhatsAppCloneComposeNavigator()
+    WhatsAppCallHistoryTopBar(onBackClick = {}
     )
   }
 }
diff --git a/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryViewModel.kt b/features/calls/src/main/kotlin/io/getstream/whatsappclone/calls/info/WhatsAppCallHistoryViewModel.kt
@@ -0,0 +1,17 @@
+package io.getstream.whatsappclone.calls.info
+
+import androidx.lifecycle.ViewModel
+import dagger.hilt.android.lifecycle.HiltViewModel
+import io.getstream.whatsappclone.navigation.AppComposeNavigator
+import javax.inject.Inject
+
+@HiltViewModel
+class WhatsAppCallHistoryViewModel @Inject constructor(
+  private val composeNavigator: AppComposeNavigator
+) : ViewModel() {
+
+
+  fun navigateUp() {
+    composeNavigator.navigateUp()
+  }
+}
diff --git a/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/channels/WhatsAppChannels.kt b/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/channels/WhatsAppChannels.kt
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package io.getstream.whatsappclone.chats
+package io.getstream.whatsappclone.chats.channels
 
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.fillMaxSize
@@ -28,23 +28,22 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.unit.dp
+import androidx.hilt.navigation.compose.hiltViewModel
 import io.getstream.chat.android.compose.ui.channels.ChannelsScreen
 import io.getstream.whatsappclone.chats.theme.WhatsAppChatTheme
 import io.getstream.whatsappclone.designsystem.icon.WhatsAppIcons
 import io.getstream.whatsappclone.designsystem.theme.GREEN500
-import io.getstream.whatsappclone.navigation.AppComposeNavigator
-import io.getstream.whatsappclone.navigation.WhatsAppScreens
 
 @Composable
 fun WhatsAppChannels(
-  composeNavigator: AppComposeNavigator
+  whatsChannelsViewModel: WhatsChannelsViewModel = hiltViewModel()
 ) {
   WhatsAppChatTheme {
     Box(modifier = Modifier.fillMaxSize()) {
       ChannelsScreen(
         isShowingHeader = false,
         onItemClick = { channel ->
-          composeNavigator.navigate(WhatsAppScreens.Messages.createRoute(channel.cid))
+          whatsChannelsViewModel.navigateToMessages(channel.cid)
         }
       )
 
diff --git a/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/channels/WhatsChannelsViewModel.kt b/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/channels/WhatsChannelsViewModel.kt
@@ -0,0 +1,20 @@
+package io.getstream.whatsappclone.chats.channels
+
+import androidx.lifecycle.ViewModel
+import dagger.hilt.android.lifecycle.HiltViewModel
+import io.getstream.whatsappclone.navigation.AppComposeNavigator
+import io.getstream.whatsappclone.navigation.WhatsAppScreens
+import javax.inject.Inject
+
+@HiltViewModel
+class WhatsChannelsViewModel @Inject constructor(
+  private val composeNavigator: AppComposeNavigator,
+) : ViewModel() {
+
+
+  fun navigateToMessages(channelId: String) {
+    composeNavigator.navigate(WhatsAppScreens.Messages.createRoute(channelId))
+  }
+
+
+}
diff --git a/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessageTopBar.kt b/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessageTopBar.kt
diff --git a/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessages.kt b/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessages.kt
diff --git a/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessagesViewModel.kt b/features/chats/src/main/kotlin/io/getstream/whatsappclone/chats/messages/WhatsAppMessagesViewModel.kt

Original file line number	Diff line number	Diff line change
`@@ -29,13 +29,11 @@ import io.getstream.whatsappclone.ui.WhatsAppTabPager`
`29`	`29`	`import io.getstream.whatsappclone.ui.WhatsAppTopBar`
`30`	`30`
`31`	`31`	`fun NavGraphBuilder.whatsAppHomeNavigation(`
`32`		`- composeNavigator: AppComposeNavigator`
`33`	`32`	`) {`
`34`	`33`	`composable(route = WhatsAppScreens.Home.name) {`
`35`	`34`	`Scaffold(topBar = { WhatsAppTopBar() }) { padding ->`
`36`	`35`	`WhatsAppTabPager(`
`37`		`- modifier = Modifier.padding(padding),`
`38`		`- composeNavigator = composeNavigator`
	`36`	`+ modifier = Modifier.padding(padding)`
`39`	`37`	`)`
`40`	`38`	`}`
`41`	`39`	`}`
`@@ -47,9 +45,8 @@ fun NavGraphBuilder.whatsAppHomeNavigation(`
`47`	`45`	`val channelId = it.arguments?.getString("channelId") ?: return@composable`
`48`	`46`	`WhatsAppMessages(`
`49`	`47`	`channelId = channelId,`
`50`		`- composeNavigator = composeNavigator,`
`51`		`- whatsAppMessagesViewModel = hiltViewModel()`
`52`		`- )`
	`48`	`+`
	`49`	`+ )`
`53`	`50`	`}`
`54`	`51`
`55`	`52`	`composable(`
`@@ -61,7 +58,6 @@ fun NavGraphBuilder.whatsAppHomeNavigation(`
`61`	`58`
`62`	`59`	`WhatsAppCallHistoryInfo(`
`63`	`60`	`whatsAppUser = whatsAppUser,`
`64`		`- composeNavigator = composeNavigator`
`65`		`- )`
	`61`	`+ )`
`66`	`62`	`}`
`67`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ fun WhatsAppCloneMain(`
`37`	`37`
`38`	`38`	`WhatsAppCloneBackground {`
`39`	`39`	`WhatsAppNavHost(`
`40`		`- navHostController = navHostController,`
`41`		`- composeNavigator = composeNavigator`
	`40`	`+ navHostController = navHostController`
`42`	`41`	`)`
`43`	`42`	`}`
`44`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,7 @@ import kotlinx.coroutines.launch`
`46`	`46`
`47`	`47`	`@Composable`
`48`	`48`	`fun WhatsAppTabPager(`
`49`		`- modifier: Modifier = Modifier,`
`50`		`- composeNavigator: AppComposeNavigator`
	`49`	`+ modifier: Modifier = Modifier`
`51`	`50`	`) {`
`52`	`51`	`val coroutineScope = rememberCoroutineScope()`
`53`	`52`	`val pagerState = rememberPagerState()`
`@@ -110,8 +109,7 @@ fun WhatsAppTabPager(`
`110`	`109`	`) { page ->`
`111`	`110`
`112`	`111`	`WhatsAppPagerContent(`
`113`		`- page = page,`
`114`		`- composeNavigator = composeNavigator`
	`112`	`+ page = page`
`115`	`113`	`)`
`116`	`114`	`}`
`117`	`115`	`}`