Make all possible pipeline handler names static. (#880)

This allows for easier integration with tools from ViaVersion like ViaLoader/ViaBedrock and also allows easier modification of the MCPL pipeline.

Author: AlexProgrammerDE

protocol/src/main/java/org/geysermc/mcprotocollib/network/NetworkConstants.java

@@ -7,4 +7,16 @@
 public class NetworkConstants {
     public static final AttributeKey<CompressionConfig> COMPRESSION_ATTRIBUTE_KEY = AttributeKey.valueOf("compression");
     public static final AttributeKey<EncryptionConfig> ENCRYPTION_ATTRIBUTE_KEY = AttributeKey.valueOf("encryption");
+    public static final String PROXY_NAME = "proxy";
+    public static final String PROXY_PROTOCOL_ENCODER_NAME = "proxy-protocol-encoder";
+    public static final String PROXY_PROTOCOL_PACKET_SENDER_NAME = "proxy-protocol-packet-sender";
+    public static final String READ_TIMEOUT_NAME = "read-timeout";
+    public static final String WRITE_TIMEOUT_NAME = "write-timeout";
+    public static final String ENCRYPTION_NAME = "encryption";
+    public static final String SIZER_NAME = "sizer";
+    public static final String COMPRESSION_NAME = "compression";
+    public static final String FLOW_CONTROL_NAME = "flow-control";
+    public static final String CODEC_NAME = "codec";
+    public static final String FLUSH_HANDLER_NAME = "flush-handler";
+    public static final String MANAGER_NAME = "manager";
 }

protocol/src/main/java/org/geysermc/mcprotocollib/network/helper/NettyHelper.java

@@ -15,6 +15,7 @@
 import org.checkerframework.checker.nullness.qual.NonNull;
 import org.checkerframework.checker.nullness.qual.Nullable;
 import org.geysermc.mcprotocollib.network.BuiltinFlags;
+import org.geysermc.mcprotocollib.network.NetworkConstants;
 import org.geysermc.mcprotocollib.network.ProxyInfo;
 import org.geysermc.mcprotocollib.network.Session;
 import org.slf4j.Logger;
@@ -128,8 +129,8 @@ public static void initializeHAProxySupport(Session session, Channel channel) {
             return;
         }
 
-        channel.pipeline().addLast("proxy-protocol-encoder", HAProxyMessageEncoder.INSTANCE);
-        channel.pipeline().addLast("proxy-protocol-packet-sender", new ChannelInboundHandlerAdapter() {
+        channel.pipeline().addLast(NetworkConstants.PROXY_PROTOCOL_ENCODER_NAME, HAProxyMessageEncoder.INSTANCE);
+        channel.pipeline().addLast(NetworkConstants.PROXY_PROTOCOL_PACKET_SENDER_NAME, new ChannelInboundHandlerAdapter() {
             @Override
             public void channelActive(ChannelHandlerContext ctx) throws Exception {
                 HAProxyProxiedProtocol proxiedProtocol = getProxiedProtocol(clientAddress);
@@ -187,23 +188,23 @@ public static void addProxy(ProxyInfo proxy, ChannelPipeline pipeline) {
         switch (proxy.type()) {
             case HTTP -> {
                 if (proxy.username() != null && proxy.password() != null) {
-                    pipeline.addLast("proxy", new HttpProxyHandler(proxy.address(), proxy.username(), proxy.password()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new HttpProxyHandler(proxy.address(), proxy.username(), proxy.password()));
                 } else {
-                    pipeline.addLast("proxy", new HttpProxyHandler(proxy.address()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new HttpProxyHandler(proxy.address()));
                 }
             }
             case SOCKS4 -> {
                 if (proxy.username() != null) {
-                    pipeline.addLast("proxy", new Socks4ProxyHandler(proxy.address(), proxy.username()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new Socks4ProxyHandler(proxy.address(), proxy.username()));
                 } else {
-                    pipeline.addLast("proxy", new Socks4ProxyHandler(proxy.address()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new Socks4ProxyHandler(proxy.address()));
                 }
             }
             case SOCKS5 -> {
                 if (proxy.username() != null && proxy.password() != null) {
-                    pipeline.addLast("proxy", new Socks5ProxyHandler(proxy.address(), proxy.username(), proxy.password()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new Socks5ProxyHandler(proxy.address(), proxy.username(), proxy.password()));
                 } else {
-                    pipeline.addLast("proxy", new Socks5ProxyHandler(proxy.address()));
+                    pipeline.addLast(NetworkConstants.PROXY_NAME, new Socks5ProxyHandler(proxy.address()));
                 }
             }
             default -> throw new UnsupportedOperationException("Unsupported proxy type: " + proxy.type());

protocol/src/main/java/org/geysermc/mcprotocollib/network/netty/MinecraftChannelInitializer.java

@@ -8,6 +8,7 @@
 import io.netty.handler.timeout.WriteTimeoutHandler;
 import lombok.RequiredArgsConstructor;
 import org.geysermc.mcprotocollib.network.BuiltinFlags;
+import org.geysermc.mcprotocollib.network.NetworkConstants;
 import org.geysermc.mcprotocollib.network.Session;
 import org.geysermc.mcprotocollib.network.packet.PacketProtocol;
 
@@ -33,16 +34,16 @@ protected void addHandlers(S session, Channel ch) {
         PacketProtocol protocol = session.getPacketProtocol();
         ChannelPipeline pipeline = ch.pipeline();
 
-        pipeline.addLast("read-timeout", new ReadTimeoutHandler(session.getFlag(BuiltinFlags.READ_TIMEOUT, 30)));
-        pipeline.addLast("write-timeout", new WriteTimeoutHandler(session.getFlag(BuiltinFlags.WRITE_TIMEOUT, 0)));
+        pipeline.addLast(NetworkConstants.READ_TIMEOUT_NAME, new ReadTimeoutHandler(session.getFlag(BuiltinFlags.READ_TIMEOUT, 30)));
+        pipeline.addLast(NetworkConstants.WRITE_TIMEOUT_NAME, new WriteTimeoutHandler(session.getFlag(BuiltinFlags.WRITE_TIMEOUT, 0)));
 
-        pipeline.addLast("encryption", new PacketEncryptorCodec());
-        pipeline.addLast("sizer", new PacketSizerCodec(protocol.getPacketHeader()));
-        pipeline.addLast("compression", new PacketCompressionCodec());
+        pipeline.addLast(NetworkConstants.ENCRYPTION_NAME, new PacketEncryptorCodec());
+        pipeline.addLast(NetworkConstants.SIZER_NAME, new PacketSizerCodec(protocol.getPacketHeader()));
+        pipeline.addLast(NetworkConstants.COMPRESSION_NAME, new PacketCompressionCodec());
 
-        pipeline.addLast("flow-control", new AutoReadFlowControlHandler());
-        pipeline.addLast("codec", new PacketCodec(session, client));
-        pipeline.addLast("flush-handler", new FlushHandler());
-        pipeline.addLast("manager", session);
+        pipeline.addLast(NetworkConstants.FLOW_CONTROL_NAME, new AutoReadFlowControlHandler());
+        pipeline.addLast(NetworkConstants.CODEC_NAME, new PacketCodec(session, client));
+        pipeline.addLast(NetworkConstants.FLUSH_HANDLER_NAME, new FlushHandler());
+        pipeline.addLast(NetworkConstants.MANAGER_NAME, session);
     }
 }