Skip to content

Commit fba638d

Browse files
committed
docs: add changelog and contributor pages
1 parent 2a979ad commit fba638d

File tree

11 files changed

+179
-18
lines changed

11 files changed

+179
-18
lines changed

CONTRIBUTING.md

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Thanks for taking an interest in this awesome little project. We love to bring n
77
* Discussion and general questions/help: [GitHub discussions](https://github.com/GhostofGoes/getmac/discussions) or the [Python Discord server](https://discord.gg/python)
88

99

10-
# Code requirements
10+
## Code requirements
1111

1212
Your code *must*:
1313
* Have tests
@@ -36,22 +36,22 @@ Please be respectful and follow the [Code of Conduct](CODE_OF_CONDUCT.md). Memes
3636
* [ ] Coverage has NOT decreased
3737

3838

39-
# Where to contribute
39+
## Where to contribute
4040

41-
## Good for beginners
41+
### Good for beginners
4242
* Sample collection (see section below)
4343
* Platform testing (see section below)
4444
* Bug reports!
4545
* Documentation (including fixes for grammar and spelling)
4646
* Improving and adding tests for existing samples
4747

48-
## Main areas of focus
48+
### Main areas of focus
4949
* Writing parsers for new commands (Example: `netsh int ipv6`)
5050
* Addressing missing functionality (Example: default interface detection for IPv6 on Windows)
5151
* Adding new features (Example: ability to find MAC by interface index integer)
5252
* Adding tests for internal methods and mocking where necessary
5353

54-
## Platform testing
54+
### Platform testing
5555
Help is dearly needed on testing and rooting out differences in various platforms and configurations. At a basic level, this involves just running the tests on any platforms you use. Open issues for any bugs or quirks you discover, or if you're feeling adventurous, fix it yourself!
5656

5757
**Any platform is fair game!** The following are platforms of special interest:
@@ -61,14 +61,14 @@ Help is dearly needed on testing and rooting out differences in various platform
6161
* Arch Linux
6262
* BSDs
6363

64-
## Sample collection
64+
### Sample collection
6565
Examples of output of various commands is an easy way contribute that is still incredibly helpful.
6666
1. Run the command
6767
2. Copy/paste the output (or redirect output of command, `tee` is helpful here) into an appropriately named `.out` file in `samples/`
6868
3. That's it!
6969

7070

71-
# Getting started
71+
## Getting started
7272
1. Create your own fork of the code through GitHub web interface ([Here's a Guide](https://gist.github.com/Chaser324/ce0505fbed06b947d962))
7373
1. Clone the fork to your computer. This can be done using the [GitHub desktop](https://desktop.github.com/) GUI , `git clone <fork-url>`, or the Git tools in your favorite editor or IDE.
7474
1. Create and checkout a new branch in the fork with either your username (e.g. "ghostofgoes"), or the name of the feature or issue you're working on (e.g. "openbsd-support"). Again, this can be done using the GUI, your favorite editor, or `git checkout -b <branch> origin/<branch>`.
@@ -91,7 +91,7 @@ Examples of output of various commands is an easy way contribute that is still i
9191
8. Submit a pull request!
9292
9393
94-
# Bug reports
94+
## Bug reports
9595
Filing a bug report:
9696
9797
1. Answer these questions:
@@ -107,21 +107,21 @@ Filing a bug report:
107107
**NOTE**: If the issue is a potential security vulnerability, do *NOT* open an issue! Instead, email: ghostofgoes(at)gmail(dot)com
108108
109109
110-
# Features and ideas
110+
## Features and ideas
111111
Ideas for features or other things are welcomed. Open an issue on GitHub detailing the idea, and tag it appropriately (e.g. "Feature" for a new feature).
112112
113113
114-
# Resources
114+
## Resources
115115
116-
## Regex resources (regular expressions)
116+
### Regex resources (regular expressions)
117117
- https://pythex.org/
118118
- https://regex101.com/
119119
- [Python's `re` documentation](https://docs.python.org/3/library/re.html)
120120
- [Python's guide to regex](https://docs.python.org/3/howto/regex.html) (this is actually really helpful)
121121
- https://ultrapico.com/Expresso.htm (I haven't used this but it looks useful)
122122

123123

124-
# Commands
124+
## Commands
125125
```bash
126126
# Create development environment
127127
pdm install -d
@@ -136,10 +136,11 @@ pdm run test
136136
pdm run lint
137137
138138
# Run getmac CLI
139-
pdm run getmac
139+
pdm run getmac --help
140+
pdm run getmac --version
140141
```
141142

142-
# Documentation
143+
## Documentation
143144

144145
The docs are built using Sphinx. They are located in the `docs/` folder, and the configuration is in `docs/conf.py`.
145146

docs/changelog.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
.. include:: ../CHANGELOG.md
2+
:parser: myst_parser.sphinx_

docs/code_of_conduct.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
.. include:: ../CODE_OF_CONDUCT.md
2+
:parser: myst_parser.sphinx_

docs/conf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
'sphinx_argparse_cli', # Adds CLI documentation from argparse
2828
'sphinx_automodapi.automodapi', # API documentation
2929
'sphinx_issues', # GitHub Issues/PRs - :issue:, :pr:
30+
'myst_parser', # Markdown support
3031
]
3132

3233
intersphinx_mapping = {

docs/contributing.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
.. include:: ../CONTRIBUTING.md
2+
:parser: myst_parser.sphinx_

docs/index.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,7 @@ It provides a Python function, :func:`~getmac.getmac.get_mac_address`, and a com
1515
usage
1616
cli
1717
api
18+
changelog
19+
contributing
20+
security
21+
code_of_conduct

docs/misc_docs/TODO.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33

44
## Documentation
55
- [ ] Add guide on using the modules API, e.g. registering a new method in `getmac.getmac.METHODS`, etc.
6-
- [ ] Single page on RTD/publish with GitHub actions built with Sphinx and Furo
6+
- [x] Single page on RTD/publish with GitHub actions built with Sphinx and Furo
77
- [ ] Update docs/usage examples for `get_mac_address()`
8+
- [ ] Include manpage in release
89
- [x] Document possible values for `PLATFORM` variable
910
- [x] Document Method (and subclass) attributes (use Sphinx "#:" comments)
10-
- [ ] Re-add Man pages (and auto-build them in CI and include in releases and the distributions)
11+
- [x] Re-add Man pages (and auto-build them in CI)
1112
- [x] Document `get_by_method()`
1213
- [x] Document `initialize_method_cache()`
1314
- [x] Auto-generated API docs

docs/security.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
.. include:: ../SECURITY.md
2+
:parser: myst_parser.sphinx_

docs/usage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Configuration
3333
=============
3434

3535
TODO: update these for new settings classes
36-
36+
!!
3737

3838

3939
- ``logging.getLogger("getmac")``: Runtime messages and errors are recorded to the ``getmac`` logger using Python's :mod:`logging` module. They can be configured by using :func:`logging.basicConfig` or adding :class:`logging.Handler` instances to the logger named ``"getmac"``.

0 commit comments

Comments
 (0)