Korean text fails to render

[comiluv]

OS: Windows 10 Korean version (20H2 build 19042.1052)
Drago version: 4.30, 4.31

Drago displays incorrect, broken characters when language is set to use Korean

Screenshots below. Red annotations indicate broken text display

Note:
Bug doesn't happen in version 4.23

[comiluv]

Continuing from #4,

Hi, PR accepted. Now the question is when to make a 4.32 with your translation and fixing your problem. I have two problems with that. First, I am currently traveling for three months (until beginning of September). I have a tiny computer with the development environment and I can compile and make a release but it is a little bit more complicated. And second, I see no issue from here and the UI seems correctly translated. For this reason, I am left with no clues for where to start.
Perhaps you could determine if it is a code issue or an install issue by installing portable versions for 4.23 and 4.31 and putting the exe file from 4.31 in 4.23 directory and see what happens, or exchange Languages directory , or things like that.
Tell me also if they are parts witch are correctly translated.
I am comparing the files from both versions to see if I find any reason for the bug without any idea until now. I am sorry to not being able to do more for the moment.

• I installed portable versions of 4.23 and 4.31, then exchanged exe files. The 4.23 version of exe file renders localization correctly, while 4.31 version fails to do so in this setting.
  I also tried exchanging Languages directory between freshly extracted installations from portable versions of 4.23 and 4.31. Portable version 4.23 with language directory of 4.31 renders localization correctly, but portable version of 4.31 with language directory of 4.23 fails to render localization.

• There are some parts which are correctly translated in 4.31, there are also parts that are displayed with untranslated and program shows default fallback as well.

• Below are some screenshots taken from main menu for starter: Red underline indicates correctly translated, yellow highlight marker indicates parts where fallback default is displayed (which is English), and green circle indicates parts where broken text and fallback default is combined where it shouldn't. If you look at closely, you can see that latter parts of green where English is displayed should actually be displayed in next menu item.

Screenshots

• If you fail to reproduce the problem and you're using Windows 10 for the testing environment, what I think you could try is to refer to this Microsoft article on language settings and switch to Korean (which could display as 한국어) for default Windows display language.

• Also you might want to check if you're using external programs such as AppLocale or similar programs which is used to force display of UTF-8 and other encodings that are not supported by default in Windows 10 environment

• Another thing that can be looked at if you can't reproduce the translation error is if you have Windows beta feature "Use Unicode UTF-8 for worldwide language support" ticked in Region Settings which is unticked by default, in case you're using Windows 10. See this link for more info. I tried ticking this and it DOES make 4.31 version translate correctly (indentically to 4.23 without that checkbox ticked), but I'm hesitant to keep this option checked because I heard this option may fix translation problems in some programs while it also could break translation in other areas, producing inconsistencies as described in above link

• My guess is that since translation problem was introduced from 4.30 and up, there must be some code or compiler or other IDE set up associated with UTF-8 decoding that's been changed in up and from 4.30.

I hope you travel safely, in this troubled time of pandemic, which hopefully we might see the end soon.
Regards,

[GillesArcas]

Drago.zip
Hi, thanks for all the work, analysis and suggestions. I have compiled an exe file with another version of the IDE. 4.30 and 4.31 have been compiled with a French IDE while previous version were compiled with an English version. Cannot test if it fixes the problem but it is worthy to try. Tell me.

[comiluv]

I'm afraid the problem persists. I also found out that the problem I described above that there's "fallback" to untranslated English, and that getting repetition of untranslated and broken strings together in a same menu item is due to Drago-Kr.lng file's line ending was in LF whereas it was necessary to be in CRLF. My text editor automatically did that when I saved the file. Even after re-saving Drago-Kr.lng file with line endings set to use CRLF, latest version still shows broken text messages, although now it doesn't show fallbacks to default English or repetitions.

I should probably also mention version 4.23 renders both translations correctly regardless of differences in line endings.