Skip to content

Commit 6975963

Browse files
Merge pull request #4275 from Ginger-Automation/Feature/AccountReportChanges
Updated Ginger Play Itegtration to remove Ginger Html Report Service URL
2 parents 203ffa2 + bd073ef commit 6975963

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

Ginger/Ginger/App.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<add key="TRACE_MAX_LOG_FILE_SIZE_(MB)" value="5"/>
88
<add key="TRACE_MAX_NUMBER_OF_LOG_FILES_BACKUPS" value="10"/>
99
<add key="ACCOUNT_REPORT_SERVICE_URL" value="ginger-report"/>
10-
<add key="HTML_REPORT_SERVICE_URL" value="ginger-html-report"/>
1110
<add key="AI_SERVICE_URL" value="ginger-ai"/>
1211
<add key="EXECUTION_SERVICE" value="ginger-execution"/>
1312
<add key="IDENTITY_SERVICE" value="identity"/>

Ginger/GingerCoreNET/External/GingerPlay/GingerPlayEndPointManager.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ public static class GingerPlayEndPointManager
2828
{
2929
private static readonly string ACCOUNT_REPORT_SERVICE_URL = System.Configuration.ConfigurationManager.AppSettings["ACCOUNT_REPORT_SERVICE_URL"]?.ToString() ?? "ginger-report";
3030

31-
private static readonly string HTML_REPORT_SERVICE_URL = System.Configuration.ConfigurationManager.AppSettings["HTML_REPORT_SERVICE_URL"]?.ToString() ?? "ginger-html-report";
32-
3331
private static readonly string AI_SERVICE_URL = System.Configuration.ConfigurationManager.AppSettings["AI_SERVICE_URL"]?.ToString() ?? "ginger-ai";
3432

3533
private static readonly string EXECUTION_SERVICE = System.Configuration.ConfigurationManager.AppSettings["EXECUTION_SERVICE"]?.ToString() ?? "ginger-execution";
@@ -91,14 +89,14 @@ public static string GetAccountReportServiceUrl()
9189
else
9290
{
9391
Reporter.ToLog(eLogLevel.ERROR, "Error occurred while getting Account Report Service URL");
94-
92+
9593
return null;
9694
}
9795
}
9896
catch (Exception ex)
9997
{
10098
Reporter.ToLog(eLogLevel.ERROR, $"Error occurred while getting Account Report Service URL: {ex.Message}");
101-
99+
102100
return null;
103101
}
104102

@@ -110,7 +108,7 @@ public static string GetHTMLReportServiceUrl()
110108
{
111109
if (!string.IsNullOrEmpty(GingerPlayConfiguration.GingerPlayGatewayUrl) && GingerPlayConfiguration.GingerPlayReportServiceEnabled)
112110
{
113-
return GingerPlayConfiguration.GingerPlayGatewayUrl + HTML_REPORT_SERVICE_URL;
111+
return GingerPlayConfiguration.GingerPlayGatewayUrl + ACCOUNT_REPORT_SERVICE_URL;
114112
}
115113
else if (!string.IsNullOrEmpty(GingerPlayConfiguration.CentralizedHTMLReportServiceURL))
116114
{

0 commit comments

Comments
 (0)