[Feature] Configure logging #152 (#153)

Author: GioF71

Dockerfile

@@ -144,6 +144,7 @@ ENV LIBREFM_PASSWORD ""
 ENV JAMENDO_USERNAME ""
 ENV JAMENDO_PASSWORD ""
 
+ENV MPD_ENABLE_LOGGING ""
 ENV MPD_LOG_LEVEL ""
 ENV SCRIBBLE_VERBOSE ""
 

README.md

@@ -183,6 +183,7 @@ SCRIBBLE_VERBOSE||How verbose `mpdscribble`'s logging should be. Default is 1.
 SCROBBLER_MPD_HOSTNAME||Set when using host mode, defaults to `localhost`
 SCROBBLER_MPD_PORT||Set when using host mode, defaults to `6600`
 PROXY||Proxy support for `mpdscribble`. Example value: `http://the.proxy.server:3128`
+MPD_ENABLE_LOGGING||Defaults to `yes`, set to `no` to disable
 MPD_LOG_LEVEL||Can be `default` or `verbose`
 ZEROCONF_ENABLED||Set to `yes` to enable. Disabled by default.
 ZEROCONF_NAME||Set zeroconf name, used only if `ZEROCONF_ENABLED` is set to `yes`
@@ -284,6 +285,7 @@ Just be careful to use the tag you have built.
 
 Date|Major Changes
 :---|:---
+2022-12-17|Add `MPD_ENABLE_LOGGING`
 2022-12-16|Preset `fiio-e18` now includes mixer
 2022-12-16|Code cleanup
 2022-12-14|Creation of `audio` group also for `pulse` mode if `AUDIO_GID` is specified

app/bin/run-mpd.sh

@@ -214,7 +214,27 @@ echo "state_file_interval \"${state_file_interval}\"" >> $MPD_ALSA_CONFIG_FILE
 echo "sticker_file \"/db/sticker\"" >> $MPD_ALSA_CONFIG_FILE
 echo "bind_to_address \"${MPD_BIND_ADDRESS}\"" >> $MPD_ALSA_CONFIG_FILE
 echo "port \"${MPD_PORT}\"" >> $MPD_ALSA_CONFIG_FILE
-echo "log_file \"/log/mpd.log\"" >> $MPD_ALSA_CONFIG_FILE
+
+logging_enabled=1
+if [ -n "${MPD_ENABLE_LOGGING}" ]; then
+    if [[ "${MPD_ENABLE_LOGGING^^}" == "NO" || 
+          "${MPD_ENABLE_LOGGING^^}" == "N" ]]; then
+        logging_enabled=0
+    elif [[ "${MPD_ENABLE_LOGGING^^}" != "YES" && 
+            "${MPD_ENABLE_LOGGING^^}" != "Y" ]]; then
+        echo "Invalid MPD_ENABLE_LOGGING=[${MPD_ENABLE_LOGGING}]"
+        exit 9
+    fi
+fi
+
+if [ $logging_enabled -eq 1 ]; then
+    echo "log_file \"/log/mpd.log\"" >> $MPD_ALSA_CONFIG_FILE
+    if [ -n "${MPD_LOG_LEVEL}" ]; then
+        echo "log_level \"${MPD_LOG_LEVEL}\"" >> $MPD_ALSA_CONFIG_FILE
+    fi
+else
+    echo "Logging is disabled because MPD_ENABLE_LOGGING is set to [${MPD_ENABLE_LOGGING}]"
+fi
 
 if [[ "${ZEROCONF_ENABLED^^}" == "YES" || "${ZEROCONF_ENABLED^^}" == "Y" ]]; then
     ZEROCONF_ENABLED=yes
@@ -228,9 +248,6 @@ if [ -n "${ZEROCONF_NAME}" ]; then
     echo "zeroconf_name \"${ZEROCONF_NAME}\"" >> $MPD_ALSA_CONFIG_FILE
 fi
 
-if [ -n "${MPD_LOG_LEVEL}" ]; then
-    echo "log_level \"${MPD_LOG_LEVEL}\"" >> $MPD_ALSA_CONFIG_FILE
-fi
 
 ## disable wildmidi decoder
 echo "decoder {" >> $MPD_ALSA_CONFIG_FILE