Skip to content

Commit 1790dcc

Browse files
committed
Fix writing null to a large list.
1 parent 53734da commit 1790dcc

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

DuckDB.NET.Data/Internal/Writer/ListVectorDataWriter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,6 @@ private void ResizeVector(int rowIndex, ulong count)
140140
throw new DuckDBException($"Failed to reserve {vectorReservedSize} for the list vector");
141141
}
142142

143-
listItemWriter.FetchDataPointer();
143+
listItemWriter.InitializerWriter();
144144
}
145145
}

DuckDB.NET.Data/Internal/Writer/VectorDataWriterBase.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,9 @@ internal unsafe bool AppendValueInternal<T>(T value, int rowIndex) where T : unm
109109
return true;
110110
}
111111

112-
internal void FetchDataPointer()
112+
internal void InitializerWriter()
113113
{
114+
validity = default;
114115
vectorData = NativeMethods.Vectors.DuckDBVectorGetData(Vector);
115116
}
116117
}

DuckDB.NET.Test/DuckDBManagedAppenderListTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public void ListValuesNullableDouble()
137137

138138
private void ListValuesInternal<T>(string typeName, Func<Faker, T> generator, int? length = null)
139139
{
140-
var rows = 10;
140+
var rows = 2000;
141141
var table = $"managedAppenderLists";
142142

143143
var columnLength = length.HasValue ? length.Value.ToString() : "";

0 commit comments

Comments
 (0)