Removed old method to register parameterless scalar fuction

Author: Justas N

DuckDB.NET.Data/DuckDBConnection.ScalarFunction.cs

@@ -20,16 +20,6 @@ public void RegisterScalarFunction<TResult>(string name, Action<IDuckDBDataWrite
         RegisterScalarMethod(name, (_, w, index) => action(w, index), TypeExtensions.GetLogicalType<TResult>(), varargs: false, !isPureFunction);
     }
 
-    [Obsolete("Prefer using RegisterScalarFunction<TResult>(string name, Action<IDuckDBDataWriter, ulong> action, bool isPureFunction = false)")]
-    [Experimental("DuckDBNET001")]
-#pragma warning disable DuckDBNET001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
-    public void RegisterScalarFunction<TResult>(string name, Action<IReadOnlyList<IDuckDBDataReader>, IDuckDBDataWriter, ulong> action, bool isPureFunction = false)
-    {
-
-        RegisterScalarMethod(name, action, TypeExtensions.GetLogicalType<TResult>(), varargs: false, !isPureFunction);
-    }
-#pragma warning restore DuckDBNET001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
-
     [Experimental("DuckDBNET001")]
     public void RegisterScalarFunction<T, TResult>(string name, Action<IReadOnlyList<IDuckDBDataReader>, IDuckDBDataWriter, ulong> action, bool isPureFunction = true, bool @params = false)
     {

DuckDB.NET.Test/ScalarFunctionTests.cs

@@ -60,32 +60,6 @@ public void RegisterScalarFunctionWithVarargs()
         longs.Should().BeEquivalentTo(values);
     }
 
-    [Fact]
-#pragma warning disable CA1041 // Provide ObsoleteAttribute message
-    [Obsolete]
-#pragma warning restore CA1041 // Provide ObsoleteAttribute message
-    public void RegisterScalarFunctionWithoutParametersObsolete()
-    {
-        var values = new List<long>();
-        Connection.RegisterScalarFunction<long>("my_random_obsolete", (_, writer, rowCount) =>
-        {
-            for (ulong index = 0; index < rowCount; index++)
-            {
-                var value = Random.Shared.NextInt64();
-
-                writer.WriteValue(value, index);
-
-                values.Add(value);
-            }
-        });
-
-        Command.CommandText = "CREATE TABLE big_table_2 AS SELECT (greatest(random(), 0.1) * 10000)::BIGINT i FROM range(100) t(i);";
-        Command.ExecuteNonQuery();
-
-        var longs = Connection.Query<long>("SELECT my_random_obsolete() FROM big_table_2").ToList();
-        longs.Should().BeEquivalentTo(values);
-    }
-
     [Fact]
     public void RegisterScalarFunctionWithoutParameters()
     {
@@ -102,10 +76,10 @@ public void RegisterScalarFunctionWithoutParameters()
             }
         });
 
-        Command.CommandText = "CREATE TABLE big_table_2_1 AS SELECT (greatest(random(), 0.1) * 10000)::BIGINT i FROM range(100) t(i);";
+        Command.CommandText = "CREATE TABLE big_table_2 AS SELECT (greatest(random(), 0.1) * 10000)::BIGINT i FROM range(100) t(i);";
         Command.ExecuteNonQuery();
 
-        var longs = Connection.Query<long>("SELECT my_random() FROM big_table_2_1").ToList();
+        var longs = Connection.Query<long>("SELECT my_random() FROM big_table_2").ToList();
         longs.Should().BeEquivalentTo(values);
     }