Skip to content

Commit 20f33c7

Browse files
committed
Clarify reasons for skipped tests
1 parent 12f434a commit 20f33c7

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

EntityFramework.Exceptions.Tests/OracleTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ public OracleTests(OracleTestContextFixture fixture) : base(fixture.DemoContext)
1313
}
1414

1515
#if BULK_OPERATIONS
16-
// TODO support ORA-01407: cannot update (string) to NULL
17-
[Fact(Skip = "Oracle has differing error codes for inserting null and updating to null")]
16+
[Fact(Skip = "Skipping until ORA-01407 is supported")]
1817
public override Task RequiredColumnViolationThrowsCannotInsertNullExceptionThroughExecuteUpdate()
1918
{
2019
return Task.CompletedTask;

EntityFramework.Exceptions.Tests/SqliteTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ public override Task NumericOverflowViolationThrowsNumericOverflowException()
4242
}
4343

4444
#if BULK_OPERATIONS
45-
// TODO figure this out
46-
[Fact(Skip = "Skipping because SQLite appears to not check this")]
45+
[Fact(Skip = "Skipping due to an EF Core bug fixed in EF Core 9")]
4746
public override Task MaxLengthViolationThrowsMaxLengthExceededExceptionThroughExecuteUpdate()
4847
{
4948
return Task.CompletedTask;

0 commit comments

Comments
 (0)