Remove BULK_OPERATIONS constant

Author: MarkusG

EntityFramework.Exceptions.Tests/DatabaseTests.cs

@@ -44,7 +44,6 @@ public virtual async Task UniqueColumnViolationThrowsUniqueConstraintException()
         }
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task UniqueColumnViolationThrowsUniqueConstraintExceptionThroughExecuteUpdate()
     {
@@ -58,7 +57,6 @@ await DemoContext.Products
             .Where(p => p.Name == "Bulk Update 1" || p.Name == "Bulk Update 2")
             .ExecuteDeleteAsync();
     }
-#endif
 
     [Fact]
     public virtual async Task UniqueColumnViolationSameNamesIndexesInDifferentSchemasSetsCorrectTableName()
@@ -124,7 +122,6 @@ public virtual async Task RequiredColumnViolationThrowsCannotInsertNullException
         await Assert.ThrowsAsync<CannotInsertNullException>(() => DemoContext.SaveChangesAsync());
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task RequiredColumnViolationThrowsCannotInsertNullExceptionThroughExecuteUpdate()
     {
@@ -135,7 +132,6 @@ public virtual async Task RequiredColumnViolationThrowsCannotInsertNullException
         await Assert.ThrowsAsync<CannotInsertNullException>(async () => await DemoContext.Products.ExecuteUpdateAsync(p => p.SetProperty(pp => pp.Name, (string)null)));
         await DemoContext.Products.Where(p => p.Name == "Bulk Update 1").ExecuteDeleteAsync();
     }
-#endif
 
     [Fact]
     public virtual async Task MaxLengthViolationThrowsMaxLengthExceededException()
@@ -146,7 +142,6 @@ public virtual async Task MaxLengthViolationThrowsMaxLengthExceededException()
         await Assert.ThrowsAsync<MaxLengthExceededException>(() => DemoContext.SaveChangesAsync());
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task MaxLengthViolationThrowsMaxLengthExceededExceptionThroughExecuteUpdate()
     {
@@ -178,7 +173,6 @@ await DemoContext.Products
                 .ExecuteUpdateAsync(p => p.SetProperty(pp => pp.Name, new string('G', DemoContext.ProductNameMaxLength + 5)));
         }
     }
-#endif
 
     [Fact]
     public virtual async Task NumericOverflowViolationThrowsNumericOverflowException()
@@ -191,7 +185,6 @@ public virtual async Task NumericOverflowViolationThrowsNumericOverflowException
         await Assert.ThrowsAsync<NumericOverflowException>(() => DemoContext.SaveChangesAsync());
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task NumericOverflowViolationThrowsNumericOverflowExceptionThroughExecuteUpdate()
     {
@@ -224,7 +217,6 @@ await DemoContext.ProductSales
                 .ExecuteUpdateAsync(s => s.SetProperty(ss => ss.Price, 3141.59265m));
         }
     }
-#endif
 
     [Fact]
     public virtual async Task ReferenceViolationThrowsReferenceConstraintException()
@@ -242,7 +234,6 @@ public virtual async Task ReferenceViolationThrowsReferenceConstraintException()
         }
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task ReferenceViolationThrowsReferenceConstraintExceptionThroughExecuteUpdate()
     {
@@ -282,7 +273,6 @@ await DemoContext.ProductSales
                 .ExecuteUpdateAsync(s => s.SetProperty(ss => ss.ProductId, 0));
         }
     }
-#endif
 
     [Fact]
     public virtual async Task DatabaseUnrelatedExceptionThrowsOriginalException()
@@ -317,7 +307,6 @@ public virtual async Task DeleteParentItemThrowsReferenceConstraintException()
         await Assert.ThrowsAsync<ReferenceConstraintException>(() => DemoContext.SaveChangesAsync());
     }
 
-#if BULK_OPERATIONS
     [Fact]
     public virtual async Task DeleteParentItemThrowsReferenceConstraintExceptionThroughExecuteDelete()
     {
@@ -347,7 +336,6 @@ await DemoContext.Products
                 .ExecuteDeleteAsync();
         }
     }
-#endif
 
     [Fact]
     public async Task NotHandledViolationReThrowsOriginalException()

EntityFramework.Exceptions.Tests/OracleTests.cs

@@ -12,13 +12,11 @@ public OracleTests(OracleTestContextFixture fixture) : base(fixture.DemoContext)
     {
     }
 
-#if BULK_OPERATIONS
     [Fact(Skip = "Skipping until ORA-01407 is supported")]
     public override Task RequiredColumnViolationThrowsCannotInsertNullExceptionThroughExecuteUpdate()
     {
         return Task.CompletedTask;
     }
-#endif
 }
 
 public class OracleTestContextFixture : DemoContextFixture<OracleContainer>

EntityFramework.Exceptions.Tests/SqliteTests.cs

@@ -41,7 +41,6 @@ public override Task NumericOverflowViolationThrowsNumericOverflowException()
             return Task.CompletedTask;
         }
 
-#if BULK_OPERATIONS
         [Fact(Skip = "Skipping due to an EF Core bug fixed in EF Core 9")]
         public override Task MaxLengthViolationThrowsMaxLengthExceededExceptionThroughExecuteUpdate()
         {
@@ -53,7 +52,6 @@ public override Task NumericOverflowViolationThrowsNumericOverflowExceptionThrou
         {
             return Task.CompletedTask;
         }
-#endif
     }
 
     public class SqliteDemoContextFixture : DemoContextFixture<IContainer>

EntityFramework.Exceptions.Tests/Tests.csproj

@@ -48,10 +48,6 @@
     <PackageReference Include="Oracle.EntityFrameworkCore" Version="8.21.121" />
     <PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.2" />
   </ItemGroup>
-  
-  <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
-    <DefineConstants>BULK_OPERATIONS</DefineConstants>
-  </PropertyGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\EntityFramework.Exceptions.MySQL.Pomelo\MySQL.Pomelo.csproj" />