ext/random: Use zend_string macro instead of accessing value directly

Girgias · Girgias · commit 5c9fedcc76a4 · 2025-11-16T22:34:10.000Z
diff --git a/ext/random/random.c b/ext/random/random.c
@@ -357,7 +357,7 @@ PHPAPI zend_string *php_random_bin2hex_le(const void *ptr, const size_t len)
 PHPAPI bool php_random_hex2bin_le(const zend_string *hexstr, void *dest)
 {
 	size_t len = hexstr->len >> 1;
-	const unsigned char *str = (unsigned char *) hexstr->val;
+	const unsigned char *str = (unsigned char *) ZSTR_VAL(hexstr);
 	unsigned char c, l, d;
 	unsigned char *ptr = (unsigned char *) dest;
 	uint32_t is_letter, i = 0;

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ PHPAPI zend_string php_random_bin2hex_le(const void ptr, const size_t len)`
`357`	`357`	`PHPAPI bool php_random_hex2bin_le(const zend_string hexstr, void dest)`
`358`	`358`	`{`
`359`	`359`	`size_t len = hexstr->len >> 1;`
`360`		`- const unsigned char str = (unsigned char ) hexstr->val;`
	`360`	`+ const unsigned char str = (unsigned char ) ZSTR_VAL(hexstr);`
`361`	`361`	`unsigned char c, l, d;`
`362`	`362`	`unsigned char ptr = (unsigned char ) dest;`
`363`	`363`	`uint32_t is_letter, i = 0;`