Voidify zend_cfg_build_predecessors()

It always returned SUCCESS

Author: Girgias

Zend/Optimizer/dfa_pass.c

@@ -57,9 +57,7 @@ zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ct
 		return FAILURE;
 	}
 
-	if (zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg) != SUCCESS) {
-		return FAILURE;
-	}
+	zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg);
 
 	if (ctx->debug_level & ZEND_DUMP_DFA_CFG) {
 		zend_dump_op_array(op_array, ZEND_DUMP_CFG, "dfa cfg", &ssa->cfg);

Zend/Optimizer/zend_cfg.c

@@ -600,7 +600,7 @@ ZEND_API void zend_build_cfg(zend_arena **arena, const zend_op_array *op_array,
 }
 /* }}} */
 
-ZEND_API int zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg) /* {{{ */
+ZEND_API void zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg) /* {{{ */
 {
 	int j, s, edges;
 	zend_basic_block *b;
@@ -658,8 +658,6 @@ ZEND_API int zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg) /* {
 			}
 		}
 	}
-
-	return SUCCESS;
 }
 /* }}} */
 

Zend/Optimizer/zend_cfg.h

@@ -118,7 +118,7 @@ BEGIN_EXTERN_C()
 
 ZEND_API void zend_build_cfg(zend_arena **arena, const zend_op_array *op_array, uint32_t build_flags, zend_cfg *cfg);
 void zend_cfg_remark_reachable_blocks(const zend_op_array *op_array, zend_cfg *cfg);
-ZEND_API int zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg);
+ZEND_API void zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg);
 ZEND_API int zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg);
 ZEND_API int zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg);
 

ext/opcache/jit/zend_jit.c

@@ -1277,9 +1277,7 @@ static int zend_jit_build_cfg(const zend_op_array *op_array, zend_cfg *cfg)
 		return FAILURE;
 	}
 
-	if (zend_cfg_build_predecessors(&CG(arena), cfg) != SUCCESS) {
-		return FAILURE;
-	}
+	zend_cfg_build_predecessors(&CG(arena), cfg);
 
 	/* Compute Dominators Tree */
 	if (zend_cfg_compute_dominators_tree(op_array, cfg) != SUCCESS) {