Fix the default value handling of imagegif()

kocsismate · kocsismate · commit d94d426f6078 · 2020-07-31T10:01:08.000+02:00
diff --git a/ext/gd/gd.c b/ext/gd/gd.c
@@ -4162,7 +4162,7 @@ static void _php_image_output_ctx(INTERNAL_FUNCTION_PARAMETERS, int image_type,
 	zval *to_zval = NULL;
 
 	if (image_type == PHP_GDIMG_TYPE_GIF) {
-		if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|z", &imgind, gd_image_ce, &to_zval) == FAILURE) {
+		if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|z!", &imgind, gd_image_ce, &to_zval) == FAILURE) {
 			RETURN_THROWS();
 		}
 	} else if (image_type == PHP_GDIMG_TYPE_PNG) {

Original file line number	Diff line number	Diff line change
`@@ -4162,7 +4162,7 @@ static void _php_image_output_ctx(INTERNAL_FUNCTION_PARAMETERS, int image_type,`
`4162`	`4162`	`zval *to_zval = NULL;`
`4163`	`4163`
`4164`	`4164`	`if (image_type == PHP_GDIMG_TYPE_GIF) {`
`4165`		`- if (zend_parse_parameters(ZEND_NUM_ARGS(), "O\|z", &imgind, gd_image_ce, &to_zval) == FAILURE) {`
	`4165`	`+ if (zend_parse_parameters(ZEND_NUM_ARGS(), "O\|z!", &imgind, gd_image_ce, &to_zval) == FAILURE) {`
`4166`	`4166`	`RETURN_THROWS();`
`4167`	`4167`	`}`
`4168`	`4168`	`} else if (image_type == PHP_GDIMG_TYPE_PNG) {`