feat(helm): add upstream nginx fine tuning configuration for fails and timeout (#53)

Co-authored-by: Frederic Spiers <[email protected]>

Author: ixxeL2097

helm/ggbridge/README.md

@@ -178,6 +178,9 @@ A Helm chart for installing ggbridge
 | proxy.updateStrategy.rollingUpdate.maxSurge | int | `1` |  |
 | proxy.updateStrategy.rollingUpdate.maxUnavailable | int | `0` |  |
 | proxy.updateStrategy.type | string | `"RollingUpdate"` | Customize updateStrategy |
+| proxy.upstream | object | `{"failTimeout":"5s","maxFails":1}` | Nginx upstream configuration |
+| proxy.upstream.failTimeout | string | `"5s"` | Time during which the specified number of unsuccessful attempts must happen to mark the server as unavailable |
+| proxy.upstream.maxFails | int | `1` | Maximum number of unsuccessful attempts to communicate with the server |
 | proxyProtocol.enabled | bool | `true` | When true, enables proxy protocol v2 for web/tls tunnels |
 | replicaCount | int | `1` | Number of pods for each deployment |
 | resources.limits | object | `{}` | Set container limits |

helm/ggbridge/files/proxy/nginx.conf

@@ -6,6 +6,8 @@
 {{- $fullname := ternary (include "ggbridge.server.fullname" $context) (include "ggbridge.client.fullname" $context) (eq $context.Values.mode "server") -}}
 {{- $ports := $context.Values.proxy.service.ports -}}
 {{- $logLevel := $context.Values.proxy.logLevel -}}
+{{- $maxFails := $context.Values.proxy.upstream.maxFails | default 1 -}}
+{{- $failTimeout := $context.Values.proxy.upstream.failTimeout | default "5s" -}}
 
 load_module "/usr/lib/nginx/modules/ngx_stream_module.so";
 
@@ -34,7 +36,7 @@ stream {
         {{- range $idx := until ($context.Values.deploymentCount | int) }}
           {{- $indexProxyFullname := printf "%s-proxy-%d" $fullname ($idx | int) }}
           {{- $weight := ternary 100 1 (eq $idx $index) }}
-          {{ printf "server %s:%d weight=%d;" (printf "%s.%s.svc.%s" $indexProxyFullname $releaseNamespace $clusterDomain) ($config.port | int) $weight }}
+          {{ printf "server %s:%d weight=%d max_fails=%v fail_timeout=%s;" (printf "%s.%s.svc.%s" $indexProxyFullname $releaseNamespace $clusterDomain) ($config.port | int) $weight $maxFails $failTimeout }}
         {{- end }}
     }
     {{ end }}

helm/ggbridge/values.yaml

@@ -395,6 +395,13 @@ proxy:
   # -- Set proxy labels
   labels: {}
 
+  # -- Nginx upstream configuration
+  upstream:
+    # -- Maximum number of unsuccessful attempts to communicate with the server
+    maxFails: 1
+    # -- Time during which the specified number of unsuccessful attempts must happen to mark the server as unavailable
+    failTimeout: 5s
+
   # -- Set the Proxy DNS resolver
   resolver: kube-dns.kube-system.svc.cluster.local