Skip to content

Commit cee71ec

Browse files
ixxeL2097Frederic Spiers
andauthored
chore(helm): updated timings for readinessProbe and failTimeout nginx (#58)
Co-authored-by: Frederic Spiers <[email protected]>
1 parent c3a8f35 commit cee71ec

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

helm/ggbridge/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ A Helm chart for installing ggbridge
2525
| client.readinessProbe.exec.command[1] | string | `"healthcheck"` | |
2626
| client.readinessProbe.exec.command[2] | string | `"-grace-period=60"` | |
2727
| client.readinessProbe.exec.command[3] | string | `"http://127.0.0.1:9081/healthz"` | |
28-
| client.readinessProbe.failureThreshold | int | `1` | |
28+
| client.readinessProbe.failureThreshold | int | `3` | |
2929
| client.readinessProbe.initialDelaySeconds | int | `10` | |
30-
| client.readinessProbe.periodSeconds | int | `15` | |
30+
| client.readinessProbe.periodSeconds | int | `6` | |
3131
| client.readinessProbe.successThreshold | int | `1` | |
3232
| client.readinessProbe.timeoutSeconds | int | `5` | |
3333
| client.reverseTunnels.health.enabled | bool | `true` | Enable server to client health tunnel |
@@ -75,12 +75,12 @@ A Helm chart for installing ggbridge
7575
| podSecurityContext.enabled | bool | `true` | Enable Pod security Context in deployments |
7676
| proxy.affinity | object | `{}` | Affinity for pod assignment |
7777
| proxy.annotations | object | `{}` | Set proxy annotations |
78-
| proxy.config | object | `{"server":{"proxyConnectTimeout":"10s","proxyTimeout":"600s"},"upstream":{"failTimeout":"10s","maxFails":1}}` | Nginx configuration |
78+
| proxy.config | object | `{"server":{"proxyConnectTimeout":"10s","proxyTimeout":"600s"},"upstream":{"failTimeout":"60s","maxFails":1}}` | Nginx configuration |
7979
| proxy.config.server | object | `{"proxyConnectTimeout":"10s","proxyTimeout":"600s"}` | Nginx server configuration |
8080
| proxy.config.server.proxyConnectTimeout | string | `"10s"` | Nginx proxy timeout for TCP handshake |
8181
| proxy.config.server.proxyTimeout | string | `"600s"` | Nginx proxy timeout for data exchange |
82-
| proxy.config.upstream | object | `{"failTimeout":"10s","maxFails":1}` | Nginx upstream configuration |
83-
| proxy.config.upstream.failTimeout | string | `"10s"` | Time during which the specified number of unsuccessful attempts must happen to mark the server as unavailable |
82+
| proxy.config.upstream | object | `{"failTimeout":"60s","maxFails":1}` | Nginx upstream configuration |
83+
| proxy.config.upstream.failTimeout | string | `"60s"` | Time during which the specified number of unsuccessful attempts must happen to mark the server as unavailable |
8484
| proxy.config.upstream.maxFails | int | `1` | Maximum number of unsuccessful attempts to communicate with the server |
8585
| proxy.labels | object | `{}` | Set proxy labels |
8686
| proxy.logLevel | string | `"notice"` | Set nginx sidecar container and proxy pod log level (default: notice) |
@@ -97,9 +97,9 @@ A Helm chart for installing ggbridge
9797
| proxy.readinessProbe.exec.command[2] | string | `"-pid-file=/var/run/nginx.pid"` | |
9898
| proxy.readinessProbe.exec.command[3] | string | `"-grace-period=60"` | |
9999
| proxy.readinessProbe.exec.command[4] | string | `"http://127.0.0.1:9081/healthz"` | |
100-
| proxy.readinessProbe.failureThreshold | int | `1` | |
100+
| proxy.readinessProbe.failureThreshold | int | `3` | |
101101
| proxy.readinessProbe.initialDelaySeconds | int | `10` | |
102-
| proxy.readinessProbe.periodSeconds | int | `15` | |
102+
| proxy.readinessProbe.periodSeconds | int | `6` | |
103103
| proxy.readinessProbe.successThreshold | int | `1` | |
104104
| proxy.readinessProbe.timeoutSeconds | int | `5` | |
105105
| proxy.replicaCount | int | `1` | Number of pods for each deployment |

helm/ggbridge/files/proxy/nginx.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{{- $ports := $context.Values.proxy.service.ports -}}
88
{{- $logLevel := $context.Values.proxy.logLevel -}}
99
{{- $maxFails := $context.Values.proxy.config.upstream.maxFails | default 1 -}}
10-
{{- $failTimeout := $context.Values.proxy.config.upstream.failTimeout | default "10s" -}}
10+
{{- $failTimeout := $context.Values.proxy.config.upstream.failTimeout | default "60s" -}}
1111
{{- $proxyTimeout := $context.Values.proxy.config.server.proxyTimeout | default "600s" -}}
1212
{{- $proxyConnectTimeout := $context.Values.proxy.config.server.proxyConnectTimeout | default "10s" -}}
1313

helm/ggbridge/values.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,10 @@ client:
300300
- -grace-period=60
301301
- http://127.0.0.1:9081/healthz
302302
initialDelaySeconds: 10
303-
periodSeconds: 15
303+
periodSeconds: 6
304304
timeoutSeconds: 5
305305
successThreshold: 1
306-
failureThreshold: 1
306+
failureThreshold: 3
307307

308308
server:
309309
# -- Configure how much time a tunnel server is going to wait idle (without any new ws clients) before unbinding itself/stopping the server
@@ -408,7 +408,7 @@ proxy:
408408
# -- Maximum number of unsuccessful attempts to communicate with the server
409409
maxFails: 1
410410
# -- Time during which the specified number of unsuccessful attempts must happen to mark the server as unavailable
411-
failTimeout: 10s
411+
failTimeout: 60s
412412

413413
# -- Set the Proxy DNS resolver
414414
resolver: kube-dns.kube-system.svc.cluster.local
@@ -676,10 +676,10 @@ proxy:
676676
- -grace-period=60
677677
- http://127.0.0.1:9081/healthz
678678
initialDelaySeconds: 10
679-
periodSeconds: 15
679+
periodSeconds: 6
680680
timeoutSeconds: 5
681681
successThreshold: 1
682-
failureThreshold: 1
682+
failureThreshold: 3
683683

684684
networkPolicy:
685685
# -- Specifies whether a NetworkPolicy should be created

0 commit comments

Comments
 (0)