Skip to content

Commit 1253100

Browse files
chore: fix tests and typing following py-gitguardian update
1 parent afadbe7 commit 1253100

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

ggshield/verticals/secret/secret_scan_collection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ class Secret:
8484
"""
8585

8686
detector_display_name: str
87-
detector_name: str
88-
detector_group_name: str
87+
detector_name: Optional[str]
88+
detector_group_name: Optional[str]
8989
documentation_url: Optional[str]
9090
validity: str
9191
known_secret: bool

tests/unit/cmd/test_ignore.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,6 @@ def test_do_not_duplicate_last_found_secrets(client, isolated_fs):
209209
THEN only one element should be added
210210
"""
211211
policy_break = PolicyBreak(
212-
"a",
213-
"a",
214212
"a",
215213
"Secrets detection",
216214
None,

0 commit comments

Comments
 (0)