Merge pull request #1068 from GitGuardian/jgriffe/remove-python-3.8-support

gg-jonathangriffe · web-flow · commit 2d6ff018882a · 2025-03-19T15:51:47.000+01:00
chore: remove support for python 3.8
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -79,7 +79,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-22.04, macos-13, windows-2022]
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.9', '3.10', '3.11']
     steps:
       - uses: actions/checkout@v4
         with:
diff --git a/changelog.d/20250319_112122_jonathan.griffe_remove_python_3_9_support.md b/changelog.d/20250319_112122_jonathan.griffe_remove_python_3_9_support.md
@@ -0,0 +1,3 @@
+### Removed
+
+- Removed support for python 3.8
diff --git a/doc/dev/getting-started.md b/doc/dev/getting-started.md
@@ -71,7 +71,7 @@ Run `make lint` to run all configured linters at once.
 
 ## Python version
 
-We're committed to support Python 3.8+ for now.
+We're committed to support Python 3.9+ for now.
 
 ## Opening a pull request
 
diff --git a/doc/pre-receive.sample b/doc/pre-receive.sample
@@ -1,7 +1,7 @@
 #!/bin/sh
 # ggshield as a pre-commit hook
 # Requirements:
-# python >= 3.8, pip
+# python >= 3.9, pip
 # Installation instructions:
 # Run: pip install ggshield
 # Move `pre-receive.sample` to `.git/hooks/pre-receive`
diff --git a/ggshield/__main__.py b/ggshield/__main__.py
@@ -137,11 +137,6 @@ def _set_color(ctx: click.Context):
 def _display_deprecation_message(cfg: Config) -> None:
     for message in cfg.user_config.deprecation_messages:
         ui.display_warning(message)
-    if sys.version_info < (3, 9):
-        ui.display_warning(
-            "Python 3.8 is no longer supported by the Python Software Foundation. "
-            "GGShield will soon require Python 3.9 or above to run."
-        )
 
 
 def _check_for_updates(check_for_updates: bool) -> None:
diff --git a/pdm.lock b/pdm.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -27,13 +27,12 @@ classifiers = [
     "Programming Language :: Python :: 3",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Operating System :: OS Independent",
     "Topic :: Security",
 ]
 license = {text = "MIT"}
-requires-python = ">=3.8.1"
+requires-python = ">=3.9"
 dependencies = [
     "platformdirs~=3.0.0",
     "charset-normalizer~=3.1.0",
diff --git a/scripts/create-ghe-environment b/scripts/create-ghe-environment
@@ -6,7 +6,6 @@ PROGNAME=$(basename "$0")
 ROOT_DIR=$(cd "$(dirname "$0")/.." ; pwd)
 
 declare -A DISTRIB_FOR_GHE_VERSION
-DISTRIB_FOR_GHE_VERSION["3.8"]="buster"
 DISTRIB_FOR_GHE_VERSION["3.9"]="buster"
 DISTRIB_FOR_GHE_VERSION["3.10"]="buster"
 DISTRIB_FOR_GHE_VERSION["3.11"]="bookworm"
diff --git a/tests/unit/cmd/auth/test_login.py b/tests/unit/cmd/auth/test_login.py
@@ -1,5 +1,4 @@
 import json
-import sys
 import urllib.parse as urlparse
 from datetime import datetime, timedelta, timezone
 from enum import IntEnum, auto
@@ -602,12 +601,6 @@ def test_valid_process(
             'You do not need to run "ggshield auth login" again. Future requests will automatically use the token.\n'
         )
 
-        if sys.version_info < (3, 9):
-            message += (
-                "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-                "GGShield will soon require Python 3.9 or above to run.\n"
-            )
-
         assert output.endswith(message)
 
         self._assert_config("mysupertoken")
@@ -804,11 +797,6 @@ def _assert_last_print(output: str, expected_str: str):
         """
         assert that the last log output is the same as the one passed in param
         """
-        if sys.version_info < (3, 9) and "Error:" not in expected_str:
-            expected_str += (
-                "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-                "GGShield will soon require Python 3.9 or above to run.\n"
-            )
         assert output.endswith(expected_str)
 
     def _assert_open_url(
@@ -938,11 +926,6 @@ def test_bad_sso_url(
         exit_code, output = self.run_cmd(cli_fs_runner, method=method)
         assert exit_code > 0, output
         self._webbrowser_open_mock.assert_not_called()
-        if sys.version_info < (3, 9) and "Error:" not in expected_error:
-            expected_error += (
-                "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-                "GGShield will soon require Python 3.9 or above to run.\n"
-            )
         self._assert_last_print(output, expected_error)
 
     @pytest.mark.parametrize(
diff --git a/tests/unit/cmd/auth/test_logout.py b/tests/unit/cmd/auth/test_logout.py
@@ -1,4 +1,3 @@
-import sys
 from typing import Optional, Tuple
 from unittest.mock import Mock
 
@@ -82,12 +81,6 @@ def test_valid_logout(self, revoke, instance_url, monkeypatch, cli_fs_runner):
                 "from your configuration.\n"
             )
 
-        if sys.version_info < (3, 9):
-            expected_output += (
-                "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-                "GGShield will soon require Python 3.9 or above to run.\n"
-            )
-
         assert output == expected_output
 
     def test_logout_revoke_timeout(self, monkeypatch, cli_fs_runner):
diff --git a/tests/unit/cmd/scan/test_docker.py b/tests/unit/cmd/scan/test_docker.py
@@ -1,6 +1,5 @@
 import json
 import re
-import sys
 from pathlib import Path
 from unittest.mock import Mock, patch
 
@@ -90,11 +89,6 @@ def test_docker_scan_abort(
         assert_invoke_ok(result)
 
         expected_output = ""
-        if sys.version_info < (3, 9):
-            expected_output += (
-                "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-                "GGShield will soon require Python 3.9 or above to run.\n"
-            )
         assert result.output == expected_output
 
     @patch("ggshield.cmd.secret.scan.docker.docker_save_to_tmp")
diff --git a/tests/unit/cmd/test_config.py b/tests/unit/cmd/test_config.py
@@ -1,5 +1,4 @@
 import json
-import sys
 from datetime import datetime, timezone
 from typing import Tuple
 
@@ -51,11 +50,6 @@
 
 
 def _check_expected_output(output: str, expected_output: str):
-    if sys.version_info < (3, 9) and "Error:" not in expected_output:
-        expected_output += (
-            "Warning: Python 3.8 is no longer supported by the Python Software Foundation. "
-            "GGShield will soon require Python 3.9 or above to run.\n"
-        )
     assert output == expected_output
 
 
diff --git a/tests/unit/utils/test_files.py b/tests/unit/utils/test_files.py
@@ -1,5 +1,4 @@
 import re
-import sys
 import tarfile
 from io import BytesIO
 from pathlib import Path, PurePath, PurePosixPath, PureWindowsPath
@@ -24,9 +23,7 @@ def test_get_empty_tar():
     tar_stream = BytesIO(empty_tar_bytes)
 
     # THEN the file is considered as a .tar
-    # `tarfile.is_tarfile` won't work until Python 3.9
-    if sys.version_info >= (3, 9):
-        assert tarfile.is_tarfile(tar_stream)
+    assert tarfile.is_tarfile(tar_stream)
 
     # AND it contains no file
     with tarfile.open(fileobj=tar_stream, mode="w:gz") as tar:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+### Removed`
	`2`	`+`
	`3`	`+- Removed support for python 3.8`