Skip to content

Conversation

salome-voltz
Copy link
Collaborator

@salome-voltz salome-voltz commented Aug 18, 2025

Context

This MR fixes #1119, following Pyinstaller maintainers recommandations

Validation

  • Download packages here

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (49887e9) to head (2633b6e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         144      144           
  Lines        6162     6162           
=======================================
  Hits         5669     5669           
  Misses        493      493           
Flag Coverage Δ
unittests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@salome-voltz salome-voltz marked this pull request as ready for review August 19, 2025 08:51
@salome-voltz salome-voltz requested a review from a team as a code owner August 19, 2025 08:51
agateau-gg
agateau-gg previously approved these changes Aug 19, 2025
@agateau-gg agateau-gg dismissed their stale review August 19, 2025 10:14

Missing changelog fragment

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it's worth a changelog fragment: it affects our users.

@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5808-pyinstaller-deprecation-warning branch from 5de4751 to 2633b6e Compare August 19, 2025 12:26
@agateau-gg agateau-gg merged commit 790bbda into main Aug 20, 2025
28 checks passed
@agateau-gg agateau-gg deleted the salomevoltz/scrt-5808-pyinstaller-deprecation-warning branch August 20, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyInstaller deprecation warning
2 participants