Skip to content

Conversation

phililippe
Copy link
Contributor

@phililippe phililippe commented Aug 26, 2025

Context

With the new Bring Your Own Source feature in GIM, we want to propose a simple way to scan CI logs.
But in order to allow this kind of jobs, we must interact with the CI platform to fetch the logs and analyse them.

This PR adds minimal tooling to the ggshield image (curl, jq) to allow listing, fetching CI logs.

What has been done

Added curl and jq packages to the ggshield image.

Validation

See the associated GIM MR.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@phililippe phililippe requested a review from a team as a code owner August 26, 2025 14:14
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (321e951) to head (fb07851).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   91.98%   91.99%   +0.01%     
==========================================
  Files         144      144              
  Lines        6162     6162              
==========================================
+ Hits         5668     5669       +1     
+ Misses        494      493       -1     
Flag Coverage Δ
unittests 91.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to build your own image using ggshield image as a base instead of adding the tools you need to this image?

@phililippe phililippe self-assigned this Aug 26, 2025
@phililippe phililippe requested a review from sevbch August 26, 2025 15:08
@phililippe phililippe closed this Aug 26, 2025
@phililippe phililippe reopened this Aug 26, 2025
@phililippe
Copy link
Contributor Author

@agateau-gg This change is intended to be permanent and available to all ggshield image users. We want users to be able to use this image to scan CI logs as this is a discussed use-case of BYOS. To achieve this, we need to allow logs fetching from the image (meaning API calls and JSON handling). I also made a POC for GIM, I'll ping you both on this MR and the original Slack message to give you more context.

@mathieubellon
Copy link
Collaborator

As seen with @phililippe we prefer the image to stay as lean as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants