fix(errors): extend error status code supported by ggshield #1126
+54
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
- Coverage 91.99% 91.95% -0.05%
==========================================
Files 144 144
Lines 6162 6166 +4
==========================================
+ Hits 5669 5670 +1
- Misses 493 496 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sevbch
approved these changes
Aug 26, 2025
salome-voltz
force-pushed
the
salomevoltz/scrt-5746-ggshield-secret-scan-still-shows-scanning-even-if-theres-an
branch
2 times, most recently
from
b3d357e to
bb0499f
Compare
salome-voltz
force-pushed
the
salomevoltz/scrt-5746-ggshield-secret-scan-still-shows-scanning-even-if-theres-an
branch
from
bb0499f to
07b3633
Compare
salome-voltz
deleted the
salomevoltz/scrt-5746-ggshield-secret-scan-still-shows-scanning-even-if-theres-an
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some error code return by the API are not detected as such by ggshield. As a result, the UI displays "No secret have been found", while the scan failed and the files were not processed. This is misleading.
Examples:
What has been done
handle_api_errorcase list to handle "Source not found" error, and 5xx errorshandle_scan_chunk_errorto display the correct error when the source is not foundValidation
ggshield secret scan path --source-uuid b84b3f32-08df-448e-b49f-11186b003e73 <path>(fake UUID) and ensure the UI displays the expected result. Especially, "No secret have been found" should not be displayed:PR check list
skip-changeloglabel has been added to the PR.