Merge pull request #30 from GitGuardian/irgeek/fix-team-permissions

Use correct team permissions when adding an Owner or Manager to a team

Author: irgeek

team-mapping-gitlab-gitguardian/gitguardian_client.py

@@ -264,6 +264,10 @@ def add_member_to_team(
     Add a member to the team
     """
 
+    if member.access_level in (AccessLevel.OWNER, AccessLevel.MANAGER):
+        is_team_leader = True
+        incident_permission = IncidentPermission.FULL_ACCESS
+
     payload = CreateTeamMember(
         member_id=member.id,
         is_team_leader=is_team_leader,

team-mapping-gitlab-gitguardian/sync_gitlab.py

@@ -325,7 +325,6 @@ def synchronize_team_members(
                     invitation_by_id[team_invitation.invitation_id].email,
                 )
 
-            team_id = gg_team.id
             for member in members_to_add:
                 # If the member exists in GitGuardian, we can add him to the team
                 if member in members_by_emails:
@@ -351,7 +350,7 @@ def synchronize_team_members(
                     None,
                 )
                 if team_member_id:
-                    remove_team_member(team_id, team_member_id)
+                    remove_team_member(gg_team, team_member_id)
 
 
 def infer_gitlab_email(