chore(settings): remove ggshield path from settings

Author: gg-jonathangriffe

package.json

@@ -31,11 +31,6 @@
     "configuration": {
       "title": "GitGuardian",
       "properties": {
-        "gitguardian.GGShieldPath": {
-          "type": "string",
-          "default": null,
-          "markdownDescription": "You can override the embedded GitGuardian CLI binary (ggshield) with a custom path"
-        },
         "gitguardian.apiUrl": {
           "type": "string",
           "default": "",

src/lib/ggshield-configuration-utils.ts

@@ -18,9 +18,7 @@ export function getConfiguration(
   const apiUrl: string | undefined = config.get("apiUrl");
   const allowSelfSigned: boolean = config.get("allowSelfSigned", false);
   return new GGShieldConfiguration(
-    ggshieldPath
-      ? ggshieldPath
-      : getBinaryAbsolutePath(os.platform(), os.arch(), context),
+    getBinaryAbsolutePath(os.platform(), os.arch(), context),
     apiUrl,
     allowSelfSigned || false
   );

src/test/suite/lib/ggshield-configuration-utils.test.ts

@@ -16,11 +16,10 @@ suite("getConfiguration", () => {
   });
 
   test("Vscode settings are correctly read", () => {
+    const context = {} as ExtensionContext;
+    simple.mock(context, "asAbsolutePath").returnWith("");
     getConfigurationMock.returnWith({
       get: (key: string) => {
-        if (key === "GGShieldPath") {
-          return "path/to/ggshield";
-        }
         if (key === "apiUrl") {
           return "https://custom-url.com";
         }
@@ -29,7 +28,7 @@ suite("getConfiguration", () => {
         }
       },
     });
-    const configuration = getConfiguration({} as ExtensionContext);
+    const configuration = getConfiguration(context);
 
     // Assert both workspace.getConfiguration  and GGShieldConfiguration constructor were called
     assert(
@@ -38,7 +37,6 @@ suite("getConfiguration", () => {
     );
 
     // Assert that the configuration has the expected values
-    assert.strictEqual(configuration.ggshieldPath, "path/to/ggshield");
     assert.strictEqual(configuration.apiUrl, "https://custom-url.com");
     assert.strictEqual(configuration.allowSelfSigned, true);
   });